From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Campbell Barton Newsgroups: gmane.emacs.devel Subject: Re: Please stop making extra unnecessary work for us all. Date: Tue, 12 Oct 2021 23:55:31 +1100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18409"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , Emacs developers To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 12 14:57:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maHLb-0004Z9-IN for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Oct 2021 14:57:35 +0200 Original-Received: from localhost ([::1]:43676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maHLa-0007T6-Iy for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Oct 2021 08:57:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maHJt-0005lN-BG for emacs-devel@gnu.org; Tue, 12 Oct 2021 08:55:49 -0400 Original-Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:38439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maHJr-0003S9-0H for emacs-devel@gnu.org; Tue, 12 Oct 2021 08:55:48 -0400 Original-Received: by mail-pj1-x1030.google.com with SMTP id g13-20020a17090a3c8d00b00196286963b9so1807829pjc.3 for ; Tue, 12 Oct 2021 05:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KTusFBHBomIF08i3FE4peSYD35t1zBLC/u1SXex+y7U=; b=k7swZnoQie4SMdNJzSHWZTLQyobHTFOuRmxA9wiK4p+X3qhNQvE8846gedS23SzSkm dKK9ibLjDMrb3lKuIHckHwZf/7T+Je+ehW0ClHkTRDDA5ecpC4YioXEAG1QTWTLKHRLV qt3dA5mRSlmwnrq/rR60HB41Y1Le8/V9rxzkfLjhmLpVb7s4bRWDL3UM0UiM6Bzy7o/2 z15Bdfd9dd26AdvP9bBkL2ss/Qrc2PC9ouvKgeBWv8J5KvMYHbz9lvBuyu2E4EqpQ6aq 2aVVV0GeMOjpJIafeMueGfbdlCywnfVwRdbNwGMyCzYYBLTPLUK2t+SGl6pfo3fMUWJ/ A0ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KTusFBHBomIF08i3FE4peSYD35t1zBLC/u1SXex+y7U=; b=FQd9BfyXlNM9IP8DHwiAVraLmngECeQ1PF2BSq0b7Ycvs1uxYYT8OKnGNBXU5Ji+6J s+yIoSnfOnVR2fBprNRcBaTBFXsFVDwmgK4/BXnII7otU3bhQFo5ORH7YUlfJuy8S+y4 20S3ixah28jS2qqerBtmeeiGr+tlTc+XaTJh2gzHJoK5dsxY63eflJ8R80bsPE4OKdLD 9YlOXjmgDGwmx/+jJLnvmF0RDlU01hKoBAjeIRKWm7Wf6yUp6DE7fY/5iza8v0JLGS8/ 6C2C0ikcNxMZaseQZ6ofbg1Zw1TMX/iNEVmvIz2ScUupbDlvtPZ2n6f7DkVME+ILrdXi Ja6g== X-Gm-Message-State: AOAM53089hywIDViE/r1B91wjhxzal+2NZIEK96I9+dRNZ1wOdf0mxOg VjDkWgXlLeXZM7+b4LDgMbYWQ6hZTHR1TfBvavh01JsrUG0= X-Google-Smtp-Source: ABdhPJxr/AtYsLnpZQ3Svbuy4+pRqa7oI0w3+MBQprEdSJN/0HZ0chnJ/disC3jIqGaVdD7lAlHph1hj96Us1PWLuGE= X-Received: by 2002:a17:902:c713:b0:13f:295d:8064 with SMTP id p19-20020a170902c71300b0013f295d8064mr16920449plp.74.1634043342851; Tue, 12 Oct 2021 05:55:42 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=ideasman42@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276793 Archived-At: On Tue, Oct 12, 2021 at 11:41 PM Alan Mackenzie wrote: > > Hello, Emacs and Stefan K. > > I'm referring to > > commit 0a7bab689c4a113dd295c9db55d8e76a34d5f9e1 > Author: Stefan Kangas > Date: Mon Sep 27 23:56:55 2021 +0200 > > ; Minor stylistic fixes found by checkdoc > > , and several other similar changes. Yes, that was the entire commit > message for an assemblage of patches many hundreds of lines long, not > even mentioning the files changed, never mind the defuns. Sadly, git > has no features for amending inadequate commit messages. > > But the point of this post is that these changes are surely unnecessary > with a miniscule benefit, much like pure whitespace changes. > > And like pure WS changes, they mess up git blame, they make searches in > history more difficult. In some instances they introduce solecisms in > English usage. You can use ".git-blame-ignore-revs" to exclude white-space only changes. Although it's best to limit this "strictly" to whitespace only commits, since including more general cleanups could obscure functional changes. There is still the down-side of causing patches not to apply cleanly and other things you've mentioned. > Many non-functional changes have been made in CC Mode. That > additionally means that patches from standalone CC Mode are even less > likely to apply cleanly in the Emacs branches than they were already. > That means extra unwanted tedious work for me. > > And what are these changes? In at least two instances the case of a > letter in warning messages following a colon was changed from lower to > upper. Or was it the other way around? Come on, please, this is > madness. Who would even notice the case of a letter after a colon in a > warning message, much less care about it? > > I protest at these changes. As far as I can remember, there was no > discussion on emacs-devel preceding them. They are disruptive changes. > Can we please not have any more such. > > Thanks. > > -- > Alan Mackenzie (Nuremberg, Germany). > -- - Campbell