From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Campbell Barton Newsgroups: gmane.emacs.devel Subject: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch) Date: Fri, 29 Oct 2021 12:48:24 +1100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000075f87805cf740665" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12824"; mail-complaints-to="usenet@ciao.gmane.io" To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 29 03:49:18 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mgH1C-00039X-Gf for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Oct 2021 03:49:18 +0200 Original-Received: from localhost ([::1]:50774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgH1A-0005sy-U8 for ged-emacs-devel@m.gmane-mx.org; Thu, 28 Oct 2021 21:49:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgH0Z-0005E9-NL for emacs-devel@gnu.org; Thu, 28 Oct 2021 21:48:39 -0400 Original-Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:41921) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgH0X-0000DM-D2 for emacs-devel@gnu.org; Thu, 28 Oct 2021 21:48:39 -0400 Original-Received: by mail-pl1-x62b.google.com with SMTP id z11so5750755plg.8 for ; Thu, 28 Oct 2021 18:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=bUrKU1C6z3+qcTENzMg0FzZqMYRsijsmz/HPq54AG1o=; b=kz4hL5M2ZtFc/hyA4NbOCkkpbV+podey2khriQGmHcM5Opsn+sv2BRseOpeQJy1G/s qivOOcMNFP22vDXUKFpXOljAtL01LaxVAROAVhYLljDME6Uqwo0YmsFrJeC1IFPkH/sc lSAHy2M1xs4MtEootl7brdcYZMX2VyacyJCOQSq1QEtY55/YmI5rQ3aUkEiYYHGAlTj8 t+uUYyfYC+mmh+dfaRY8DrB8ZEXcHMvcFFgoWwu5+i7jdZkGqmRRQsFEbZcQW1VAZNht I7JGvhrXJj+w0FHzb5Spx77/+fIX7/AU8VNmlEMyICclpKpOTdad4JUWaMtkTvPNbJMe 3Fmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=bUrKU1C6z3+qcTENzMg0FzZqMYRsijsmz/HPq54AG1o=; b=j0zBDnGus1M9rPBJC3QnOXbcZc5i/za5fsDW8lQ6fnGQ7T2XboLLMWMoTtnrkZaP7U DuHOgjEGeBYsxpv5l355Xn0xBiWRKRfC4LtMWfvu/nyriPNYdrv3+FxxnHrA+6ZHTEAF GjonhDUsId5bklh6f0eUUFsPi1nLQx2DDY7UvtSHpT/HdziqP6tczwMyWIssuBbLtB0p 4YpafOWKK45zRoQOdptal+1XLZ81g5+0gW/OhADj/ouss0nQWboz8DvPmCVjJHx/fCsJ CF64YOdC9c9DlFRDQh3ovOMqMSD3W7oS1bm1Nz3Ltg+xNqIGVnBe95wjRgdWtfKU1oFO 7ClA== X-Gm-Message-State: AOAM532Sqd0AEUE8kdo5IUB4c9FqQ/McA2hqyGRo6Hs65yXoByIdODbu ICWmmJcmtOzw6R09cecyrf7dO6yoZGQx9OE/3CrmJwDPyUM= X-Google-Smtp-Source: ABdhPJzpd012GPJw6/M+ZSuklJ51BZcyBK+hCpCneTV2xURT3A4mqPkDA9KPevxjQJ3OquoR9VVNpcSN0/8JTovFY8Y= X-Received: by 2002:a17:90b:4b48:: with SMTP id mi8mr8344766pjb.94.1635472115097; Thu, 28 Oct 2021 18:48:35 -0700 (PDT) Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=ideasman42@gmail.com; helo=mail-pl1-x62b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278158 Archived-At: --00000000000075f87805cf740665 Content-Type: text/plain; charset="UTF-8" Hi, there have been a handful of times I've needed to treat multiple actions as a single action, others too (see stackoverflow question [0]). While this is supported using change groups, the resulting macro ends up being nearly identical to the existing `atomic-change-group' macro. The only difference is a call to undo-amalgamate-change-group. Attached a patch to add `atomic-change-group-undo-amalgamate' so packages don't need to use a modified copy of this macro. [0]: https://emacs.stackexchange.com/questions/7558/how-to-collapse-undo-history -- - Campbell --00000000000075f87805cf740665 Content-Type: text/x-patch; charset="US-ASCII"; name="emacs-atomic-change-group-undo-amalgamate.diff" Content-Disposition: attachment; filename="emacs-atomic-change-group-undo-amalgamate.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kvbpt4z30 Y29tbWl0IDVjZjc5YTE5ZGFjNTE4N2I2ZThmNGY2YzM3OThkMGYzNDhlZmY4OWMKQXV0aG9yOiBD YW1wYmVsbCBCYXJ0b24gPGlkZWFzbWFuNDJAZ21haWwuY29tPgpEYXRlOiAgIEZyaSBPY3QgMjkg MTI6MzM6MjkgMjAyMSArMTEwMAoKICAgIEFkZCBhIHZlcnNpb24gb2YgYXRvbWljLWNoYW5nZS1n cm91cCB0aGF0IGFtYWxnYW1hdGVzIHVuZG8gc3RlcHMKCmRpZmYgLS1naXQgYS9saXNwL3N1YnIu ZWwgYi9saXNwL3N1YnIuZWwKaW5kZXggMzk2NzYyNDljZC4uNGQyY2EwYjk1MyAxMDA2NDQKLS0t IGEvbGlzcC9zdWJyLmVsCisrKyBiL2xpc3Avc3Vici5lbApAQCAtMzQ5MCwxNSArMzQ5MCw4IEBA IHktb3Itbi1wCiAMCiA7OzsgQXRvbWljIGNoYW5nZSBncm91cHMuCiAKLShkZWZtYWNybyBhdG9t aWMtY2hhbmdlLWdyb3VwICgmcmVzdCBib2R5KQotICAiTGlrZSBgcHJvZ24nIGJ1dCBwZXJmb3Jt IEJPRFkgYXMgYW4gYXRvbWljIGNoYW5nZSBncm91cC4KLVRoaXMgbWVhbnMgdGhhdCBpZiBCT0RZ IGV4aXRzIGFibm9ybWFsbHksCi1hbGwgb2YgaXRzIGNoYW5nZXMgdG8gdGhlIGN1cnJlbnQgYnVm ZmVyIGFyZSB1bmRvbmUuCi1UaGlzIHdvcmtzIHJlZ2FyZGxlc3Mgb2Ygd2hldGhlciB1bmRvIGlz IGVuYWJsZWQgaW4gdGhlIGJ1ZmZlci4KLQotVGhpcyBtZWNoYW5pc20gaXMgdHJhbnNwYXJlbnQg dG8gb3JkaW5hcnkgdXNlIG9mIHVuZG87Ci1pZiB1bmRvIGlzIGVuYWJsZWQgaW4gdGhlIGJ1ZmZl ciBhbmQgQk9EWSBzdWNjZWVkcywgdGhlCi11c2VyIGNhbiB1bmRvIHRoZSBjaGFuZ2Ugbm9ybWFs bHkuIgorKGRlZm1hY3JvIGF0b21pYy1jaGFuZ2UtZ3JvdXAtMSAodW5kby1hbWFsZ2FtYXRlICZy ZXN0IGJvZHkpCisgICJJbXBsZW1lbnRhdGlvbiBvZiBgYXRvbWljLWNoYW5nZS1ncm91cCcgJiBg YXRvbWljLWNoYW5nZS1ncm91cC1hbWFsZ2FtYXRlJy4iCiAgIChkZWNsYXJlIChpbmRlbnQgMCkg KGRlYnVnIHQpKQogICAobGV0ICgoaGFuZGxlIChtYWtlLXN5bWJvbCAiLS1jaGFuZ2UtZ3JvdXAt aGFuZGxlLS0iKSkKIAkoc3VjY2VzcyAobWFrZS1zeW1ib2wgIi0tY2hhbmdlLWdyb3VwLXN1Y2Nl c3MtLSIpKSkKQEAgLTM1MTksOSArMzUxMiwyOCBAQCBhdG9taWMtY2hhbmdlLWdyb3VwCiAJIDs7 IEVpdGhlciBvZiB0aGVzZSBmdW5jdGlvbnMgd2lsbCBkaXNhYmxlIHVuZG8KIAkgOzsgaWYgaXQg d2FzIGRpc2FibGVkIGJlZm9yZS4KIAkgKGlmICxzdWNjZXNzCi0JICAgICAoYWNjZXB0LWNoYW5n ZS1ncm91cCAsaGFuZGxlKQorICAgICAgICAgICAgIChwcm9nbgorCSAgICAgICAoYWNjZXB0LWNo YW5nZS1ncm91cCAsaGFuZGxlKQorICAgICAgICAgICAgICAgKHdoZW4gLHVuZG8tYW1hbGdhbWF0 ZQorICAgICAgICAgICAgICAgICAodW5kby1hbWFsZ2FtYXRlLWNoYW5nZS1ncm91cCAsaGFuZGxl KSkpCiAJICAgKGNhbmNlbC1jaGFuZ2UtZ3JvdXAgLGhhbmRsZSkpKSkpKQogCisoZGVmbWFjcm8g YXRvbWljLWNoYW5nZS1ncm91cCAoJnJlc3QgYm9keSkKKyAgIkxpa2UgYHByb2duJyBidXQgcGVy Zm9ybSBCT0RZIGFzIGFuIGF0b21pYyBjaGFuZ2UgZ3JvdXAuCitUaGlzIG1lYW5zIHRoYXQgaWYg Qk9EWSBleGl0cyBhYm5vcm1hbGx5LAorYWxsIG9mIGl0cyBjaGFuZ2VzIHRvIHRoZSBjdXJyZW50 IGJ1ZmZlciBhcmUgdW5kb25lLgorVGhpcyB3b3JrcyByZWdhcmRsZXNzIG9mIHdoZXRoZXIgdW5k byBpcyBlbmFibGVkIGluIHRoZSBidWZmZXIuCisKK1RoaXMgbWVjaGFuaXNtIGlzIHRyYW5zcGFy ZW50IHRvIG9yZGluYXJ5IHVzZSBvZiB1bmRvOworaWYgdW5kbyBpcyBlbmFibGVkIGluIHRoZSBi dWZmZXIgYW5kIEJPRFkgc3VjY2VlZHMsIHRoZQordXNlciBjYW4gdW5kbyB0aGUgY2hhbmdlIG5v cm1hbGx5LiIKKyAgYChhdG9taWMtY2hhbmdlLWdyb3VwLTEgbmlsICxAYm9keSkpCisKKyhkZWZt YWNybyBhdG9taWMtY2hhbmdlLWdyb3VwLXVuZG8tYW1hbGdhbWF0ZSAoJnJlc3QgYm9keSkKKyAg IkEgdmVyc2lvbiBvZiAgYGF0b21pYy1jaGFuZ2UtZ3JvdXAnIHRoYXQgYW1hbGdhbWF0ZXMKK3Ro ZSBjaGFuZ2UgZ3JvdXBzIHVuZG8gZGF0YS4iCisgIGAoYXRvbWljLWNoYW5nZS1ncm91cC0xIHQg LEBib2R5KSkKKwogKGRlZnVuIHByZXBhcmUtY2hhbmdlLWdyb3VwICgmb3B0aW9uYWwgYnVmZmVy KQogICAiUmV0dXJuIGEgaGFuZGxlIGZvciB0aGUgY3VycmVudCBidWZmZXIncyBzdGF0ZSwgZm9y IGEgY2hhbmdlIGdyb3VwLgogSWYgeW91IHNwZWNpZnkgQlVGRkVSLCBtYWtlIGEgaGFuZGxlIGZv ciBCVUZGRVIncyBzdGF0ZSBpbnN0ZWFkLgo= --00000000000075f87805cf740665--