From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Naoya Yamashita Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add gv-define-expander for plist-get Date: Wed, 9 Sep 2020 21:32:07 +0900 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000c9b46805aee0a512" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26543"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 09 14:33:35 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFzI7-0006nU-MU for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Sep 2020 14:33:35 +0200 Original-Received: from localhost ([::1]:50590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFzI6-0004z2-PU for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Sep 2020 08:33:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFzHI-0004Pk-FH for emacs-devel@gnu.org; Wed, 09 Sep 2020 08:32:44 -0400 Original-Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:38570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFzHG-0006iW-HV for emacs-devel@gnu.org; Wed, 09 Sep 2020 08:32:44 -0400 Original-Received: by mail-pg1-x542.google.com with SMTP id l191so1968965pgd.5 for ; Wed, 09 Sep 2020 05:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rFyMvIkkv0isg0ot3rFj0INbkuMTQrgWwI/0W96vY24=; b=FwYmLUQXoTUnsHHWNlKo3IdTQktLYRM3xO6ofPl/O2YxkvBXc2I5KO8MI1kR7Smq8c 3AKtaTKonQi6XjTLqd7r7GenObOHLgV/6IQrLijzrV/jED6epMKxXQ6mMNYtltL2hVe7 CiGw/I32ssTzvMcYLlH6JEwWh3okcHRLppQ0Pi88gngjwbVl8MaEog42r1UYQF6tHMAf 5zCt4jknDJJtN4NjnUb+UZyOdZsv3B2MIAEx4OdhNAaCkeSJhnyERihBkWyZ0VU+4xvG MJYKpoASr/6s16I61NA9zCiZB3DdhnDTMk/wgBPfnqHHSLT0IkrG0u0bMOQKqkg9jzEO Yqbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rFyMvIkkv0isg0ot3rFj0INbkuMTQrgWwI/0W96vY24=; b=IG0L8gFYHdPABRxxX/u3NKuSviDYVB9EooFHjZtcwvB/72y0RxU9sriTc2Z4a40pPC CUJgjqDDcCEKln/rnwnHGl0JXpFUDgkU1ymCvsv2jO24noH1UeCdPsoeKr5OvoQNApz9 J4swjt1KTWGFxKZmyYJr5BJ9HcTS3ayjbNDdx07DCMNjFrqkfsfR1lASXRmtenj4ol/w krEG6i6BZsS1ORvgK0n6hSgJ/h7a+DXNtzgveHB4FaTtlbp/dcpwD3tOC2BfcBR8nM/j OciVxxTaUJbgQFAMDFFZrhuc2zeAIsVE6oZhrjeAMsGpY1W3GlzuX2O7tP0nSdm9swTI cx8w== X-Gm-Message-State: AOAM5332z0AIuw2SNSbJz3zlXutE8Hzp4iRnI5HNFlID5KZit7uyPACF IwJGDs4c9BkDGuYbFO5WoZBBtW42fQBIoyrs2AkP586p3ZbQAA== X-Google-Smtp-Source: ABdhPJx0y775ffGKydSTj3EQVJCIe3Fk5Qe9+7VWOaRII9oyvu9rbHfA0p2+9onTGHiLgedvEMGv+ekh6W0IHUvjZbE= X-Received: by 2002:a65:4d0c:: with SMTP id i12mr458355pgt.267.1599654760911; Wed, 09 Sep 2020 05:32:40 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::542; envelope-from=conao3@gmail.com; helo=mail-pg1-x542.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254863 Archived-At: --000000000000c9b46805aee0a512 Content-Type: multipart/alternative; boundary="000000000000c9b46505aee0a510" --000000000000c9b46505aee0a510 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Looks like I was just confused, thanks for double checking. OK, your welcome (and my patch is mistaken same issue) >> `(cadr ,p) > ^^^^ > car? Thanks. I change this code repeatedly and squash many time, I was confused at that time. > Could you send me the patch against `master`, so I can install it? OK, I recreated the patch and attached it. 2020=E5=B9=B49=E6=9C=889=E6=97=A5(=E6=B0=B4) 12:23 Stefan Monnier : > > I cannot understand this point. Your additional test is passed > > by current code, the additional quote is unneeded I think. > > Looks like I was just confused, thanks for double checking. > > > (lambda (do plist prop) > > (macroexp-let2 macroexp-copyable-p key prop > > (gv-letplace (getter setter) plist > > - (macroexp-let2 nil p `(plist-member ,getter ,key) > > + (macroexp-let2 nil p `(cdr (plist-member ,getter ',key)) > > (funcall do > > `(cadr ,p) > ^^^^ > car? > > Could you send me the patch against `master`, so I can install it? > > > Stefan > > --000000000000c9b46505aee0a510 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Looks like I was just confused, thanks for doubl= e checking.

OK, your welcome (and my patch is mistaken same issue)

>>=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0`(cadr ,p)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 ^^^^
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 car?

Thanks. I = change this code repeatedly and squash many time,
I was confused = at that time.

> Could you send me the patch aga= inst `master`, so I can install it?

OK, I recreate= d the patch and attached it.



2020=E5=B9=B49=E6=9C=889=E6=97=A5(=E6=B0=B4) 12:23 Stefan Monnier &= lt;monnier@iro.umontreal.ca= >:
> I can= not understand this point.=C2=A0 Your additional test is passed
> by current code, the additional quote is unneeded I think.

Looks like I was just confused, thanks for double checking.

>=C2=A0 =C2=A0 (lambda (do plist prop)
>=C2=A0 =C2=A0 =C2=A0 (macroexp-let2 macroexp-copyable-p key prop
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (gv-letplace (getter setter) plist
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 (macroexp-let2 nil p `(plist-member ,gett= er ,key)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (macroexp-let2 nil p `(cdr (plist-member = ,getter ',key))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (funcall do
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0`(cadr ,p)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 ^^^^
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 car?

Could you send me the patch against `master`, so I can install it?


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan

--000000000000c9b46505aee0a510-- --000000000000c9b46805aee0a512 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-gv-define-expander-for-plist-get.patch" Content-Disposition: attachment; filename="0001-Add-gv-define-expander-for-plist-get.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kevd425e0 RnJvbSAzNDk0ZmE3MTA4YzlkZjhkMmY1YjkzYzZkOTc4Yjg4OTQzZjkxNzgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOYW95YSBZYW1hc2hpdGEgPGNvbmFvM0BnbWFpbC5jb20+CkRh dGU6IFdlZCwgOSBTZXAgMjAyMCAwOTo1MjozOSArMDkwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBn di1kZWZpbmUtZXhwYW5kZXIgZm9yIHBsaXN0LWdldAoKSXQgaXMgbmVjZXNzYXJ5IHRvIG1ha2Ug cGxpc3QtZ2V0IGFzIGEgZ2VuZXJhbGl6ZWQgdmFyaWFibGUsIGFuZCB0aGlzCmRlZmluaXRpb24g YWxsb3dzIHVzZXIgdG8gdXNlIHNldGYgYW5kIG90aGVyIHVzZWZ1bCBmdW5jdGlvbnMgb24KcGxp c3QtZ2V0LgoKKiBsaXNwL2VtYWNzLWxpc3AvZ3YuZWw6IEFkZCBndi1kZWZpbmUtZXhwYW5kZXIg Zm9yIHBsaXN0LWdldAoKKiBsaXNwL2VtYWNzLWxpc3AvZ3YtdGVzdHMuZWw6IEFkZCBuZXcgdGVz dHMgZm9yIHBsaXN0LWdldAotLS0KIGxpc3AvZW1hY3MtbGlzcC9ndi5lbCAgICAgICAgICAgIHwg MTEgKysrKysrKysrCiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9ndi10ZXN0cy5lbCB8IDQwICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDUxIGluc2VydGlv bnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvZ3YuZWwgYi9saXNwL2VtYWNzLWxp c3AvZ3YuZWwKaW5kZXggNzhkODZiOWZjMy4uNTQ3MGI4NTMyZiAxMDA2NDQKLS0tIGEvbGlzcC9l bWFjcy1saXNwL2d2LmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9ndi5lbApAQCAtNDE3LDYgKzQx NywxNyBAQCBhbGlzdC1nZXQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBgKGRlbHEgLHAgLGdldHRlcikpKSkpKQogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICx2KSkpKSkpKSkpKQogCisoZ3YtZGVmaW5lLWV4cGFuZGVyIHBsaXN0LWdldAorICAobGFt YmRhIChkbyBwbGlzdCBwcm9wKQorICAgIChtYWNyb2V4cC1sZXQyIG1hY3JvZXhwLWNvcHlhYmxl LXAga2V5IHByb3AKKyAgICAgIChndi1sZXRwbGFjZSAoZ2V0dGVyIHNldHRlcikgcGxpc3QKKyAg ICAgICAgKG1hY3JvZXhwLWxldDIgbmlsIHAgYChjZHIgKHBsaXN0LW1lbWJlciAsZ2V0dGVyICxr ZXkpKQorICAgICAgICAgIChmdW5jYWxsIGRvCisgICAgICAgICAgICAgICAgICAgYChjYXIgLHAp CisgICAgICAgICAgICAgICAgICAgKGxhbWJkYSAodmFsKQorICAgICAgICAgICAgICAgICAgICAg YChpZiAscAorICAgICAgICAgICAgICAgICAgICAgICAgICAoc2V0Y2FyICxwICx2YWwpCisgICAg ICAgICAgICAgICAgICAgICAgICAsKGZ1bmNhbGwgc2V0dGVyIGAoY29ucyAsa2V5IChjb25zICx2 YWwgLGdldHRlcikpKSkpKSkpKSkpCiAKIDs7OyBTb21lIG9jY2FzaW9uYWxseSBoYW5keSBleHRl bnNpb25zLgogCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9ndi10ZXN0cy5lbCBi L3Rlc3QvbGlzcC9lbWFjcy1saXNwL2d2LXRlc3RzLmVsCmluZGV4IDdhODQwMmJlMDcuLjEwZTNi NTMxZjMgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lbWFjcy1saXNwL2d2LXRlc3RzLmVsCisrKyBi L3Rlc3QvbGlzcC9lbWFjcy1saXNwL2d2LXRlc3RzLmVsCkBAIC0xNTYsNiArMTU2LDQ2IEBAIGd2 LXNldHRlci1lZGVidWcKICAgICAgIChldmFsLWJ1ZmZlcikpKQogICAoc2hvdWxkIChlcXVhbCAo Z2V0ICdndi1zZXR0ZXItZWRlYnVnICdndi1zZXR0ZXItZWRlYnVnLXByb3ApICcoMTIzKSkpKQog CisoZXJ0LWRlZnRlc3QgZ3YtcGxpc3QtZ2V0ICgpCisgIChyZXF1aXJlICdjbC1saWIpCisKKyAg OzsgU2ltcGxlIHNldGYgdXNhZ2UgZm9yIHBsaXN0LWdldC4KKyAgKHNob3VsZCAoZXF1YWwgKGxl dCAoKHRhcmdldCAnKDphICJhIiA6YiAiYiIgOmMgImMiKSkpCisgICAgICAgICAgICAgICAgICAg KHNldGYgKHBsaXN0LWdldCB0YXJnZXQgOmIpICJtb2RpZnkiKQorICAgICAgICAgICAgICAgICAg IHRhcmdldCkKKyAgICAgICAgICAgICAgICAgJyg6YSAiYSIgOmIgIm1vZGlmeSIgOmMgImMiKSkp CisKKyAgOzsgT3RoZXIgZnVuY3Rpb24gKGNsLXJvdGF0ZWYpIHVzYWdlIGZvciBwbGlzdC1nZXQu CisgIChzaG91bGQgKGVxdWFsIChsZXQgKCh0YXJnZXQgJyg6YSAiYSIgOmIgImIiIDpjICJjIikp KQorICAgICAgICAgICAgICAgICAgIChjbC1yb3RhdGVmIChwbGlzdC1nZXQgdGFyZ2V0IDpiKSAo cGxpc3QtZ2V0IHRhcmdldCA6YykpCisgICAgICAgICAgICAgICAgICAgdGFyZ2V0KQorICAgICAg ICAgICAgICAgICAnKDphICJhIiA6YiAiYyIgOmMgImIiKSkpCisKKyAgOzsgQWRkIG5ldyBrZXkg dmFsdWUgcGFpciBhdCB0b3Agb2YgbGlzdCBpZiBzZXRmIGZvciBtaXNzaW5nIGtleS4KKyAgKHNo b3VsZCAoZXF1YWwgKGxldCAoKHRhcmdldCAnKDphICJhIiA6YiAiYiIgOmMgImMiKSkpCisgICAg ICAgICAgICAgICAgICAgKHNldGYgKHBsaXN0LWdldCB0YXJnZXQgOmQpICJtb2RpZnkiKQorICAg ICAgICAgICAgICAgICAgIHRhcmdldCkKKyAgICAgICAgICAgICAgICAgJyg6ZCAibW9kaWZ5IiA6 YSAiYSIgOmIgImIiIDpjICJjIikpKQorCisgIDs7IFJvdGF0ZSB3aXRoIG1pc3NpbmcgdmFsdWUu CisgIDs7IFRoZSB2YWx1ZSBjb3JyZXNwb25kaW5nIHRvIHRoZSBtaXNzaW5nIGtleSBpcyBhc3N1 bWVkIHRvIGJlIG5pbC4KKyAgKHNob3VsZCAoZXF1YWwgKGxldCAoKHRhcmdldCAnKDphICJhIiA6 YiAiYiIgOmMgImMiKSkpCisgICAgICAgICAgICAgICAgICAgKGNsLXJvdGF0ZWYgKHBsaXN0LWdl dCB0YXJnZXQgOmIpIChwbGlzdC1nZXQgdGFyZ2V0IDpkKSkKKyAgICAgICAgICAgICAgICAgICB0 YXJnZXQpCisgICAgICAgICAgICAgICAgICcoOmQgImIiIDphICJhIiA6YiBuaWwgOmMgImMiKSkp CisKKyAgOzsgU2ltcGxlIHNldGYgdXNhZ2UgZm9yIHBsaXN0LWdldC4gKHN5bWJvbCBwbGlzdCkK KyAgKHNob3VsZCAoZXF1YWwgKGxldCAoKHRhcmdldCAnKGEgImEiIGIgImIiIGMgImMiKSkpCisg ICAgICAgICAgICAgICAgICAgKHNldGYgKHBsaXN0LWdldCB0YXJnZXQgJ2IpICJtb2RpZnkiKQor ICAgICAgICAgICAgICAgICAgIHRhcmdldCkKKyAgICAgICAgICAgICAgICAgJyhhICJhIiBiICJt b2RpZnkiIGMgImMiKSkpCisKKyAgOzsgT3RoZXIgZnVuY3Rpb24gKGNsLXJvdGF0ZWYpIHVzYWdl IGZvciBwbGlzdC1nZXQuIChzeW1ib2wgcGxpc3QpCisgIChzaG91bGQgKGVxdWFsIChsZXQgKCh0 YXJnZXQgJyhhICJhIiBiICJiIiBjICJjIikpKQorICAgICAgICAgICAgICAgICAgIChjbC1yb3Rh dGVmIChwbGlzdC1nZXQgdGFyZ2V0ICdiKSAocGxpc3QtZ2V0IHRhcmdldCAnYykpCisgICAgICAg ICAgICAgICAgICAgdGFyZ2V0KQorICAgICAgICAgICAgICAgICAnKGEgImEiIGIgImMiIGMgImIi KSkpKQorCiA7OyBgZXJ0LWRlZnRlc3QnIG1lc3NlcyB1cCBtYWNyb2V4cGFuc2lvbiB3aGVuIHRo ZSB0ZXN0IGZpbGUgaXRzZWxmIGlzCiA7OyBjb21waWxlZCAoc2VlIEJ1ZyAjMjQ0MDIpLgogCi0t IAoyLjI4LjAKCg== --000000000000c9b46805aee0a512--