From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rudi C Newsgroups: gmane.emacs.devel Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the target Date: Tue, 9 Nov 2021 16:22:59 +0330 Message-ID: References: <831r58k0cx.fsf@gnu.org> <87tui4qyni.fsf@gnu.org> <83tui4iift.fsf@gnu.org> <874ka43rp1.fsf@gnu.org> <83ee97il43.fsf@gnu.org> <87zgrv33mf.fsf@gnu.org> <838rzfijnj.fsf@gnu.org> <87r1d73312.fsf@gnu.org> <837deziiwz.fsf@gnu.org> <87ee97bgxt.fsf@gnus.org> <87fstn2ydc.fsf@gnu.org> <87bl4a7g2m.fsf@gnus.org> <87sfxmqwdr.fsf@gnu.org> <87bl4a2nng.fsf@gnus.org> <87lf3ew3k5.fsf@gnu.org> <83wnmyf3u3.fsf@gnu.org> <87h7e2vvrp.fsf@gnu.org> <83pmsqez1d.fsf@gnu.org> <87cznimxbd.fsf@gnus.org> <83pmrik2r9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000848a3905d05a97f2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20989"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org, stefankangas@gmail.com, tsdh@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 09 14:01:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkQkl-0005FK-M9 for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Nov 2021 14:01:31 +0100 Original-Received: from localhost ([::1]:39962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkQkh-0006VS-CN for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Nov 2021 08:01:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkQiu-0005EK-GG for emacs-devel@gnu.org; Tue, 09 Nov 2021 07:59:38 -0500 Original-Received: from [2607:f8b0:4864:20::52c] (port=39491 helo=mail-pg1-x52c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkQik-00019S-G8; Tue, 09 Nov 2021 07:59:34 -0500 Original-Received: by mail-pg1-x52c.google.com with SMTP id g184so18417266pgc.6; Tue, 09 Nov 2021 04:59:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GY78XA3Hnqz4QBJbGv6oE3UC3pPdcsvrrCauSSr5Wd0=; b=XixZQDYAkySu9mYgJrwNsfx08iVzY5LIMeRNgwyUYcp1VnmEhsyVrdOj9Nd19d8T2L nY/tHzedU8ob+wWLl3r44hg4a7aXU6pRF1qR3zTnqMWSNubApwuqSim+GgzFdI6d//aA pDUqQkRRtV1hQobpLqf57h6fz0UM2mD9LaKcEmbHRh1dSjuxpN5iFfVZqVNJ2jkPyegz jbdRUkwkLH+ZvIxCnSF9HVM5BC/xdr4fwkHveUkp8wCVWxceKy2ZzJXWQbFlNA84E6/C WajucZMLbmqUNxyfaCruqjqv6Z6SUiPSk7ogI3VaAXvu4ScGBZQdERVqSNgTXtoIKS8s atEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GY78XA3Hnqz4QBJbGv6oE3UC3pPdcsvrrCauSSr5Wd0=; b=OSCO/nkm8V3MYTiY9MUFaN04r4JuP9ZTCcBn/lUdXncsYDUVKtLxTDkc2Mq2/kevK7 RcceumiC9tc9FLQsk6uhf2KzooWdXzFam/MU6JMZaOjCa6H3NLkyk8CpCPuAxpSCtciS iA8rqwYxEZ9KLftK8cOiSL5mhxsDkUVag0sAlHaOpMvluJDOiJmi/8xTcvmsgxkCIrWO uTNsulo8cC8dFWhfvmNCCr3CGduyCEZuo0dwHzXWEzDwxyvC6u2jC4VKXrVoumiKI0E3 5DqcGmE7U7H9sNNSbpv6B24LOdK13a4rro18SUWDyNdVUJ9V2NC5PC3XgK4/heTfL8ve r+xg== X-Gm-Message-State: AOAM533/+Ci+FXSJBHMNtXE5atMDlXW5mgSJoRfwS5FK+x2APqJuo45D NgfaGgeCYEY5Cb6DRtr4/SvyN6r4XgPXCX1H9HZVAPTXh6/3nw== X-Google-Smtp-Source: ABdhPJzVeFePfxoIt0hSeVT+7hdWz85zAmqMkouvsdwslthLD4v7bghAEJxgMLEQkqk9x9vWY3uOi6aQZoRmJL981hM= X-Received: by 2002:a92:de4d:: with SMTP id e13mr4835205ilr.283.1636462391216; Tue, 09 Nov 2021 04:53:11 -0800 (PST) In-Reply-To: <83pmrik2r9.fsf@gnu.org> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52c (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=rudiwillalwaysloveyou@gmail.com; helo=mail-pg1-x52c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279099 Archived-At: --000000000000848a3905d05a97f2 Content-Type: multipart/alternative; boundary="000000000000848a3705d05a97f0" --000000000000848a3705d05a97f0 Content-Type: text/plain; charset="UTF-8" Okay, I have attached a new patch (no need for the previous patches). PS: I inserted newlines into the docstring to make the lines shorter, but this makes the docstring ugly to view (as it is essentially hardwrapping based on an arbitrary column size that the user's screen will not share). On Tue, Nov 2, 2021 at 6:45 PM Eli Zaretskii wrote: > > From: Rudi C > > Date: Tue, 2 Nov 2021 18:38:08 +0330 > > Cc: Eli Zaretskii , Tassilo Horn , Stefan > Kangas , > > emacs-devel@gnu.org > > > > +(defcustom dired-create-destination-dirs-trailing-separator-special nil > > This variable's name is a mouthful; please let's find a shorter name. > > > + "If t, when selecting a single destination in Dired, paths that end > in a path separator will be treated as a non-existent directory, and acted > on according to `dired-create-destination-dirs'. > > + > > +This option is only relevant if `dired-create-destination-dirs' is not > `nil', and you are moving/copying a single directory. > > + > > +For example, when renaming a directory named `old_name' to `new_name/' > (note the trailing path separator), `new_name' might be created depending > on `dired-create-destination-dirs' and `old_name' will be moved into it if > it is created; Otherwise `old_name' will be directly renamed to `new_name'." > > + :type '(choice (const :tag "Do not treat paths with a trailing path > separator specially" nil) > > These lines are too long; please divide them into shorter lines. > --000000000000848a3705d05a97f0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Okay, I have attached a new patch (no nee= d for the previous patches).

PS: I inserted newlines int= o the docstring to make the lines shorter, but this makes the docstring ugl= y to view (as it is essentially hardwrapping based on an arbitrary column s= ize that the user's screen will not share).=C2=A0

=
On Tue, No= v 2, 2021 at 6:45 PM Eli Zaretskii <eliz= @gnu.org> wrote:
> From: Rudi C <rudiwillalwaysloveyou@gmail.com>
> Date: Tue, 2 Nov 2021 18:38:08 +0330
> Cc: Eli Zaretskii <eliz@gnu.org>, Tassilo Horn <tsdh@gnu.org>, Stefan Kangas <stefankangas@gmail.com>, >=C2=A0 =C2=A0 =C2=A0 =C2=A0emacs-devel@gnu.org
>
> +(defcustom dired-create-destination-dirs-trailing-separator-special n= il

This variable's name is a mouthful; please let's find a shorter nam= e.

> +=C2=A0 "If t, when selecting a single destination in Dired, path= s that end in a path separator will be treated as a non-existent directory,= and acted on according to `dired-create-destination-dirs'.
> +
> +This option is only relevant if `dired-create-destination-dirs' i= s not `nil', and you are moving/copying a single directory.
> +
> +For example, when renaming a directory named `old_name' to `new_n= ame/' (note the trailing path separator), `new_name' might be creat= ed depending on `dired-create-destination-dirs' and `old_name' will= be moved into it if it is created; Otherwise `old_name' will be direct= ly renamed to `new_name'."
> +=C2=A0 :type '(choice (const :tag "Do not treat paths with a= trailing path separator specially" nil)

These lines are too long; please divide them into shorter lines.
--000000000000848a3705d05a97f0-- --000000000000848a3905d05a97f2 Content-Type: application/octet-stream; name="0001-Added-dired-create-dirs-trailing-separator.patch" Content-Disposition: attachment; filename="0001-Added-dired-create-dirs-trailing-separator.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kvs3d3td0 RnJvbSAzZGZlYThmNDNhNDU0NzMxMzhkOWQzZDk3MTY2NTgzOTA5NTdiNDk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWdodE1hY2hpbmFyeSA8cnVkaXdpbGxhbHdheXNsb3ZleW91 QGdtYWlsLmNvbT4KRGF0ZTogVHVlLCA5IE5vdiAyMDIxIDE2OjE5OjQ1ICswMzMwClN1YmplY3Q6 IFtQQVRDSF0gQWRkZWQ6IGRpcmVkLWNyZWF0ZS1kaXJzLXRyYWlsaW5nLXNlcGFyYXRvcgoKLS0t CiBsaXNwL2RpcmVkLWF1eC5lbCB8IDI2ICsrKysrKysrKysrKysrKysrKysrKysrKystCiAxIGZp bGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L2xpc3AvZGlyZWQtYXV4LmVsIGIvbGlzcC9kaXJlZC1hdXguZWwKaW5kZXggZWYyOTliMjFmZC4u MDY0ZDllYmE4ZCAxMDA2NDQKLS0tIGEvbGlzcC9kaXJlZC1hdXguZWwKKysrIGIvbGlzcC9kaXJl ZC1hdXguZWwKQEAgLTE3ODksNiArMTc4OSwyNSBAQCBJZiBgYXNrJywgYXNrIGZvciB1c2VyIGNv bmZpcm1hdGlvbi4iCiAgIDpncm91cCAnZGlyZWQKICAgOnZlcnNpb24gIjI3LjEiKQogCisoZGVm Y3VzdG9tIGRpcmVkLWNyZWF0ZS1kaXJzLXRyYWlsaW5nLXNlcGFyYXRvciBuaWwKKyAgIklmIHQs IHdoZW4gc2VsZWN0aW5nIGEgc2luZ2xlIGRlc3RpbmF0aW9uIGluIERpcmVkLAorcGF0aHMgdGhh dCBlbmQgaW4gYSBwYXRoIHNlcGFyYXRvciB3aWxsIGJlIHRyZWF0ZWQgYXMgYSBub24tZXhpc3Rl bnQgZGlyZWN0b3J5LAorYW5kIGFjdGVkIG9uIGFjY29yZGluZyB0byBgZGlyZWQtY3JlYXRlLWRl c3RpbmF0aW9uLWRpcnMnLgorCitUaGlzIG9wdGlvbiBpcyBvbmx5IHJlbGV2YW50IGlmIGBkaXJl ZC1jcmVhdGUtZGVzdGluYXRpb24tZGlycycgaXMgbm90IGBuaWwnLAorYW5kIHlvdSBhcmUgbW92 aW5nL2NvcHlpbmcgYSBzaW5nbGUgZGlyZWN0b3J5LgorCitGb3IgZXhhbXBsZSwgd2hlbiByZW5h bWluZyBhIGRpcmVjdG9yeSBuYW1lZCBgb2xkX25hbWUnIHRvIGBuZXdfbmFtZS8nCisobm90ZSB0 aGUgdHJhaWxpbmcgcGF0aCBzZXBhcmF0b3IpLCBgbmV3X25hbWUnIG1pZ2h0IGJlIGNyZWF0ZWQg ZGVwZW5kaW5nIG9uCitgZGlyZWQtY3JlYXRlLWRlc3RpbmF0aW9uLWRpcnMnIGFuZCBgb2xkX25h bWUnIHdpbGwgYmUgbW92ZWQgaW50byBpdAoraWYgaXQgaXMgY3JlYXRlZDsgT3RoZXJ3aXNlIGBv bGRfbmFtZScgd2lsbCBiZSBkaXJlY3RseSByZW5hbWVkIHRvIGBuZXdfbmFtZScuIgorICA6dHlw ZSAnKGNob2ljZQorICAgICAgICAgIChjb25zdCA6dGFnCisgICAgICAgICAgICAgICAgICJEbyBu b3QgdHJlYXQgcGF0aHMgd2l0aCBhIHRyYWlsaW5nIHBhdGggc2VwYXJhdG9yIHNwZWNpYWxseSIg bmlsKQorICAgICAgICAgIChjb25zdCA6dGFnICJUcmVhdCBwYXRocyB3aXRoIGEgdHJhaWxpbmcg cGF0aCBzZXBhcmF0b3Igc3BlY2lhbGx5IiB0KSkKKyAgOmdyb3VwICdkaXJlZAorICA6dmVyc2lv biAiMjguMSIpCisKIChkZWZ1biBkaXJlZC1tYXliZS1jcmVhdGUtZGlycyAoZGlyKQogICAiQ3Jl YXRlIERJUiBpZiBkb2Vzbid0IGV4aXN0IGFjY29yZGluZyB0byBgZGlyZWQtY3JlYXRlLWRlc3Rp bmF0aW9uLWRpcnMnLiIKICAgKHdoZW4gKGFuZCBkaXJlZC1jcmVhdGUtZGVzdGluYXRpb24tZGly cyAobm90IChmaWxlLWV4aXN0cy1wIGRpcikpKQpAQCAtMjE1Nyw3ICsyMTc2LDEyIEBAIE9wdGlv bmFsIGFyZyBIT1ctVE8gZGV0ZXJtaW5lcyBob3cgdG8gdHJlYXQgdGhlIHRhcmdldC4KIAkJICAg ICB0YXJnZXQtZGlyIG9wLXN5bWJvbCBhcmcgcmZuLWxpc3QgZGVmYXVsdCkpKSkKIAkgKGludG8t ZGlyCiAgICAgICAgICAgKHByb2duCi0gICAgICAgICAgICAodW5sZXNzIGRpcmVkLW9uZS1maWxl IChkaXJlZC1tYXliZS1jcmVhdGUtZGlycyB0YXJnZXQpKQorICAgICAgICAgICAgKHdoZW4KKyAg ICAgICAgICAgICAgICAob3IKKyAgICAgICAgICAgICAgICAgKG5vdCBkaXJlZC1vbmUtZmlsZSkK KyAgICAgICAgICAgICAgICAgKGFuZCBkaXJlZC1jcmVhdGUtZGlycy10cmFpbGluZy1zZXBhcmF0 b3IKKyAgICAgICAgICAgICAgICAgICAgICAoZGlyZWN0b3J5LW5hbWUtcCB0YXJnZXQpKSkKKyAg ICAgICAgICAgICAgKGRpcmVkLW1heWJlLWNyZWF0ZS1kaXJzIHRhcmdldCkpCiAgICAgICAgICAg ICAoY29uZCAoKG51bGwgaG93LXRvKQogCQkgICA7OyBBbGxvdyB1c2VycyB0byBjaGFuZ2UgdGhl IGxldHRlciBjYXNlIG9mCiAJCSAgIDs7IGEgZGlyZWN0b3J5IG9uIGEgY2FzZS1pbnNlbnNpdGl2 ZQotLSAKMi4zMy4xCgo= --000000000000848a3905d05a97f2--