From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rudi C Newsgroups: gmane.emacs.devel Subject: Re: PR: dired-do-create-files now checks for trailing slashes in the target Date: Mon, 1 Nov 2021 19:07:49 +0330 Message-ID: References: <831r58k0cx.fsf@gnu.org> <87tui4qyni.fsf@gnu.org> <83tui4iift.fsf@gnu.org> <874ka43rp1.fsf@gnu.org> <83ee97il43.fsf@gnu.org> <87zgrv33mf.fsf@gnu.org> <838rzfijnj.fsf@gnu.org> <87r1d73312.fsf@gnu.org> <837deziiwz.fsf@gnu.org> <87ee97bgxt.fsf@gnus.org> <87fstn2ydc.fsf@gnu.org> <87bl4a7g2m.fsf@gnus.org> <87sfxmqwdr.fsf@gnu.org> <87bl4a2nng.fsf@gnus.org> <87lf3ew3k5.fsf@gnu.org> <83wnmyf3u3.fsf@gnu.org> <87h7e2vvrp.fsf@gnu.org> <83pmsqez1d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000047561e05cfbbf69d" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16590"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org, Stefan Kangas , Tassilo Horn To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 01 16:38:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhZOT-000480-Cg for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Nov 2021 16:38:41 +0100 Original-Received: from localhost ([::1]:38870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhZOR-0002HA-Vf for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Nov 2021 11:38:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhZNv-0001cj-HT for emacs-devel@gnu.org; Mon, 01 Nov 2021 11:38:07 -0400 Original-Received: from mail-il1-x12c.google.com ([2607:f8b0:4864:20::12c]:36492) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhZNs-0002N3-6N; Mon, 01 Nov 2021 11:38:06 -0400 Original-Received: by mail-il1-x12c.google.com with SMTP id l8so1039536ilv.3; Mon, 01 Nov 2021 08:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2XZ37dJRAmLwCqJwkVIcGGr2qx3wpPRk7rTM5KcTVjg=; b=cSFS/qfyWAqJMUaHgobQ6HAoRrSj9V3Oef458H6JH91M38E+VvIC2Eibmdh7LsPE6u jCmGnnU2i24AAZzxPWQRg5pd3rs5L5OlMUpO8xWmK21EP8+Y4C2LCXMVppJn+VfPwfLK MzzZn26o6q5JQr+HA+LETK+N7YoWDFywFrsdZyEWSmaHGWuK2MzkjamOX1DzODXE9mtl UUMuZucxNInXE5LP/ovY3mNoLQJXCNtAgAspjhWXlIRRCVIH2Ec2Ol16PeZ50B2CRygj w6bJgMi7SOU2sESO043vc64M20vpLqDebNYf9hkNkWBhKWWWn3csmRCIGXo1Q93Zeync qcow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2XZ37dJRAmLwCqJwkVIcGGr2qx3wpPRk7rTM5KcTVjg=; b=K7yCCPERX3/+rjSrMXKMnNVd305s3LexiIG2argVnjswvkmuBMwj+tBNSB0cOr1O/8 aTMpFYNHeKGzAcN8kR+N//fwWktQ1FTNS0eyZ8XTNfsgsLAKMq1Oqf2lSu8Lo917n7/0 AA5Zt1vhnfPQm+m4eibrgPZcJxqgBiB/5RYDyvChuSMUcanOZs2THwUNqXPKLUU7LNgM e06NHySpHnrA2tqvAFLrmITaCwaZHufGJ+xL2E5v8wrOIZiOgF4C0+K5BoMXK/Ds+u4Z aVwtYlgyJR6VSsUHuiNTOl/Yi4VYQ3WwZ2JS/Ojkq8/igVV16z+B6iLHoHYmdp2Ujvmp 6SmQ== X-Gm-Message-State: AOAM532oxfaJCXdqg7oykp6ClYQAFZigqXRx/RFRRGwbsPxdhw2g+g5j d1SfRTYOwhhVaySoHZCQGJvnhUTYHodxum7K7A1N2Qmkgcc= X-Google-Smtp-Source: ABdhPJyaYh6OyJ0V3C0n+nrGXERYRw3pSmTNh7O/Csj0IjT5OuNuLr/oSh24U/2Ct2rmyWlRdwsgRoOBqLUnQWKesfg= X-Received: by 2002:a05:6e02:1c87:: with SMTP id w7mr8510284ill.244.1635781081256; Mon, 01 Nov 2021 08:38:01 -0700 (PDT) In-Reply-To: <83pmsqez1d.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::12c; envelope-from=rudiwillalwaysloveyou@gmail.com; helo=mail-il1-x12c.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278398 Archived-At: --00000000000047561e05cfbbf69d Content-Type: text/plain; charset="UTF-8" My copyright assignment is now done, so we can merge this in. On Thu, Sep 30, 2021 at 9:17 PM Eli Zaretskii wrote: > > From: Tassilo Horn > > Cc: larsi@gnus.org, stefankangas@gmail.com, > rudiwillalwaysloveyou@gmail.com, > > emacs-devel@gnu.org > > Date: Thu, 30 Sep 2021 18:48:13 +0200 > > > > > I'm quite sure you didn't consider all the use cases. E.g., what > > > about foo -> Foo on case-insensitive filesystems? That is a valid use > > > case where the user wants a directory renamed with a different > > > letter-case. > > > > You mean, you'd TAB-complete to the same name foo/ and then capitalize > > the already completed input so that you then have Foo/ with the slash? > > I can see that one might do that if the name is quite long. And that > > use-case would also apply to case-sensitive filesystems. > > On case-sensitive filesystems, the new directory would not exist. > > > So fine, let's have if off by default. > > Thanks. > > > BTW, do we need a copyright assignment for this patch? The actual > > change is about 5 lines (including reformatting) but the new defcustom > > is about a dozen of lines with docstring, and stuff. > > No, we can accept it without an assignment, but that about exhausts > our ability to accept more contributions from Rudi, so I recommend > starting the paperwork now. > --00000000000047561e05cfbbf69d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
My copyright assignment is now done, so we can merge this = in.

On Thu, Sep 30, 2021 at 9:17 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Tassilo Horn <tsdh@gnu.org>
> Cc: larsi@gnus.org= , stefankan= gas@gmail.com, rudiwillalwaysloveyou@gmail.com,
>=C2=A0 emacs-d= evel@gnu.org
> Date: Thu, 30 Sep 2021 18:48:13 +0200
>
> > I'm quite sure you didn't consider all the use cases.=C2= =A0 E.g., what
> > about foo -> Foo on case-insensitive filesystems?=C2=A0 That i= s a valid use
> > case where the user wants a directory renamed with a different > > letter-case.
>
> You mean, you'd TAB-complete to the same name foo/ and then capita= lize
> the already completed input so that you then have Foo/ with the slash?=
> I can see that one might do that if the name is quite long.=C2=A0 And = that
> use-case would also apply to case-sensitive filesystems.

On case-sensitive filesystems, the new directory would not exist.

> So fine, let's have if off by default.

Thanks.

> BTW, do we need a copyright assignment for this patch?=C2=A0 The actua= l
> change is about 5 lines (including reformatting) but the new defcustom=
> is about a dozen of lines with docstring, and stuff.

No, we can accept it without an assignment, but that about exhausts
our ability to accept more contributions from Rudi, so I recommend
starting the paperwork now.
--00000000000047561e05cfbbf69d--