From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Laurence Warne Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 7a8ca202c5e: Fix flakey proced refine tests (Bug#73441) Date: Thu, 21 Nov 2024 19:18:54 +0000 Message-ID: References: <173004423280.3739494.8982201561873340907@vcs3.savannah.gnu.org> <20241027155033.2985235EE9B@vcs3.savannah.gnu.org> <875xoix8sw.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000c721f40627712353" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19895"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 21 20:52:36 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEDEB-0004yA-AY for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Nov 2024 20:52:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEDDj-0006Jg-9m; Thu, 21 Nov 2024 14:52:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEChp-0005tA-08 for emacs-devel@gnu.org; Thu, 21 Nov 2024 14:19:09 -0500 Original-Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEChn-00025V-Dx for emacs-devel@gnu.org; Thu, 21 Nov 2024 14:19:08 -0500 Original-Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-718065d6364so658326a34.3 for ; Thu, 21 Nov 2024 11:19:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732216745; x=1732821545; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3LYp2J9CIzvU5yPhv6NL3yGPHXLbaR/avpV+FxbkJSg=; b=TLEypcMoGmbRR3vn37FsuVWoFQYmo3+TLt5rj1cDfV7R7NVU6ca/1K/BKNwOJfSYgy 2KFmb/zvno+SVlGa3qO8iTrEC52qeBGHVOxJbjhqPHpqbf7qP+zvMnM9hfMDGrKZZSNS gXIZ8YGD+Y6zLtlIVfAcK3A6xYHiMCOGlE1GGmoTlPs59/vIdhhBnLXTFfhfYsW++mZb A7Y1qIZZWbtoxKwKuj13HOi695PTFSK4PzBK4YC31SSCMhvuuBk1mWg/3NaANFuGgXtg pIZBlA+nCuDKiyQplNIFqCH0RlS2HhfpIV3kC+0s9NjDw81y44DBpqvKKCgG2F6z8BlT XdKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732216745; x=1732821545; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3LYp2J9CIzvU5yPhv6NL3yGPHXLbaR/avpV+FxbkJSg=; b=TJcUBJPOQchzTKkNkmA41zPAa5RjcFBIWp9qumXfnBe4AfOBLqPJgtdoH+2fM8Dwnj 6TJxkBCFpr18AfQTR9h8FPBwwapCpG/PxYmPcevPczelRIAp+Pd96Wc3Ln4ZLQgZETsn Xz7Hz0IMrmMeMV4xmHTZP3hheke+MiS20+i3m0+0LHUfCPY29dD5JaZMRFmdOKdazjU2 +kJw0ar/3a3fxGnCWbSqgAMiPL722oNMO9OM5bTz9H63ZZjNgYIk6zb2g99qkz7KT+A/ NsmSwi4FJdEswedA3lrhqoNNntR/d4WuriPGOtuZBei4+RHv3KAZnvWraKhveNHEdCkw WWhw== X-Gm-Message-State: AOJu0Yy2edFiQsHxUD0ItK1Bap/v0lY+Pt8Mn4yKOmiyF+EOkz9MqFtw TSQGjZwKEJZ7kX1FvU5M9LOu6gt1fV24zOBcwJQ15ohjTRPZwmGLbFezHQfGl8Bz3EXpqbP0W3H yD6T3bo0Usv8AhyAOLmizX0P/usc= X-Gm-Gg: ASbGnctmP63QHlL20zCmGtDZWQzy7p5LJjY2u+HMo1BdiBoiOezSLeS+jBQnOolhvdf d5GqOZZkH9k83Ff3F475vMqQTHI2D X-Google-Smtp-Source: AGHT+IGEjCoSXkwJGj/kSrJR6ML81bBGFLXPoEo1xkUXf4pAHr9bm7wA1Fy9ffq/T70PtWV5V6vqbfXqXm4i7ba63Nc= X-Received: by 2002:a05:6358:2810:b0:1c3:7ee0:1e4e with SMTP id e5c5f4694b2df-1ca7970e319mr40441255d.6.1732216745249; Thu, 21 Nov 2024 11:19:05 -0800 (PST) In-Reply-To: <875xoix8sw.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::334; envelope-from=laurencewarne@gmail.com; helo=mail-ot1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 21 Nov 2024 14:52:05 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325557 Archived-At: --000000000000c721f40627712353 Content-Type: multipart/alternative; boundary="000000000000c721f20627712351" --000000000000c721f20627712351 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I've attached a small patch for this. Thanks, Laurence On Wed, Nov 20, 2024 at 2:46=E2=80=AFPM Robert Pluim wro= te: > >>>>> On Sun, 27 Oct 2024 11:50:32 -0400 (EDT), Michael Albinus via > Mailing list for Emacs changes said: > > Michael> branch: emacs-30 > Michael> commit 7a8ca202c5eeb810e5f86510c3ea46d3ec519222 > Michael> Author: Laurence Warne > Michael> Commit: Michael Albinus > > Michael> Fix flakey proced refine tests (Bug#73441) > > Michael> * test/lisp/proced-tests.el (proced-refine-test) > Michael> (proced-refine-with-update-test): Use the much simpler > CPU refinement > Michael> for testing 'proced-refine'. The previous tests made th= e > incorrect > Michael> assumption that refining on the PID of process A only > filtered the > Michael> buffer to contain process A and its children, whereas in > actuality > Michael> the children of process A's children, their children, an= d > so on will > Michael> also be shown. > Michael> (proced-update-preserves-pid-at-point-test): Mark as > unstable. > > This causes proced-refine-test and proced-refine-with-update test > failures on macOS, where %CPU is not implemented [1]. Probably we should > stick a check for darwin around them in emacs-30. > > Robert > > Footnotes: > [1] Probably because it appears to be non-trivial. > > -- > --000000000000c721f20627712351 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

I've attached a smal= l patch for this.

Thanks, Laurence
=
On Wed= , Nov 20, 2024 at 2:46=E2=80=AFPM Robert Pluim <rpluim@gmail.com> wrote:
>>>>> On Sun, 27 Oct 2024 11:50:= 32 -0400 (EDT), Michael Albinus via Mailing list for Emacs changes <emacs-diffs@gnu.org> said:

=C2=A0 =C2=A0 Michael> branch: emacs-30
=C2=A0 =C2=A0 Michael> commit 7a8ca202c5eeb810e5f86510c3ea46d3ec519222 =C2=A0 =C2=A0 Michael> Author: Laurence Warne <laurencewarne@gmail.com>
=C2=A0 =C2=A0 Michael> Commit: Michael Albinus <michael.albinus@gmx.de>

=C2=A0 =C2=A0 Michael>=C2=A0 =C2=A0 =C2=A0Fix flakey proced refine tests= (Bug#73441)

=C2=A0 =C2=A0 Michael>=C2=A0 =C2=A0 =C2=A0* test/lisp/proced-tests.el (p= roced-refine-test)
=C2=A0 =C2=A0 Michael>=C2=A0 =C2=A0 =C2=A0(proced-refine-with-update-tes= t): Use the much simpler CPU refinement
=C2=A0 =C2=A0 Michael>=C2=A0 =C2=A0 =C2=A0for testing 'proced-refine= '.=C2=A0 The previous tests made the incorrect
=C2=A0 =C2=A0 Michael>=C2=A0 =C2=A0 =C2=A0assumption that refining on th= e PID of process A only filtered the
=C2=A0 =C2=A0 Michael>=C2=A0 =C2=A0 =C2=A0buffer to contain process A an= d its children, whereas in actuality
=C2=A0 =C2=A0 Michael>=C2=A0 =C2=A0 =C2=A0the children of process A'= s children, their children, and so on will
=C2=A0 =C2=A0 Michael>=C2=A0 =C2=A0 =C2=A0also be shown.
=C2=A0 =C2=A0 Michael>=C2=A0 =C2=A0 =C2=A0(proced-update-preserves-pid-a= t-point-test): Mark as unstable.

This causes proced-refine-test and proced-refine-with-update test
failures on macOS, where %CPU is not implemented [1]. Probably we should stick a check for darwin around them in emacs-30.

Robert

Footnotes:
[1]=C2=A0 Probably because it appears to be non-trivial.

--
--000000000000c721f20627712351-- --000000000000c721f40627712353 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Skip-proced-refine-tests-on-Darwin.patch" Content-Disposition: attachment; filename="0001-Skip-proced-refine-tests-on-Darwin.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m3rp3v970 RnJvbSAxYjUzNjAyZTllZGMwMmFhZGI3YTU5Y2U3OTMxNTA3N2YxZDcxNDkwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW5jZSBXYXJuZSA8bGF1cmVuY2V3YXJuZUBnbWFpbC5j b20+CkRhdGU6IFRodSwgMjEgTm92IDIwMjQgMTc6MjY6MjUgKzAwMDAKU3ViamVjdDogW1BBVENI XSBTa2lwIHByb2NlZCByZWZpbmUgdGVzdHMgb24gRGFyd2luCgoqIHRlc3QvbGlzcC9wcm9jZWQt dGVzdHMuZWwgKHByb2NlZC1yZWZpbmUtdGVzdCkKKHByb2NlZC1yZWZpbmUtd2l0aC11cGRhdGUt dGVzdCk6IFNraXAgaWYgdGhlIHN5c3RlbSBpcyBEYXJ3aW4uCi0tLQogdGVzdC9saXNwL3Byb2Nl ZC10ZXN0cy5lbCB8IDMgKysrCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvdGVzdC9saXNwL3Byb2NlZC10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9wcm9jZWQtdGVz dHMuZWwKaW5kZXggM2RjN2UwNjVhZmEuLjMyZGM1Y2ZmNWYyIDEwMDY0NAotLS0gYS90ZXN0L2xp c3AvcHJvY2VkLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9wcm9jZWQtdGVzdHMuZWwKQEAgLTEw Miw2ICsxMDIsOCBAQCBwcm9jZWQtY29sb3ItdGVzdAogICAgICAocHJvY2VkLS1hc3NlcnQtZW1h Y3MtcGlkLWluLWJ1ZmZlcikpKSkKIAogKGVydC1kZWZ0ZXN0IHByb2NlZC1yZWZpbmUtdGVzdCAo KQorICA7OyAlQ1BVIGlzIG5vdCBpbXBsZW1lbnRlZCBvbiBtYWNPUworICAoc2tpcC13aGVuIChl cSBzeXN0ZW0tdHlwZSAnZGFyd2luKSkKICAgKHByb2NlZC0td2l0aGluLWJ1ZmZlcgogICAgJ3Zl cmJvc2UKICAgICd1c2VyCkBAIC0xMTUsNiArMTE3LDcgQEAgcHJvY2VkLXJlZmluZS10ZXN0CiAg ICAgICAgKGZvcndhcmQtbGluZSkpKSkpCiAKIChlcnQtZGVmdGVzdCBwcm9jZWQtcmVmaW5lLXdp dGgtdXBkYXRlLXRlc3QgKCkKKyAgKHNraXAtd2hlbiAoZXEgc3lzdGVtLXR5cGUgJ2Rhcndpbikp CiAgIChwcm9jZWQtLXdpdGhpbi1idWZmZXIKICAgICd2ZXJib3NlCiAgICAndXNlcgotLSAKMi4z OS41Cgo= --000000000000c721f40627712353--