unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Robert Pluim <rpluim@gmail.com>, emacs-devel@gnu.org
Subject: Re: master c19dd8e9d6c 2/2: Add more documentation for TTY child frames
Date: Thu, 19 Dec 2024 12:23:52 -0500	[thread overview]
Message-ID: <CADwFkmnsrwJm-L2An-zFD3q25cfyWfASm9cOuHzsBsGw=B4AvA@mail.gmail.com> (raw)
In-Reply-To: <20241219152929.A6F4FC09079@vcs3.savannah.gnu.org>

Robert Pluim <rpluim@gmail.com> writes:

> branch: master
> commit c19dd8e9d6c54080426623129a824e5bb2fcf7be
> Author: Robert Pluim <rpluim@gmail.com>
> Commit: Robert Pluim <rpluim@gmail.com>
>
>     Add more documentation for TTY child frames
>
>     * doc/lispref/frames.texi (Child Frames): Document that TTY
>     child frames are now supported.
>     * etc/NEWS: Document another limitation of TTY child frames.
> ---
>  doc/lispref/frames.texi | 4 ++--
>  etc/NEWS                | 7 +++++--
>  2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/doc/lispref/frames.texi b/doc/lispref/frames.texi
> index bf4d5c05f3a..cc7d3f79a7f 100644
> --- a/doc/lispref/frames.texi
> +++ b/doc/lispref/frames.texi
> @@ -3393,8 +3393,8 @@ of its sibling child frames.
>
>    By design, operations to make or modify child frames are implemented
>  with the help of frame parameters (@pxref{Frame Parameters}) without any
> -specialized functions or customizable variables.  Note that child frames
> -are meaningful on graphical terminals only.
> +specialized functions or customizable variables.  Child frames
> +are meaningful on graphical and text terminals.

Thanks, this is an improvement.  Two comments:
1. s/meaningful/supported/  ?
2. Should we explain the limitations of child frames on text terminals
   here as well?

>    To create a new child frame or to convert a normal frame into a child
>  frame, set that frame's @code{parent-frame} parameter (@pxref{Frame
> diff --git a/etc/NEWS b/etc/NEWS
> index 7e5a73818ff..9a7b320acdb 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -47,8 +47,11 @@ enabled, you can disable mouse tracking by putting '(xterm-mouse-mode
>  ** Child frames are now supported on TTY frames.
>  This supports use-cases like Posframe, Corfu, and child frames acting
>  like tooltips.  Other use-cases of child frames are not supported yet.
> -In particular, trying to create minibuffer-only child frames on a TTY
> -frame will signal an error.
> +In particular:
> +
> +- trying to create minibuffer-only child frames on a TTY frame will
> +  signal an error.
> +- a TTY child frame cannot be converted to a root frame or vice-versa.
>
>  To enable tooltips on TTY frames, call 'tty-tip-mode'.

I note that we use the terminology "TTY frame" in NEWS, and "text
terminal" in the manual above.  In other places, we talk about "text
frames".

Which terminology do we prefer, and does it help avoid any confusion if
we are consistent?



       reply	other threads:[~2024-12-19 17:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <173462216748.592529.1858458594667473357@vcs3.savannah.gnu.org>
     [not found] ` <20241219152929.A6F4FC09079@vcs3.savannah.gnu.org>
2024-12-19 17:23   ` Stefan Kangas [this message]
2024-12-19 17:40     ` master c19dd8e9d6c 2/2: Add more documentation for TTY child frames Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmnsrwJm-L2An-zFD3q25cfyWfASm9cOuHzsBsGw=B4AvA@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).