From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: use-package: Should we merge bind-chords.el / use-package-chords.el? Date: Fri, 2 Dec 2022 15:36:46 -0800 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8054"; mail-complaints-to="usenet@ciao.gmane.io" Cc: John Wiegley , Justin Talbott To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 03 00:37:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1FbD-0001vT-Lx for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Dec 2022 00:37:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1FaN-0003UV-Qf; Fri, 02 Dec 2022 18:36:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1FaM-0003UK-TB for emacs-devel@gnu.org; Fri, 02 Dec 2022 18:36:50 -0500 Original-Received: from mail-oo1-xc2c.google.com ([2607:f8b0:4864:20::c2c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1FaK-0007TR-Tu; Fri, 02 Dec 2022 18:36:50 -0500 Original-Received: by mail-oo1-xc2c.google.com with SMTP id j1-20020a4ad181000000b0049e6e8c13b4so919895oor.1; Fri, 02 Dec 2022 15:36:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=+8WWwXCT0RcR/1cboysB4Zt+vC270oa8VIrpclcg54c=; b=nu2vyVidNdLywwCNZnEHVScoiZuK9yJ1td/XuL4OfKEwaCVLiLGQK2FIriciilzdHt RfRC7pUlb6AT/5HQQfCIcAhTSkMCeM+Fy+Or5FmvJqXbtOojCkDz53aiuKjtvq7XPHc4 D8QQxE19WuKob+YKE6oHJqYACQYun4KPVDvL4aWt+K9vt7s1mqWY0ZXk/i86TgXYbDZr EZJElkjdXAkPMRZqqpdHceYHvg9mAPPa26SEiP6vngfmbfjNf+B59gkHkW6Mzmp79ao6 EZiAYXMBJh4I9+rJlEXBFj3st5gPsQFs5D2AOyGbFU0Sr+e3merbCMx794WYpXRVn79C QssA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+8WWwXCT0RcR/1cboysB4Zt+vC270oa8VIrpclcg54c=; b=jRrg+co9aSw3k27/o2RFfqUhf/uu+lA1xbYw4LVk5BKJDcvnH+lEBW9s6iv/GkYRTO ayrNhBiSgvVgTmRGSlek9xFoh3OC4gy3z7rtbF8bBBHflSnMbkAYxyNGzkoV+PgNXcud +MKPz7Fv9sh4HR5ejU4eAKuaKl1YqovBeRThYijEIGpfftzDhiV+sf6bvtzBRNWq4E27 8IWpcdc7fDH6+v/6R1PhenDKvL96GlQR+SMCfUfEoWREaFLc6lBb8ifvDRmqRDHAHU8L NLt+fflE0cMD6lgJL7dpKI23pspC9O0BabTd1bh81hkAqN0BEM6pxFbnXl30xjQSC86J kehg== X-Gm-Message-State: ANoB5pnKSPVFcEk7cVlN0C35Euju6tipPuGN7CHh9AxHZj6ohZB/vlfd ly83U48Giof10tip/Lce16rsK+xDSPjYM4RjmXsBYW1B X-Google-Smtp-Source: AA0mqf4FKFCIgfeAKY/cBF9v/ve/jSkSBlhQqpOVShnj0IbWNZjpXk4dXh5B7ij03AdQ7WzsoApl/lhF/lObRVfWHsw= X-Received: by 2002:a4a:54c1:0:b0:49f:d54c:9bcd with SMTP id t184-20020a4a54c1000000b0049fd54c9bcdmr26978434ooa.5.1670024207172; Fri, 02 Dec 2022 15:36:47 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 2 Dec 2022 15:36:46 -0800 X-Hashcash: 1:20:221202:justin@waymondo.com::j0UceF58byUi+qsx:4CV Received-SPF: pass client-ip=2607:f8b0:4864:20::c2c; envelope-from=stefankangas@gmail.com; helo=mail-oo1-xc2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300849 Archived-At: I'm not so sure about merging bind-chord.el, use-package-chords.el, and use-package-chords-tests.el into emacs.git, as part of the use-package merge. The most important reason is that they seem to depend on key-chord.el, which is not in Emacs, nor on (Non-)GNU ELPA.[1] But I'm also seeing that: 1. Two of the tests are failing. Unless I'm missing something, they haven't been running as part of the use-package GitHub CI.[2] 2. They have seen minimal maintenance over the years, and have a relatively low number of downloads on MELPA.[3] I'm sure they're very useful to some users, but the fact that they won't work with Emacs OOTB makes it seem like the increased maintenance burden might not be worth it. They also risk confusing users that try to use them, only to find that they don't work. They currently reside on the features/use-package branch, but that would be easy to reverse with a simple "git rm" on the branch. Instead, we could look into finding a new maintainer for them, in order to give them an independent existence as GNU ELPA packages. Footnotes: [1] https://github.com/emacsorphanage/key-chord [2] https://github.com/jwiegley/use-package/blob/master/Makefile#L103 [3] See their git history here: https://github.com/jwiegley/use-package/commits/master/bind-chord.el https://github.com/jwiegley/use-package/commits/master/use-package-chords.el https://github.com/jwiegley/use-package/commits/master/use-package-chords-tests.el I see 13,567 downloads on MELPA, compared to 1,995,169 for use-package: https://melpa.org/#/?q=use-package