unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: emacs-devel@gnu.org
Cc: John Wiegley <johnw@gnu.org>, Justin Talbott <justin@waymondo.com>
Subject: use-package: Should we merge bind-chords.el / use-package-chords.el?
Date: Fri, 2 Dec 2022 15:36:46 -0800	[thread overview]
Message-ID: <CADwFkmnrLQf3Ec0bTGFaDyKsEEKCZYFv3qNjHn1pAf0e_taOsQ@mail.gmail.com> (raw)

I'm not so sure about merging bind-chord.el, use-package-chords.el, and
use-package-chords-tests.el into emacs.git, as part of the use-package
merge.

The most important reason is that they seem to depend on key-chord.el,
which is not in Emacs, nor on (Non-)GNU ELPA.[1]  But I'm also seeing that:

1. Two of the tests are failing.  Unless I'm missing something, they
   haven't been running as part of the use-package GitHub CI.[2]

2. They have seen minimal maintenance over the years, and have a
   relatively low number of downloads on MELPA.[3]

I'm sure they're very useful to some users, but the fact that they won't
work with Emacs OOTB makes it seem like the increased maintenance burden
might not be worth it.  They also risk confusing users that try to use
them, only to find that they don't work.

They currently reside on the features/use-package branch, but that would
be easy to reverse with a simple "git rm" on the branch.  Instead, we
could look into finding a new maintainer for them, in order to give them
an independent existence as GNU ELPA packages.

Footnotes:
[1]  https://github.com/emacsorphanage/key-chord

[2]  https://github.com/jwiegley/use-package/blob/master/Makefile#L103

[3]  See their git history here:
     https://github.com/jwiegley/use-package/commits/master/bind-chord.el
     https://github.com/jwiegley/use-package/commits/master/use-package-chords.el
     https://github.com/jwiegley/use-package/commits/master/use-package-chords-tests.el

     I see 13,567 downloads on MELPA, compared to 1,995,169 for
     use-package: https://melpa.org/#/?q=use-package



             reply	other threads:[~2022-12-02 23:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 23:36 Stefan Kangas [this message]
2022-12-08  0:19 ` use-package: Should we merge bind-chords.el / use-package-chords.el? Stefan Kangas
2022-12-08  0:58   ` John Wiegley
2022-12-08  6:08   ` use-package: Problem with built-in packages? David Masterson
2022-12-08 16:37     ` Stefan Kangas
2022-12-08 18:25       ` David Masterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmnrLQf3Ec0bTGFaDyKsEEKCZYFv3qNjHn1pAf0e_taOsQ@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=johnw@gnu.org \
    --cc=justin@waymondo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).