From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Sat, 13 Mar 2021 08:27:05 -0600 Message-ID: References: <83a6rhxwah.fsf@gnu.org> <837dmlxspt.fsf@gnu.org> <834khpxr0s.fsf@gnu.org> <8335x8ybw9.fsf@gnu.org> <87czwageno.fsf@mail.linkov.net> <878s6xwngp.fsf@mail.linkov.net> <874khjq6p8.fsf@mail.linkov.net> <875z1ylrdw.fsf@mail.linkov.net> <83eegmok4v.fsf@gnu.org> <834khins2i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11001"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, juri@linkov.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 13 15:28:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lL5FM-0002n2-DU for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Mar 2021 15:28:04 +0100 Original-Received: from localhost ([::1]:36330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lL5FL-0007Zo-FH for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Mar 2021 09:28:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lL5ET-00079D-Qg for emacs-devel@gnu.org; Sat, 13 Mar 2021 09:27:09 -0500 Original-Received: from mail-pf1-f170.google.com ([209.85.210.170]:36299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lL5ES-0008Q5-9q; Sat, 13 Mar 2021 09:27:09 -0500 Original-Received: by mail-pf1-f170.google.com with SMTP id x21so2483458pfa.3; Sat, 13 Mar 2021 06:27:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=6fTDP6PxJ06Lz4k5J/idy6GCvxaa/UJwjnQ5DxMVJCw=; b=DZpHlZqReEVBJo7wux8YYNsvzUNMeY7ZOVlnu2QiQsCQmx8XNZSbIKtpZNIV6yGvKT XYJyIIkgpeQMOCCit4IES7XOsrdGGA/ePuyTDfyZaUVHMOe3I9HVpAz7D+ko8gIV/Etc E1hbC3TzWqQ0C5/qzsw7cfBPzGvNMmghsiemqUzy0AMrHBI0BmcHXg1qNgewda8fnPuE CTEWigbbAhDM7ffSx3qBM6ZAFQDwxrfkH/JLICLRXU+C1f7oXR+Gsn7uN1/3xttsZh8x lXnA32TSPytErl9pn7pzXg5VRWCKVNEULM+Bb3cAvH8F8b42UM9yjDi1tMd6kWSXQj2u KD1g== X-Gm-Message-State: AOAM530zkR2ZEI7MHuu6GF/o9DOeNRmRwohWHTBkestkf7g4wK31FgIm ItRp7lm5fcIr4vvRtsFfjHag8GM+tSkU9CvsEP6YpAG25ww= X-Google-Smtp-Source: ABdhPJz6GAOkzwr7/LgNKwAswxv0CKxMv0DSHdV5aeror/mQMAZA+V/fv7YL08i30BtuKmwpto8vdA3Lj3Z7a9FzINM= X-Received: by 2002:a63:ed02:: with SMTP id d2mr16439715pgi.67.1615645626348; Sat, 13 Mar 2021 06:27:06 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 13 Mar 2021 08:27:05 -0600 In-Reply-To: <834khins2i.fsf@gnu.org> Received-SPF: pass client-ip=209.85.210.170; envelope-from=stefankangas@gmail.com; helo=mail-pf1-f170.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266431 Archived-At: Eli Zaretskii writes: >> Is it annoying enough to avoid :box completely? > > IMO, it depends on the frequency of the occurrence. It was enough for > me to customize eldoc face to use :underline instead of :bold, because > the latter would cause a similar effect. But that's my level of > annoyance; others might feel differently. So perhaps advertise the > way to avoid that by customizing the face, and then let's see how many > complaints we get from users who track the master branch. I was able to avoid any vertical resizing using the advice from Stefan M. So I pushed the following change to master: modified lisp/faces.el @@ -2816,8 +2816,12 @@ help-argument-name :group 'help) (defface help-key-binding - '((((class color) (min-colors 88) (background light)) :background "grey90") - (((class color) (min-colors 88) (background dark)) :background "grey25") + '((((class color) (min-colors 88) (background light)) + :background "grey92" :foreground "DarkBlue" + :box (:line-width (1 . -1) :color "grey80")) + (((class color) (min-colors 88) (background dark)) + :background "grey23" :foreground "LightBlue" + :box (:line-width (1 . -1) :color "grey35")) (((class color grayscale) (background light)) :background "grey90") (((class color grayscale) (background dark)) :background "grey25")