* Re: master b306bc5e6d 2/3: Improve prompt of 'image-dired' command
@ 2022-09-24 8:18 Eli Zaretskii
2022-09-24 9:22 ` Stefan Kangas
0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2022-09-24 8:18 UTC (permalink / raw)
To: Stefan Kangas; +Cc: emacs-devel
> --- a/lisp/image/image-dired.el
> +++ b/lisp/image/image-dired.el
> @@ -553,7 +553,7 @@ If the number of image files in DIR exceeds
> `image-dired-show-all-from-dir-max-files', ask for confirmation
> before creating the thumbnail buffer. If that variable is nil,
> never ask for confirmation."
> - (interactive "DImage-Dired: ")
> + (interactive "DImage-Dired (directory): ")
IMO, the new prompt is not much better than the old one. They both
assume that just by prepending "Image-" to something resembling the
prompt of "C-x d" is enough to explain what the command wants. I see
a lot of space for confusion here, especially for non-native English
speakers.
The doc string of the command says:
Make a thumbnail buffer for all images in DIR and display it.
Any file matching `image-dired--file-name-regexp' is considered an
image file.
So I don't think the analogy with Dired holds, and therefore something
like
Show thumbnails for directory:
would be a better prompt.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master b306bc5e6d 2/3: Improve prompt of 'image-dired' command
2022-09-24 8:18 master b306bc5e6d 2/3: Improve prompt of 'image-dired' command Eli Zaretskii
@ 2022-09-24 9:22 ` Stefan Kangas
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Kangas @ 2022-09-24 9:22 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
> So I don't think the analogy with Dired holds, and therefore something
> like
>
> Show thumbnails for directory:
>
> would be a better prompt.
Agreed, now changed accordingly. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-24 9:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-24 8:18 master b306bc5e6d 2/3: Improve prompt of 'image-dired' command Eli Zaretskii
2022-09-24 9:22 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).