From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Mon, 5 Apr 2021 18:08:02 -0700 Message-ID: References: <87h7kkwcy1.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="556"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Gregory Heytings , Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 06 03:10:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTaEg-000Aat-Sk for ged-emacs-devel@m.gmane-mx.org; Tue, 06 Apr 2021 03:10:30 +0200 Original-Received: from localhost ([::1]:46272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTaEf-0005Mc-OF for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Apr 2021 21:10:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTaD1-0004tO-0o for emacs-devel@gnu.org; Mon, 05 Apr 2021 21:08:47 -0400 Original-Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:52023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTaCK-0007BY-4g for emacs-devel@gnu.org; Mon, 05 Apr 2021 21:08:46 -0400 Original-Received: by mail-pj1-x1031.google.com with SMTP id s21so6999574pjq.1 for ; Mon, 05 Apr 2021 18:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=oAeN7QlGH8Lo8kpT5AJy9lO9qkbTao4y9dAkkvUa6zg=; b=NDgVJrGWZ9q1GVBFEho2/LzvBgvQgWFYLkvM4DjadqpGO4evg1V7yQICHK0UDgxeAg sNsgQGslRI2JGeWsZvuSmYkzZWjikkMoxzWHwdOepk8ZsnXnUMuR3nSrtECgKXaZlPN6 IuQzcyy0fQXp4qbE2IN8ovx92r21IJrzCtwvioDSnw/xKXlCrADV1OMqpRzxbceJw9k5 KVd8hd2oDro5vUi3xF42wTrGC3B31sBwtXHm7SisUMRkIy69n0AxAiOjjKhK3n7Ta//X RsxM+i869zbVSoGfuKrKVbsr84HuEm6/yr7zl0qyawestzNC/x2ZmKZ2o5kqH2RHykbS Rl+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=oAeN7QlGH8Lo8kpT5AJy9lO9qkbTao4y9dAkkvUa6zg=; b=BPzi4teEHIT6verKpuPHhcpLGqITe8W1EMqyqTW/gpURny/yALk9Jdxb0CCxYDtHBs E5Y7y9mR6oe7lt92INQ2ulFSItqemVb51/j+RvvJnEZeCVOMr986arwFm36sx+UcWfi8 mMpFnUZCQuItk4/16ZHeLiur/IanUiFFTsT7sBf2ePiYt5S5lHnEmfVnTi34pDt7qe4t TwR9fahWYRoQ+wKbxmHg9jWgU9OjhEsL1biqEghJVKnk06Ie+Mz35jhgTrgb4DI6ZQLQ gxGksU8j3tBbw6coZ9BtXHAn7zAOD/ofvQEBMh8CoZdPcHhHUbnyS/IjvsQ8rF2xrTxS sTag== X-Gm-Message-State: AOAM53111Ni2z7jMaUhAJkX4Vmu26j/Y6xPznnhq8kIHjvUDeWv9AhR5 sKWo/W6AgbgwI9EuIjv+ozMaR7oofXH0ejeVxdc= X-Google-Smtp-Source: ABdhPJxTbCnkWTudTmMCqvz6JqFhdMAMbSksi5VVtfpqwOlrVMwPAW6fKFpz6auoPnlTNbwbJfPm8bRfXePx5w13Iz8= X-Received: by 2002:a17:90a:c249:: with SMTP id d9mr1877416pjx.104.1617671282824; Mon, 05 Apr 2021 18:08:02 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 5 Apr 2021 18:08:02 -0700 In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=stefankangas@gmail.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267452 Archived-At: Gregory Heytings writes: >> Why is this a patch that uses advice and hook instead of a user option >> that changes the behaviour of icomplete directly? > > Because it's the simplest / cleanest way to do it. It's a kind of derived > minor mode. Advice is not entirely unproblematic though, so the recommendation is usually to avoid them in libraries for use by others. Even more so in Emacs itself, I think. See the ELisp Manual sections `(elisp) Advising Named Functions' and `(elisp) Coding Conventions'.