From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: woman.el broken? Date: Tue, 2 Mar 2021 20:23:53 -0600 Message-ID: References: <20210301193951.7EB04C217D7@raman-glaptop.localdomain> <878s763bah.fsf@gnus.org> <83r1ky7icm.fsf@gnu.org> <87zgzm1vvf.fsf@gnus.org> <83mtvm7hkt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19715"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 03 03:24:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHHBp-000514-8Q for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 03:24:41 +0100 Original-Received: from localhost ([::1]:52644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHHBo-0002U1-7I for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Mar 2021 21:24:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHHB7-00023b-JP for emacs-devel@gnu.org; Tue, 02 Mar 2021 21:23:57 -0500 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:36722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHHB5-0003O9-MH; Tue, 02 Mar 2021 21:23:57 -0500 Original-Received: by mail-pj1-f49.google.com with SMTP id s23so3383711pji.1; Tue, 02 Mar 2021 18:23:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=JnLZR7rTVGiPhumCotqBMdYSm3hgZla4cznaFpkALJA=; b=nnyzt2rocKY6r9/OlItMhbWqWlLPhY81fo+AzzWsKv7ZajWv4adHoJ/krNICsd8SD2 z19R9LjS18nTsuVDqqyxpQSN7fPx0ji59+0PxjJ4584XgbnbIQCIF0v6efLbsumBvuvz hQ9ToQbgKz0Bn+mWACR0U78HEhFm5kD8jxmaVklAm3AwpDkRnGrqiqKnOJ85awxYnAKi ZHmieoPd2ls/+W6f+agcrSs0avVgf7umfbY0MUVqYAUcLUNPkuUsvylHLK5ZOOkwJgAY DhO4KMlnuSPBF7x5BemCgdwpMlhhXh/U3gCnWdaCLvIbPD7aDzTGqkmtx0njtSTpXaS9 y0mg== X-Gm-Message-State: AOAM531xNiz454JNo4NRmR6Xrq+mqtXdgwKsbVC5GnA+qJNOhzv0WRXN seS4nuLV8kO3Dx7aWAgMIqdhQC7yj5RIn464AYIcuy+n X-Google-Smtp-Source: ABdhPJyh1cYOzxMOfNpNwOGugsEh7zwHYqNHewsRR9sfz2vanUT3U0SPC/8H8fvJtca5CT4dn6Gn2aXPLaEFoHmzOK8= X-Received: by 2002:a17:90a:f986:: with SMTP id cq6mr7404269pjb.175.1614738233845; Tue, 02 Mar 2021 18:23:53 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Mar 2021 20:23:53 -0600 In-Reply-To: <83mtvm7hkt.fsf@gnu.org> Received-SPF: pass client-ip=209.85.216.49; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f49.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265855 Archived-At: Eli Zaretskii writes: >> > So this means that converting any Lisp file to use easymenu will >> > potentially break all the Lisp programs out there that reference its >> > menus, due to letter-case issues? That problem alone is IMO enough to >> > stop this conversion, until we fix look up-key to not break other >> > packages, or find some other way of preventing such problems. >> >> Yes, fixing the lookup to be more forgiving here would be nice. > > Stefan, would you please make that happen? Without that, the switch > to easymenu is an incompatible change, ironic as it may be. Would something along these lines be okay or do we strictly need all of this to be in C for some reason? (defun lookup-key (keymap key accept-default) (or (lookup-key-internal keymap key accept-default) (and (vectorp key) (let ((lc-key `[,@(mapcar (lambda (s) (intern (downcase (symbol-name s)))) key)])) (when (not (equal lc-key key)) (lookup-key-internal keymap lc-key accept-default)))))) (`lookup-key-internal' would be in C with the same definition as `lookup-key' has today.)