From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning. Date: Wed, 7 Apr 2021 05:06:04 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26082"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Mackenzie , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 07 12:07:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lU55s-0005tU-3P for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 12:07:28 +0200 Original-Received: from localhost ([::1]:40796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU55R-0005q6-OE for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Apr 2021 06:07:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU54a-0005OF-Pw for emacs-devel@gnu.org; Wed, 07 Apr 2021 06:06:08 -0400 Original-Received: from mail-pj1-f41.google.com ([209.85.216.41]:53040) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lU54Y-0002Et-CH for emacs-devel@gnu.org; Wed, 07 Apr 2021 06:06:08 -0400 Original-Received: by mail-pj1-f41.google.com with SMTP id ha17so9507884pjb.2 for ; Wed, 07 Apr 2021 03:06:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=D8rXt41YK51AA8zbMlkDGNhMEQXNz0hHNRHNU7aObiE=; b=VGGBLVDo6aVNe9KRUco//ac4yXz9U5P2f92ywJf9HTz0/cq8mqnoODG6PFWmxSDsy6 iuIuFK/Jc28mabXdPe2QA95vdEqiNf1DA7/9+x1W3uy6pKWqI4aUlOW/oQbRBZJybATt +UeuMEm6BP+SpV3ChVYV6IZeLnCj97n/g4RY9x/bC4hIrrtj1kar868GSlNcIZlqLCBP yf/zpymxmnjtSwSgjpxfA3l+tLJtdpY1fBkW+xlLLJjD1m5FQI0w1af1hXgct5qjtiFm aHOf5DbusdP5umWvBP/Ov2QrFe8NoylpwhX2dL0wSUvAv6UeO1WCDlmHdDsvnmRxQRIf 3KbA== X-Gm-Message-State: AOAM531c1VRKLKJbAxi3QuiA+88VP8hqsacSNlBIQag7uq3cUFpA/VEW wYccvW3IguJbmBb2m5ijx4qPKIKlQw3gxfwNhmhQ+4PC X-Google-Smtp-Source: ABdhPJweR1sjzx9MWb4/KJkk5LoYMi0YLw7BUBKC6JUsK08ihGToVSzHglWq+Xjd7J1r4dj9d9NIY9XouddVsqRqgOc= X-Received: by 2002:a17:903:2303:b029:e6:faf5:875e with SMTP id d3-20020a1709032303b02900e6faf5875emr2352646plh.41.1617789964544; Wed, 07 Apr 2021 03:06:04 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 7 Apr 2021 05:06:04 -0500 In-Reply-To: Received-SPF: pass client-ip=209.85.216.41; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f41.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267501 Archived-At: Alan Mackenzie writes: > In Emacs 28, easy-menu-add is now compiled to `ignore'. This isn't > friendly, particularly as in Emacs 27.2 and earlier, it just worked, > without any warnings of impending obsoletion. What does "working" mean here? In Emacs 27.1, I have here: easy-menu-add is an alias for =E2=80=98ignore=E2=80=99 in =E2=80=98easy= menu.el=E2=80=99. > Why have we not followed the normal procedure here, by marking the > function as obsolete, yet leaving it working, for one or two major > versions, and only then removing it? It is my understanding that this has followed the normal procedure for obsoletion. > This sudden removal of easy-menu-add will cause unnecessary annoyance > amongst maintainers whose sources still use it. Even in the Emacs > sources there are 25 uses of the function. This function is only relevant in XEmacs, so if this is important to you I recommend changing any such call to say: (when (featurep 'xemacs) (easy-menu-add foo-menu)) The Emacs sources should already be updated accordingly. > The warning message Emacs 28.1 gives out is particularly unfriendly and > unhelpful. It looks like this: > > cc-mode.el:2591:4: Warning: `easy-menu-add' is an obsolete function > (as of 28.1); use `ignore' instead. Yes, we could improve that message. Perhaps it could say: "it is not needed, so just remove it"