From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Warning compiling image-dired.el Date: Thu, 4 Nov 2021 11:52:33 -0700 Message-ID: References: <83mtmkfj20.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26821"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 04 19:53:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mihrt-0006sg-JM for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Nov 2021 19:53:45 +0100 Original-Received: from localhost ([::1]:56894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mihrm-0008F0-5t for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Nov 2021 14:53:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mihqn-0007NY-AR for emacs-devel@gnu.org; Thu, 04 Nov 2021 14:52:37 -0400 Original-Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:44624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mihql-0004UZ-Tg; Thu, 04 Nov 2021 14:52:36 -0400 Original-Received: by mail-pg1-x52b.google.com with SMTP id p8so4893887pgh.11; Thu, 04 Nov 2021 11:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=kDB1msWupztOFzRvIEpXiPavV0shQvxF7+RMBVu92A4=; b=Cr3GTL/IKah1bxo+WSMRDjeRhQ9mIY0CDP2uuePC0AHPDan6PuICemOmHaOlhZsGD+ OkjZWr109s8tBlL3xwXdYBTUPOZnuTEPRP8W2FT9jB056JKgcWF/bOTIVuShFDaVbIK/ qK2qA40J/Qh1YevGY4oRA3ilwCItD5keDQbHPorOTBebLbACqPWq0KomHLGXzh0QB40A wdLH19cXi0CUBTI3fjkbqxe4aUw8eoISwfb3FfDURqIPcN/NMYwPo8fNMKJNtY9USXsm /H5RPMwArzNAsqxCMyfNj+YAKtmA7rXIS+W5L46WziNMBavNDQTxtr9NH/GxdguhkxjF VtkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=kDB1msWupztOFzRvIEpXiPavV0shQvxF7+RMBVu92A4=; b=MbRfLeiIkmWg5EN2EhhrpEFYgDcM/CswXPvl0e7HdJhq6mUsg8IiJAmUCpcRGhi7lQ TUzS/s2gfmJZyGJEWuZuubu4ND1Yf+SP3EAoGli3ZxSSslH859pD5gqtedm4tzRwHOUR 1njwIObVUe9/SczWn9a7HgKaPup/m7QRoE7wBtiH0eCG9kXA5Q1AtkgqaAnIpwJzuLw8 nVTxfmXEoeIlbMK1jFKa4wyUpxeB/poZ6OM4YvXNzey/druh/YL2Gpuo+EnejWlDETEo uJlw4tFiSmD0OMkReth1MmmXOovfYNbC69Lk2A4nESAJwf4Fu7cUzLz3t7wnPYP+CM+F Nlgw== X-Gm-Message-State: AOAM530+jsbbBf17fftkdSPzPAFHD8y9OOaqruU7Et81INl64ua4vMW+ VE/OlOOcTXbyIio44UeztvYi6zyeJOmc+nIaBfRNvRly X-Google-Smtp-Source: ABdhPJy68PARMmpc/kJXuadEOHfY/ZKKmSDyicsuxeX/KcSWo5AbL+noTEB4QOuFMMNdhnIeM2KeQ3kM6ERMM2sZzeo= X-Received: by 2002:a63:370c:: with SMTP id e12mr39987281pga.359.1636051954049; Thu, 04 Nov 2021 11:52:34 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 4 Nov 2021 11:52:33 -0700 In-Reply-To: <83mtmkfj20.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=stefankangas@gmail.com; helo=mail-pg1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278699 Archived-At: Eli Zaretskii writes: > ELC image-dired.elc > > In end of data: > image-dired.el:2913:14: Warning: the function `image-mode-fit' is not known to be defined. Thanks, now fixed on master. > The call to image-mode-fit was introduced in commit 73a6c8f9. I don't > see that function anywhere, and there are no comments near its call to > explain what is this call supposed to achieve. (Why should we try > "fitting" an image in a command that's supposed to display the image > in its full size?) It should have been `image-transform-original'. (I had actually added it to the "obsolete" declaration of that function, but had missed to update the call in the function body.)