From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Deleting old `:version` from defcustoms (was: master b76cdd0: Delete libraries obsolete since 23.1 and 23.2) Date: Fri, 15 May 2020 13:58:27 -0700 Message-ID: References: <20200515175844.18941.61355@vcs0.savannah.gnu.org> <20200515175845.997EC20999@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="8111"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 15 22:59:13 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZhQF-000206-U9 for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 22:59:11 +0200 Original-Received: from localhost ([::1]:46770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZhQE-0002WM-Tr for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 16:59:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZhPZ-00020n-Nc for emacs-devel@gnu.org; Fri, 15 May 2020 16:58:29 -0400 Original-Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]:35821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jZhPY-0008SE-Uf for emacs-devel@gnu.org; Fri, 15 May 2020 16:58:29 -0400 Original-Received: by mail-yb1-xb34.google.com with SMTP id o134so1817448ybg.2 for ; Fri, 15 May 2020 13:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=lFEx9EqOL7r6K60W1PDTWD+ZKLT5GDLVsw31iogAXbA=; b=Qt+UEDNQSSP5GPiUCu4DlUYAFkDGUf16TYfsqAnuxNsKeppGlruBAXTJzkkRo1pd4r G0DIKwL1hWrq8tBquM1pAp6GXRJ/uIbxPgw3FXB2QIWwoX61DtmmGnTI5Z8fOY5MHKFQ cWlVSNCDuPWTJny1UltiTHjzGqJnQeHy+gG2qLlKvE6wC/rFK4ttRHQcP2+Gwpt8GJpk lyT4DPES4PoUYIKenFe0/xTaYUlSaRM4L5xkOLVrqOGxmHAuKI3uTaEVDQAwm1u4lPZ2 z89ntOshsEiaaFjfEgoPIP7f0CFw2ZL/fzzenQZrleKy9GxPqSFsMzm1a52gqqKMK5Jj ODHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=lFEx9EqOL7r6K60W1PDTWD+ZKLT5GDLVsw31iogAXbA=; b=MINIzQQzTpqnnnfIoNlri0aD9JL2XjQ5BCN1GSV/isv93m3viKzSFqIRxvfn9cHXrp JANTfiko1ymExsZld/Jj30iQDz9xJv6Dt45buioo9vpe+4RCZI6l5r161U8aBXacqfHf mu6y6EWwAteOV5otGQ3Vbw/SYAcJcZRsO5NPGYJQ/1ZEBnMiAKR9bAlAyV36d3TuWV48 tDWr09hYo1fUH711smyICqUN9KdEEHa9QbZGJri3fwBf3pKs49164V1yO9GrE5lEdhrZ MMJiBkw90nknfaR2TlI+O+0FE7fLMySWYMPh8giskHpy7dCF7qqbU/w7hoAzsJcCKac1 RJwA== X-Gm-Message-State: AOAM533zk4+oCjCeCupKR4f1b/Tv6OiShu0VCRCggSan3FKggvxx5EbT jQmWkxc6EUAKD8AqzIqAsePJpQd+y41dHMhEcgA= X-Google-Smtp-Source: ABdhPJzsrC4mhy0l6Ji3ChJ2A9TXd5pAOrkRuVToLfYt/mARzq+lpikg+JOe91lVwdUYcFjCUiDQ1DT1Ngok+U9j3Xs= X-Received: by 2002:a25:bb08:: with SMTP id z8mr8658804ybg.129.1589576308034; Fri, 15 May 2020 13:58:28 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 15 May 2020 13:58:27 -0700 In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b34; envelope-from=stefankangas@gmail.com; helo=mail-yb1-xb34.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250427 Archived-At: Stefan Monnier writes: > I did a quick `grep` to see the functions/vars that were obsoleted in > the same time frame, and I saw instead a deluge of > > :version "23.1" > > If we consider those thingies old enough to remove their obsolete > functions, shouldn't we also remove the corresponding `:version` > thingies from `defcustom`s? There are also these two libraries: ./lisp/obsolete/fast-lock.el9:;; Obsolete-since: 22.1 ./lisp/obsolete/lazy-lock.el9:;; Obsolete-since: 22.1 For some reason they weren't removed in 27.1, when most other libraries obsolete since 22.x were deleted. This made me wonder if there was any particular reason for their non-removal. Does anyone know? And could we delete them now? Best regards, Stefan Kangas