From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Mon, 3 May 2021 07:48:00 -0500 Message-ID: References: <87a6pcqy7s.fsf@red-bean.com> <87mttcch39.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16320"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Development To: Lars Ingebrigtsen , Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 03 14:50:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldY1m-00047Y-QC for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 14:50:22 +0200 Original-Received: from localhost ([::1]:54316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldY1l-0007F7-Q3 for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 08:50:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldXzZ-0004ZX-El for emacs-devel@gnu.org; Mon, 03 May 2021 08:48:05 -0400 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:33515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldXzW-0001z7-44 for emacs-devel@gnu.org; Mon, 03 May 2021 08:48:05 -0400 Original-Received: by mail-pl1-x62a.google.com with SMTP id b21so2741274plz.0 for ; Mon, 03 May 2021 05:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=ryuXmAlOPAjYQEf1Lukck0DCkADL96gQMMnlUWxKUlw=; b=azRl6SrUIfNubRRMln7/5kPesSk3+9U9vD3OPdZJApYdo1WNZlxmOO5diRkK0Oecin FG5B+dIVRO1XjtxbczaMlrdIhspZjefZsblfxJd929frMIn7HgRTrqMqapqqR+RpAykn 38HiavrNK/aflleEIq8iTCwhDFwM1RyjOjKW4JKsuR/pkuobrVVM0Yh3nL1T5krIpfeO r3SydCoBR3/Rm8qfaj+cL1cZLKR137CP8cE8TOhkn0fzf6dmVpwAtauAxFqhvHe3cYLw 3kQfqi7/vIkOL5rrNaZyUx/HFXiCAoZgRPUu6Bct/BmNso740gi5hxxom4ob5/PqoEaE Gt8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=ryuXmAlOPAjYQEf1Lukck0DCkADL96gQMMnlUWxKUlw=; b=foxvXKlbRQYskDEo28Laaho3rllXseIvKBYTmYvs3KSn+ajwfecSJXaLI7d1Ry88+b tm9l51vt2TN1gzmu5Mmo2l5OB2gmsKxNiX41cieHrXxuWygVYwAp/GI1qke2gHo4IKbE wIpWKlAXRBjjv7QNJs8cdSHp1y7V7Eu6Dn2DUBFXvEFKLgYxNHe+uXwuuZTKHHmyjXA7 0UsuKly5fUROCvmi8ZUsGVJYYNuPZ2EZoXnx9UGts1XvhbRt0b2GQYG9Rf9SC4zour2S EEPmZWO6sk8wBRFLXTvThW843pEk0J+GoJoQEYbrGtdzTtF6TlDgi8sIxaGRAixFyHWn zDyg== X-Gm-Message-State: AOAM532H7L5BYTp7s8rZGhV4Bit3ABUlQzyqd/YANHRfOwFdC/VjNQQ6 BqITN3343tCwE87OiaITcmeswIehUiTvwy4iZIrjvpet X-Google-Smtp-Source: ABdhPJzekMGDju16DsNXll1jQNNgMqFilHzavnGLS92vlfVqWLDXnCN4T+BlUMBHN2EtvZEm8W0ErAMVDMSWsZAGk40= X-Received: by 2002:a17:90b:350:: with SMTP id fh16mr21454885pjb.104.1620046080966; Mon, 03 May 2021 05:48:00 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 May 2021 07:48:00 -0500 In-Reply-To: <87mttcch39.fsf@gnus.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=stefankangas@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268808 Archived-At: Lars Ingebrigtsen writes: > Karl Fogel writes: > >> I wanted to run this by folks here to get opinions/review before >> committing. It stems from a suggestion by Oliver Taylor in a thread >> on the Emacs Humanites mailing list (the thread is linked to from the >> commit message). > > [...] > >> (bookmark-menu-confirm-deletion): New defcustom. > > In general, I think it's better to offer undo instead of prompting. > That's not always possible, but I think in the bookmark case, that > shouldn't be too difficult -- just register an undo action that inserts > the items that were removed, I think? I think a confirmation here is in order, as this is a dangerous operation. For the same reason, we should ask the user to disable the prompt rather than the other way around, i.e. the default should be t. Undoing is also fine, but it is less discoverable, as you would need to know that an action can be undone to use it. OTOH, we could call it out in the major mode help. Perhaps if we had undo, it would make more sense to have the confirmation nil by default. (But I do wonder if many users would then bother setting that option to t.)