From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Does seq.el need to work with older Emacs versions? Date: Sat, 3 Sep 2022 08:01:19 -0700 Message-ID: References: <72CD4C05-ABEC-4E8C-8812-1EDBAB78FEB9@acm.org> <837d2koj7h.fsf@gnu.org> <87h71okaue.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11377"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , emacs-devel@gnu.org To: Philip Kaludercic , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 03 17:03:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUUgR-0002i1-FP for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Sep 2022 17:03:43 +0200 Original-Received: from localhost ([::1]:43396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUUgP-0001U3-VG for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Sep 2022 11:03:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUUeB-0007pi-HV for emacs-devel@gnu.org; Sat, 03 Sep 2022 11:01:23 -0400 Original-Received: from mail-oa1-x2e.google.com ([2001:4860:4864:20::2e]:35539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oUUe9-0003yx-Qd; Sat, 03 Sep 2022 11:01:23 -0400 Original-Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-1225219ee46so11846430fac.2; Sat, 03 Sep 2022 08:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=Yp3yFCBwt/XM04feMOSZJ0bkDPzvGSnhu0WtsneEauc=; b=meQprXK9jc7xMWJlMQ/ejGi1ZBQQYmmzB2rqL6MiH/nLgPzpLF/MnW9SQpQ/TiUecA 0sPRs5luDav8wJx1DRO1Y2ZdiZ5WYmKEgi0RJip7f1PRLt4s4ExTAKMGYM2SCVwPIoNU bP5l87BT+l2JVnbb0hxzeE5Fq/9XL4kjUDNbaiDCyCLixau4KoqF6X9J5/hJDH0cIx8A 8ZANmde4KAWa9vkemrXkxa0oreHnTK9UBQsTrcRbChAHWVtr8mTF68fTqXo/ZJ2RKOww zE+b1zRQz3etOPicvnvuHa2pGccOtPdjWfBAmElc9EegQDDUjPn/oX4Lfr/oQ0yJ8de0 0UNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=Yp3yFCBwt/XM04feMOSZJ0bkDPzvGSnhu0WtsneEauc=; b=tsTvXzE7sQqaes1c7fZxLKKN1mirIIKmUHgwPfucGzVCh4GXgfEqQSEtxcsQpbNers HLH9rVbaUMosJqxnj8akIrR0fRhKK2gv6de458KX18lMlJUV/H7XeEjalOWxkmbh0o23 QU/DlWGzhlpJi4gAV0WWJ6080lTyvRqmbhUdgoT2PZOm9ZpZnsz5q3yJrtIIw1z1/9et yb/JCe0MBNWTCzE4dOlBnYYDuYb2w8pL9L9gYUOhifEv/JAxitXIbboQBODkqrC1ImWj m4cj98ZOQ4FNeA/7uQVyR9pACQKpoeMWdHUmv1SgYDGZDUXwCLhy5Iua/omyNhLEzyzd 7MsA== X-Gm-Message-State: ACgBeo2TvO1F1WmdUjui/lZkpOu/4e2pvY5HHNYEtUOVcRNiHq5b365E hOyb5Pic72Zx/BhCHLT5YmSZ3V4QJjGk9s9dB6NGwmL9 X-Google-Smtp-Source: AA6agR5P6SV1HeBML2UpI7t+U/fABGSB3XT0hjr9e9F9pKQz/pR/ix+7SLKsMdPvucEyrerpJvL8kbG23HMNft0qFXA= X-Received: by 2002:a05:6808:f14:b0:343:5f65:a540 with SMTP id m20-20020a0568080f1400b003435f65a540mr3867446oiw.92.1662217280106; Sat, 03 Sep 2022 08:01:20 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 3 Sep 2022 08:01:19 -0700 In-Reply-To: <87h71okaue.fsf@posteo.net> X-Hashcash: 1:20:220903:eliz@gnu.org::QnvvJuVyfUbamlOi:4Krr Received-SPF: pass client-ip=2001:4860:4864:20::2e; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294656 Archived-At: Philip Kaludercic writes: > ELPA's seq currently only consists of the following > > --8<---------------cut here---------------start------------->8--- > (if (version< emacs-version "25") > (require 'seq-24) > (require 'seq-25)) > --8<---------------cut here---------------end--------------->8--- > > where seq-24.el is a compatibility version, while seq-25.el appears to > be the same as lisp/emacs-lisp/seq.el (or at least the version from a > year ago). What I guess this means is that lisp/emacs-lisp/seq.el > should preserve compatibility up until Emacs 25, unless another > backport version should be added to the ELPA package. Unlike other core packages, seq.el is manually merged to GNU ELPA. So we can be flexible when we decide how to go about it. Before breaking backwards compatibility with Emacs 25, perhaps it would be a good idea to update seq-25.el on GNU ELPA to match what we currently have on master. We could then always, (if (version< emacs-version "29") ; or something (require 'seq-25) (require 'seq-29)) or even, (cond ((version< emacs-version "25") (require seq-24)) ((version< emacs-version "29") (require seq-25)) (t (require seq-29))) And then update "Package-Requires" accordingly. As for going forward, I guess it is somewhat nice to maintain backwards compatibility. But I don't know if it's worth doing indefinitely.