From: Stefan Kangas <stefankangas@gmail.com>
To: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Cc: Yuan Fu <casouri@gmail.com>
Subject: Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324)
Date: Sat, 21 Sep 2024 17:59:08 -0700 [thread overview]
Message-ID: <CADwFkmnH=9OExa1K_xFesCb658hHA598wx86VS7wh-6nwD-2ZA@mail.gmail.com> (raw)
In-Reply-To: <87v7yt322l.fsf@yahoo.com>
Po Lu <luangruo@yahoo.com> writes:
> Yuan Fu <casouri@gmail.com> writes:
>
>> branch: emacs-30
>> commit f0daa2f2153a9d250d32ac1261a6fffb30860e31
>> Author: Yuan Fu <casouri@gmail.com>
>> Commit: Yuan Fu <casouri@gmail.com>
>>
>> Conservative heuristic for tree-sitter parser ranges (bug#73324)
>>
>> * src/treesit.c (treesit_sync_visible_region): If the parser's original
>> ranges don't overlap with visible region, give it a zero range, rather
>> than don't set any range.
>> * test/src/treesit-tests.el (treesit-range-fixup-after-edit): Test new
>> behavior.
>
> Please fill ChangeLog entries in commit messages to a width of 64
> columns, not 71 or 72, as here.
I don't want to get into another argument about this, but I don't see
any problem with the above formatting, FWIW.
In any case, I really don't think it is a good use of our time to police
the recently introduced default of 64 columns here. We never did that
before, when the default in `vc-git-log-edit-mode' was 70 characters,
and there is no reason to start doing it now.
next prev parent reply other threads:[~2024-09-22 0:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172663360099.23732.9998257239822693024@vcs2.savannah.gnu.org>
[not found] ` <20240918042641.56C7BC410E2@vcs2.savannah.gnu.org>
2024-09-18 6:31 ` emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324) Po Lu
2024-09-20 4:53 ` Yuan Fu
2024-09-20 6:32 ` Eli Zaretskii
2024-09-20 6:44 ` Eli Zaretskii
2024-09-21 3:10 ` Yuan Fu
2024-09-22 0:59 ` Stefan Kangas [this message]
2024-09-22 5:18 ` Eli Zaretskii
2024-09-22 5:43 ` Po Lu
2024-09-22 6:44 ` Yuan Fu
2024-09-22 21:23 ` Kévin Le Gouguec
2024-09-23 8:27 ` Robert Pluim
2024-09-23 11:49 ` Eli Zaretskii
2024-09-23 17:24 ` Kévin Le Gouguec
2024-09-23 18:24 ` Eli Zaretskii
2024-09-24 7:10 ` Kévin Le Gouguec
2024-09-26 7:28 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmnH=9OExa1K_xFesCb658hHA598wx86VS7wh-6nwD-2ZA@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).