unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: New library wallpaper.el pushed to master
Date: Wed, 14 Sep 2022 07:52:39 -0400	[thread overview]
Message-ID: <CADwFkmnGjJgGSqzb50bmWzzN+WBx-BwtW4V3viEgzGq+7UcDEQ@mail.gmail.com> (raw)
In-Reply-To: <83mtb22ni6.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> BTW, what about actions usually taken to modify the wallpaper such as
>> scaling, cropping, and offsets?  Shouldn't wallpaper-set take several
>> arguments to specify those?
>
> No, I think it should just use the image.  If the user wants to modify
> the image, he/she can do that using "other means", including the
> lately introduced 'image-crop' command.  There's no reason to make
> this simple facility understand too much about images and their
> formats.

I guess what Po Lu had in mind was supporting options such as the
following, from the "feh" man page:

  --bg-center
          Center the file on the background.  If it is too small, it will
          be surrounded by a border as specified by --image-bg.

  --bg-fill
          Like --bg-scale, but preserves aspect ratio by zooming the image
          until it fits.  Either a horizontal or a vertical part of the im‐
          age will be cut off

  --bg-max
          Like --bg-fill, but scale the image to the maximum size that fits
          the screen with borders on one side.  The border color can be set
          using --image-bg.

  --bg-scale
          Fit the file into the background without repeating it, cutting
          off stuff or using borders.  But the aspect ratio is not pre‐
          served either

  --bg-tile
          Tile (repeat) the image in case it is too small for the screen

I think it would be worthwhile to add some defcustoms for this, as this
is likely to be something that users will commonly want to customize.

But I agree with Po Lu that we should try to make this transparent with
regards to the tool.  Perhaps we could add a `wallpaper-default-method'
option with values like `center', `fill', `max', `scale', and `tile'.



  reply	other threads:[~2022-09-14 11:52 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 16:41 desktop-background.el as a new library? Stefan Kangas
2021-10-27 19:02 ` Tassilo Horn
2021-10-27 19:51   ` Stefan Kangas
2021-10-28  2:36     ` Po Lu
2021-10-29 17:26 ` Arthur Miller
2021-10-29 17:44   ` Stefan Kangas
2021-11-15 20:51     ` Arthur Miller
2022-09-13 16:28 ` New library wallpaper.el pushed to master Stefan Kangas
2022-09-13 16:54   ` Eli Zaretskii
2022-09-13 17:09     ` Stefan Kangas
2022-09-13 17:22       ` Eli Zaretskii
2022-09-14  7:13         ` Stefan Kangas
2022-09-14  7:36           ` Stefan Kangas
2022-09-14  7:36           ` Po Lu
2022-09-14 11:10           ` Stefan Kangas
2022-09-14 11:44           ` Eli Zaretskii
2022-09-14 12:01             ` Stefan Kangas
2022-09-15 16:48               ` Stefan Kangas
2022-09-15 11:59           ` Eli Zaretskii
2022-09-15 13:39             ` Po Lu
2022-09-15 13:44               ` Eli Zaretskii
2022-09-15 13:49                 ` Po Lu
2022-09-14  2:46   ` Po Lu
2022-09-14  6:39     ` Po Lu
2022-09-14  7:04       ` Stefan Kangas
2022-09-14  7:33         ` Po Lu
2022-09-14 11:53           ` Stefan Kangas
2022-09-14 12:30             ` Stefan Kangas
2022-09-14 13:42             ` Po Lu
2022-09-14 16:58           ` Sean Whitton
2022-09-15  7:28             ` Stefan Kangas
2022-09-15 16:19               ` Sean Whitton
2022-09-16  1:27                 ` Po Lu
2022-09-14 11:39       ` Eli Zaretskii
2022-09-14 11:52         ` Stefan Kangas [this message]
2022-09-14 12:01           ` Eli Zaretskii
2022-09-14 12:07             ` Stefan Kangas
2022-09-14 12:24             ` Po Lu
2022-09-14 12:41               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmnGjJgGSqzb50bmWzzN+WBx-BwtW4V3viEgzGq+7UcDEQ@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).