From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: seq-union calling seq-reverse? (Emacs master 0cf0a2b98671: Add new sequence function 'seq-union') Date: Fri, 17 Sep 2021 05:18:39 -0700 Message-ID: References: <20210917131328+0200.462267-stepnem@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13735"; mail-complaints-to="usenet@ciao.gmane.io" To: =?UTF-8?B?xaB0xJtww6FuIE7Em21lYw==?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 17 14:20:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRCrC-0003Uc-AY for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Sep 2021 14:20:42 +0200 Original-Received: from localhost ([::1]:51740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRCrB-0005rG-9m for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Sep 2021 08:20:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRCpI-00048m-S5 for emacs-devel@gnu.org; Fri, 17 Sep 2021 08:18:44 -0400 Original-Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]:46638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRCpF-00071r-Tc for emacs-devel@gnu.org; Fri, 17 Sep 2021 08:18:44 -0400 Original-Received: by mail-pg1-x530.google.com with SMTP id m21so260305pgu.13 for ; Fri, 17 Sep 2021 05:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=bHaj1SWrwb2Dyn5aQZ21qX6D9VutOADRwjKvl3DgMMg=; b=AUjt3kOoHnQgaOiLZ4aRHwAScVJtoN9wr5dKIOFNlfVqTCyDkB3NhBjXaH2OHkc5y/ TB6zKkX7rcjsSrsjpx1LQUJBN5isIWbe3L4sak3wwigWGE6RNpO0LQbUCDfP/+W3Z5zF u2k6EC8rQhj6LS09e0jRhCJMP0xaKsfounHMPEpRsgvVIqhzBQ87DG5roRF5ul6Fv/2Q 1UoulPTegIlYvsvixmv6/vhx1yvT358492Kpw7ISJAK6nqmBrJNjX/cC6R0R/EFbaZWz 9KUxCEkkco5yOeZZYdegjUlzboqaI9IOfTCnVCgol0etLCH0yCp09XhEBp6UPukP51UP JSIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=bHaj1SWrwb2Dyn5aQZ21qX6D9VutOADRwjKvl3DgMMg=; b=R5F3+Tl/QlTsbk5n6Azb2qzg9MOgEt5B9+iy35jNd7OjV92ftSZvUzhbkGAhiGh+/L 8z9/vOP8uVSfPldyaGhTp2WFyhlYJ7wQv869kQsB+MXqTJcMxxJrfWh2oVQfnBxSGxT9 +LPtz9MvS/Rtd0oYjEiERmTJC0YsQOncPeEaU4Ojq6av4xcC3GIODWKOgcYG8iC8QW66 P/wicSx2Nx8Ual4HJOV/nLxyEQonbVnrlUCbuLIvoVAh9kKnYCjKAB7ikPnzvFnJhO3y qfY5O4AbK2+9pBXiZS3hQqyuX6tf5i9vyAEV0S/C9TC3SUWXq3vvUMKZiTsvwfs3wDls 536A== X-Gm-Message-State: AOAM532spB1bS/F0b3aOOhiYb+VEHxlBqUjhkOI/zLzDqubBA2qhlRwx muOiQlT8/i3DIz841L97qjaGewdPiGLrm+DIUic= X-Google-Smtp-Source: ABdhPJyIwF5dv5A2s75SQTMWy2eUACA/DmLC03Yz+rGjrCYZ++ZDUddvaAzJtPfY7HW0YrpWgkKcT4gSkdUgBhO/2JM= X-Received: by 2002:a63:7d5d:: with SMTP id m29mr9574438pgn.114.1631881120102; Fri, 17 Sep 2021 05:18:40 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 17 Sep 2021 05:18:39 -0700 In-Reply-To: <20210917131328+0200.462267-stepnem@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=stefankangas@gmail.com; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274863 Archived-At: =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec writes: > +(cl-defgeneric seq-union (sequence1 sequence2 &optional testfn) > + "Return a list of all elements that appear in either SEQUENCE1 or SEQU= ENCE2. > +Equality is defined by TESTFN if non-nil or by `equal' if nil." > + (let ((accum (lambda (acc elt) > + (if (seq-contains-p acc elt testfn) > + acc > + (cons elt acc))))) > + (seq-reverse > + (seq-reduce accum sequence2 > + (seq-reduce accum sequence1 '()))))) > + > > `seq-reverse' seems gratuitous here WRT the purpose of `seq-union'. I have pushed a fix to make it use `nreverse' instead. This is faster, and in line with e.g. seq-partition, seq-uniq, etc.