From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Is it better to add treesitter modes to core? Date: Mon, 8 Jan 2024 21:20:04 -0800 Message-ID: References: <87a5phiap4.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stephen Leake To: Dmitry Gutov , Philip Kaludercic , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 09 06:20:57 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rN4Xp-0008Ds-AM for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jan 2024 06:20:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rN4X5-0001Eb-RE; Tue, 09 Jan 2024 00:20:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rN4X3-0001EK-3P for emacs-devel@gnu.org; Tue, 09 Jan 2024 00:20:09 -0500 Original-Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rN4X1-0000SB-6S for emacs-devel@gnu.org; Tue, 09 Jan 2024 00:20:08 -0500 Original-Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5542a7f1f3cso2840873a12.2 for ; Mon, 08 Jan 2024 21:20:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704777605; x=1705382405; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=OVRSoeR+ORu2uepbvk6Llh2Oz1zNTrP8O7QmSElXlIE=; b=h7SqoIxxYCc5looaUtivJ/QYVATLKCoZ7K/vsRLJnsqw+9YOE3xJm2AY99ndNOU28B pheu1UM1+rd87joBHrCK1dZsRl5kxzulGZRlsRyYUYYNru9QZ8DHwK+e0MbXz3Lvxfk+ fA59fkfl12b9XR2l4IfuU3Nuakrvak3oO/u0kNWABqeq6gR/UVexLz4g1XsJCN0wlss2 k0tFMegOpwahpKzTdC8quoBKA9qjNN6QO4U3N/T2EujfvK9SYwTQTPazed/a4tY2WfeS f7l8QYh1iWmvJ0DlYPGcSik5ZJ1ZI/4HOEndTMB+khGgdL7LDPZKgncYGeDPc/5kKAin KXJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704777605; x=1705382405; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OVRSoeR+ORu2uepbvk6Llh2Oz1zNTrP8O7QmSElXlIE=; b=TQVYAKRvbd5tUmFfe6S974yFelI+wFvPhTbDBr7BHdB6MWritBUQQa1FkSDnEcAkj9 wklJCSKXe/OW0jEIpVoUhT5F1c5oTLv8noS9Sl/DXtaNhVntZOwm+/f36TjKkxXtoy2C avWS95HKJ5A+H8vVltga7KuoGF0fUf0Cc14PTIw++McXDHkFCCIZ6Sf03s8toi/qawJG A6S60Y7Y8SAD25tVKlcJXU+t+DAYnWpUM7QVroVKOXIL96rkl8WzkqItLbiwsHqrjfQa vceoXbc8USrOf6mO3RzUfSpnFKg4aA1E4KhuVzrTT43yC69S7eIik3Ma/n0UCVL2RZrk 7yBA== X-Gm-Message-State: AOJu0YwLHL8cIMZAhFG4IRJvX5mefeWDwDqnNyqVAOTHJpZOmRWS3Mor ca4f1CtIMpjYlAcAnw1fWXEd2ookUN2GLPG3/XI= X-Google-Smtp-Source: AGHT+IEDwjqCY8aPaMgYPF7CtCBUBn1tcM5db5FNjzqFl17XF9Jrg7ZzcDHzlaF0ovcwIs74+GpB2kMnyHpCmSZn6/I= X-Received: by 2002:a50:a6da:0:b0:557:6084:f668 with SMTP id f26-20020a50a6da000000b005576084f668mr2663183edc.30.1704777605336; Mon, 08 Jan 2024 21:20:05 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 8 Jan 2024 21:20:04 -0800 In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314771 Archived-At: Dmitry Gutov writes: >> I see little reason for that. > > You don't want ELPA to be used? I do, of course. :-) No one has proposed to add everything to core. >> In my ideal world, we should have basic editing support in place in >> Emacs for typical tasks, and packages should provide extensions. Most >> users don't particularly enjoy starting work with installing a bunch of >> extras. > > The way VS Code works and its level of popularity seem to say > otherwise. Yes, but VSCode has some niceties that we don't. When Emacs displays an unobtrusive little popup in the right corner saying "Hello, this looks like $LANGUAGE, do you want to install support for that? [YES/NO]" then I will agree with you that it's less important to keep stuff in core. >> Take a look at how much better things are elsewhere and weep: >> >> https://github.com/vim/vim/tree/master/runtime/syntax >> >> Yes, vim is different, their job is easier and so on and so forth. > > It is only better if the features provided in there are reasonably > complete and well-maintained. Do you have any reason to believe that they're not? For the very small sample set that I've looked at, they certainly blew the corresponding Emacs modes out of the water. For some of the things listed there, we don't even have a mode. >> We might not want _all_ language support in Emacs, but for the main >> languages: why would we _not_ want it? While I appreciate the >> importance of workflow related arguments, from the end users point of >> view, it really is a no-brainer which way is better. > > I don't really mind having the major modes for most popular languages in > here, because in those cases the problem of extra traffic is offset by > the advantage that one can see a problem and contribute a fix that will > go out to help a lot of people. Even if I don't use a language in > question myself. But doing that with languages that are unfamiliar to > most contributors, and have small audience, is questionable. Yes, fully agreed. >> I think historical context matters here. Ada is not exactly in vogue >> these days, but it _is_ supported by GCC, and it has an ISO standard. >> It's not some random novelty language for people that feel that >> Typescript is not edgy enough, or anything like that. >> >> We also happened to support it in Emacs for ages. > > And it's still there in ELPA, available for everybody to install. > > Note that I don't mean to belittle Stephen's work, nor have any desire > to throw it away, but the sentiment "it's unmaintained, let's bring it > in the core and see what happens" sounds very wrong to me. > > It would be a good idea for the interested parties to pay more attention > to ELPA and improve it there. I'm not yet convinced that we should add a new ada-ts-mode.el to core. The fact that it wouldn't have a dedicated maintainer deeply invested in the language certainly speaks against it. I'm also not sure that we would want something half-baked in core for a language with a small user base, since that makes it less likely that an Emacs mode maintainer will step forward. The strongest argument for keeping the more venerable languages around is that their support is super stable, after all.