From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: RE: Merging scratch/substitute-command-keys to master Date: Sat, 17 Oct 2020 17:46:21 +0000 Message-ID: References: <72f3d9b9-fa2a-4116-a817-6dcb7f74e97b@default> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9836"; mail-complaints-to="usenet@ciao.gmane.io" To: Drew Adams , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 17 19:47:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTqIf-0002Ra-IF for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Oct 2020 19:47:25 +0200 Original-Received: from localhost ([::1]:38642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTqIe-0002BL-JE for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Oct 2020 13:47:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTqHh-0001kr-4C for emacs-devel@gnu.org; Sat, 17 Oct 2020 13:46:25 -0400 Original-Received: from mail-ej1-f45.google.com ([209.85.218.45]:46174) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kTqHf-0002lN-9w for emacs-devel@gnu.org; Sat, 17 Oct 2020 13:46:24 -0400 Original-Received: by mail-ej1-f45.google.com with SMTP id t25so7964343ejd.13 for ; Sat, 17 Oct 2020 10:46:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=w8C8pgSy+2SlH8WDpUMl3VIVh4oxtLIfJ0C31pWrZbs=; b=V555TA0yXnHuyk61JA7HFvI9h6f48jGyIJ2sJv7Im9TBiO50YmspxQBJgJKzb/u0Gf 8yMhEbPk1xNU1WgEF7iqrpENYgeqmmkiDbLk8kPzb8ZC1kuoqu/YkNeINxIH51e0+x1G cpvQ9yxJgrtaYWOC5XSCHO9wRvAnG6oDesfAetizNqZJeAbRHzrDVnamofI1/5wi0ggn umgkRfmTUJhLZBKZNjBtCqpTO0o19RVZS4iD/78RtoYF6QRnMBI6sJrttLTN/uWrAWW2 MP4zHfgW5/MsESAcd0WNd1ysYgyPU352tj2/fynKySxiUyhfIris43+sQRV5f4k2Ulay ahuQ== X-Gm-Message-State: AOAM530veCs0q2lQZWAqODjcbGJuNdatwAk3vDRhlVC8BTrafiGskqmm NvwZPfVdNolndVnUYWHIGZmQOEjEpwEw0jX9FN8= X-Google-Smtp-Source: ABdhPJxepkJW/qiGnCR74ryFXfj+hicLGQTyXw+wgTcCCp12hEWPkGPu5bT2MxpkC9xzCDHR9cObH+lyWhbOmJ5P7Co= X-Received: by 2002:a17:906:bc91:: with SMTP id lv17mr9865204ejb.249.1602956781847; Sat, 17 Oct 2020 10:46:21 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 17 Oct 2020 17:46:21 +0000 In-Reply-To: <72f3d9b9-fa2a-4116-a817-6dcb7f74e97b@default> Received-SPF: pass client-ip=209.85.218.45; envelope-from=stefankangas@gmail.com; helo=mail-ej1-f45.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/17 13:46:22 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257958 Archived-At: Drew Adams writes: >> I've been working on translating `substitute-command-keys' from C to >> Lisp, and I think it's getting ready to merge to master. > > Sounds good. Thanks for working on this. > > I hope you'll consider adding help buttons for key descriptions, > as is done in my function `help-substitute-command-keys' (in > `help-fns+.el), which I think you've seen. Doc: > > (help-substitute-command-keys STRING &optional ADD-HELP-BUTTONS) > > Same as `substitute-command-keys', but optionally adds buttons for help. > Non-nil optional arg ADD-HELP-BUTTONS does that, adding buttons to key > descriptions, which link to the key's command help. Thanks for commenting. I specifically avoided making any functional changes on this branch; my main concern was correctness. But it should indeed be much easier to add features like the above once this is merged.