unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Drew Adams <drew.adams@oracle.com>, emacs-devel@gnu.org
Subject: RE: Merging scratch/substitute-command-keys to master
Date: Sat, 17 Oct 2020 17:46:21 +0000	[thread overview]
Message-ID: <CADwFkmnF+eeo6EzNvcZZhVukMHxm4ytROJ=mXnD_P8FaZCoVGQ@mail.gmail.com> (raw)
In-Reply-To: <72f3d9b9-fa2a-4116-a817-6dcb7f74e97b@default>

Drew Adams <drew.adams@oracle.com> writes:

>> I've been working on translating `substitute-command-keys' from C to
>> Lisp, and I think it's getting ready to merge to master.
>
> Sounds good. Thanks for working on this.
>
> I hope you'll consider adding help buttons for key descriptions,
> as is done in my function `help-substitute-command-keys' (in
> `help-fns+.el), which I think you've seen.  Doc:
>
>  (help-substitute-command-keys STRING &optional ADD-HELP-BUTTONS)
>
>  Same as `substitute-command-keys', but optionally adds buttons for help.
>  Non-nil optional arg ADD-HELP-BUTTONS does that, adding buttons to key
>  descriptions, which link to the key's command help.

Thanks for commenting.

I specifically avoided making any functional changes on this branch; my
main concern was correctness.  But it should indeed be much easier to
add features like the above once this is merged.



      reply	other threads:[~2020-10-17 17:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-17 14:03 Merging scratch/substitute-command-keys to master Stefan Kangas
2020-10-17 15:05 ` Eli Zaretskii
2020-10-17 16:19 ` Stefan Monnier
2020-10-17 23:35   ` Stefan Kangas
2020-10-18  4:09     ` Stefan Monnier
2020-10-18 11:42       ` Stefan Kangas
2020-10-18 16:11     ` Stefan Kangas
2020-10-17 17:22 ` Drew Adams
2020-10-17 17:46   ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmnF+eeo6EzNvcZZhVukMHxm4ytROJ=mXnD_P8FaZCoVGQ@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).