unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Juri Linkov <juri@linkov.net>
Cc: Augusto Stoffel <arstoffel@gmail.com>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: Patch to avoid flicker in Isearch with lazy count
Date: Sun, 5 Sep 2021 00:43:45 +0200	[thread overview]
Message-ID: <CADwFkmnBhRzXWM3woO+OJ3n5uesjzOMkjbbwxkHNL2keeQV3cg@mail.gmail.com> (raw)
In-Reply-To: <87mtwqp8d5.fsf@mail.linkov.net>

Juri Linkov <juri@linkov.net> writes:

> > I have attached a new patch addressing the issues we discussed.  I have
> > also changed the name of the new variable a bit, I hope it's a bit more
> > self-explanatory now.
>
> Thanks for the patch, everything looks good.  Now pushed to master.

[Sorry for coming back to this late, it comes from looking over NEWS
in preparation of the upcoming release of Emacs 28.1.]

If the variable 'lazy-highlight-no-delay-length' only applies to
isearch, shouldn't it rather be named
'isearch-lazy-highlight-no-delay-length'?

If it does not only relate to isearch, perhaps this should be clarified in NEWS?
The current text is:

    ** New user option 'lazy-highlight-no-delay-length'.
    Lazy highlighting of matches in Isearch now starts immediately if the
    search string is at least this long.  'lazy-highlight-initial-delay'
    still applies for shorter search strings, which avoids flicker in the
    search buffer due to too many matches being highlighted.

I see that there are several variables starting with 'lazy-highlight',
and I know next to nothing about this, so please let me know what you
think.



  reply	other threads:[~2021-09-04 22:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 15:41 Patch to avoid flicker in Isearch with lazy count Augusto Stoffel
2021-01-27 17:48 ` Juri Linkov
2021-01-28  7:32   ` Augusto Stoffel
2021-01-28  9:06     ` Juri Linkov
2021-01-28 11:17       ` Augusto Stoffel
2021-01-28 18:48         ` Juri Linkov
2021-01-29 17:50       ` Augusto Stoffel
2021-01-30 18:50         ` Juri Linkov
2021-09-04 22:43           ` Stefan Kangas [this message]
2021-09-05  7:54             ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmnBhRzXWM3woO+OJ3n5uesjzOMkjbbwxkHNL2keeQV3cg@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=arstoffel@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).