* Re: master ec0527d 1/4: Use command substitution for exit-recursive-edit
[not found] ` <20210918214240.0C2FF20ABE@vcs0.savannah.gnu.org>
@ 2021-09-18 22:50 ` Andreas Schwab
2021-09-19 6:00 ` Eli Zaretskii
2021-09-19 10:15 ` Stefan Kangas
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Schwab @ 2021-09-18 22:50 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Kangas
On Sep 18 2021, Stefan Kangas wrote:
> branch: master
> commit ec0527d8e9a7f12898c8fe9fdb6daec21c1d2ba8
> Author: Stefan Kangas <stefan@marxist.se>
> Commit: Stefan Kangas <stefan@marxist.se>
>
> Use command substitution for exit-recursive-edit
This breaks bootstrap.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master ec0527d 1/4: Use command substitution for exit-recursive-edit
2021-09-18 22:50 ` master ec0527d 1/4: Use command substitution for exit-recursive-edit Andreas Schwab
@ 2021-09-19 6:00 ` Eli Zaretskii
2021-09-19 10:15 ` Stefan Kangas
1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2021-09-19 6:00 UTC (permalink / raw)
To: Andreas Schwab; +Cc: stefan, emacs-devel
> From: Andreas Schwab <schwab@linux-m68k.org>
> Date: Sun, 19 Sep 2021 00:50:56 +0200
> Cc: Stefan Kangas <stefan@marxist.se>
>
> On Sep 18 2021, Stefan Kangas wrote:
>
> > branch: master
> > commit ec0527d8e9a7f12898c8fe9fdb6daec21c1d2ba8
> > Author: Stefan Kangas <stefan@marxist.se>
> > Commit: Stefan Kangas <stefan@marxist.se>
> >
> > Use command substitution for exit-recursive-edit
>
> This breaks bootstrap.
Something to remember when moving code from C to Lisp: it might
introduce ticking time bombs into loadup.el.
Stefan, I see you reverted the change, but an alternative could be to
move loading of bindings.el in loadup.el to after help.el, or move
help.el before bindings.el. If this doesn't break the build, it could
be an okay solution (but please add a comment about the order
dependency there).
Alternatively, you could modify the value of mod-line-modes in
startup.el.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master ec0527d 1/4: Use command substitution for exit-recursive-edit
2021-09-18 22:50 ` master ec0527d 1/4: Use command substitution for exit-recursive-edit Andreas Schwab
2021-09-19 6:00 ` Eli Zaretskii
@ 2021-09-19 10:15 ` Stefan Kangas
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Kangas @ 2021-09-19 10:15 UTC (permalink / raw)
To: Andreas Schwab, emacs-devel
Andreas Schwab <schwab@linux-m68k.org> writes:
> This breaks bootstrap.
Thanks, I reverted the offending hunk on master for now.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-19 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210918214238.18205.26241@vcs0.savannah.gnu.org>
[not found] ` <20210918214240.0C2FF20ABE@vcs0.savannah.gnu.org>
2021-09-18 22:50 ` master ec0527d 1/4: Use command substitution for exit-recursive-edit Andreas Schwab
2021-09-19 6:00 ` Eli Zaretskii
2021-09-19 10:15 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).