From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Please stop making extra unnecessary work for us all. Date: Tue, 12 Oct 2021 08:00:57 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28703"; mail-complaints-to="usenet@ciao.gmane.io" To: Alan Mackenzie , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 12 17:04:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maJKa-0007Fy-4f for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Oct 2021 17:04:40 +0200 Original-Received: from localhost ([::1]:54158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maJKY-0000jF-UZ for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Oct 2021 11:04:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maJH3-0004iE-AX for emacs-devel@gnu.org; Tue, 12 Oct 2021 11:01:03 -0400 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:39774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maJH1-0007tb-KH for emacs-devel@gnu.org; Tue, 12 Oct 2021 11:01:01 -0400 Original-Received: by mail-pj1-f49.google.com with SMTP id ls18-20020a17090b351200b001a00250584aso2086822pjb.4 for ; Tue, 12 Oct 2021 08:00:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=z0CaHp+SuGRp8Lc8I3GY47P19w9iJ4cOVpBv9Exu94g=; b=1MMD4pEKnRc/piVWlGHFsGVr4FvB9wffKBTRMFmtv9r+Ci1ZWIufkWafWkH9uSQFqB jVWyOyBl7nqcXBfYFiiTdiubpWzqVqBtcbAAtr00J9ampVK+Xr08oSJ6RPZtZPCuItIN 5Id/svJMPsvH/HV/abxTosYJVsOFBA/R0n8rkwUsCoYdhtoM4tBAjGf+G+sf1luxcfqM 27ScDInrVY3ronOepyLk7q+fzCMwQu930KUQ6N49/8GK1yIHPV59LjlGSCKB7n8Kl5LY 9LU6I9gVhnnBnyOCxP5bwXmmFVDoJ3fJMyAlcDWfi/+Mph4cHWL6GOTeNTAQBLBVfsLE bOlA== X-Gm-Message-State: AOAM533KH6YFR0Zhx4uG6hJby5moVlaOaYLgbr1GNXCt7Qts2Hw6QRkE 6ehZErxBobaIroppu2g+oIMkGd9FKIaU/N1X1q3lHwTV X-Google-Smtp-Source: ABdhPJwPWlfXwCO1pxWF8Xe+3gZ0Mo5EEt51TdH7nZYV/DZN1AAdSEHVq5JXtvh/dfsLx6f9bYNmkzq1zI08gT/k7I0= X-Received: by 2002:a17:90a:5583:: with SMTP id c3mr6366696pji.133.1634050857799; Tue, 12 Oct 2021 08:00:57 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 Oct 2021 08:00:57 -0700 In-Reply-To: Received-SPF: pass client-ip=209.85.216.49; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f49.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276808 Archived-At: Alan Mackenzie writes: > Many non-functional changes have been made in CC Mode. That > additionally means that patches from standalone CC Mode are even less > likely to apply cleanly in the Emacs branches than they were already. > That means extra unwanted tedious work for me. > > And what are these changes? In at least two instances the case of a > letter in warning messages following a colon was changed from lower to > upper. Or was it the other way around? Come on, please, this is > madness. Who would even notice the case of a letter after a colon in a > warning message, much less care about it? I do apologize if these changes lead to a large amount of extra work for you. I'm not familiar with how CC-mode is developed, so I had assumed that you would merge the Emacs tree into yours or the other way around, which seems to be the most common solution to merge conflicts. I will think twice before making any changes to cc-mode in the future. The background is this: I was running checkdoc in an automated way on the entire Emacs codebase. This allowed me to fix many real issues in our documentation and clear violations of our style. Every time there was an issue, if I could fix it, I did, as it slowed this process down -- for me, and anyone that might do this later. (Checkdoc stops on every single one for review.) Some of them I couldn't fix, so I left them alone. If someone wants to, they can now run checkdoc on all our Lisp code in an automated way and relatively quickly find any newly introduced issues, for example shortly before releasing a new version. My hope is that this will lead to more consistency in our documentation and messages. I expect that you value such things as much as I do. Parts of your message unfortunately seems to be suggesting that these changes were insignificant and/or useless taken as a whole. I think that such a view is mistaken, and misses the point. For example, one outcome of this work was improvements to checkdoc.el, another was an improvement to our coding conventions. These things would not have happened without first running checkdoc.el on our code. Your claim that some of the changes were minor is true. I cannot agree that they were therefore not worth doing; if you take such a line of reasoning too far, we should also not run spell checkers, as typos don't matter. Most of the changes under discussion are clear mistakes that should have been fixed. But I concede that some changes might have slipped through that were not very important to make. I'm only human, I do my best. I hope that you can accept my limitations and mistakes in this regard. Meanwhile, I'm willing to accept that the best analogy you could find here is "whitespace changes".