From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Use vtable for eww-bookmarks Date: Tue, 7 Jan 2025 21:01:52 +0000 Message-ID: References: <87ldx0vufd.fsf@sebasmonia.com> <8fde5a67-f778-f0c8-bcdd-ece08c95d369@gmail.com> <87h67nm4su.fsf@sebasmonia.com> <28ba395f-5c52-1fc8-a99a-9bae461520d8@gmail.com> <36a57a48-76ab-4254-b3bc-af1fff2d9b98@app.fastmail.com> <87ttb9k04u.fsf@sebasmonia.com> <86wmfkt6ei.fsf@gnu.org> <39071ad9-a369-2e2f-aa1c-779f8103b566@gmail.com> <87cyh8z9tg.fsf@sebasmonia.com> <87seq1alkl.fsf@sebasmonia.com> <36ff480e-0155-479d-87fb-9a85232dac47@app.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10656"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Adam Porter , Jim Porter , Eli Zaretskii , emacs-devel To: =?UTF-8?B?U2ViYXN0acOhbiBNb27DrWE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 07 22:03:03 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVGj7-0002XA-22 for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Jan 2025 22:03:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVGiO-0002uv-AK; Tue, 07 Jan 2025 16:02:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVGi4-0002nk-Gr for emacs-devel@gnu.org; Tue, 07 Jan 2025 16:01:56 -0500 Original-Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVGi3-0001Wq-1e; Tue, 07 Jan 2025 16:01:56 -0500 Original-Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5d647d5df90so12825066a12.2; Tue, 07 Jan 2025 13:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736283713; x=1736888513; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=+SWaTmlhYeSAs5P5s+z98MSEv+Fyexj7UN4r08PJXaQ=; b=l7UNVm5On4uP6IVwnxe97QQdh7DfuppXt3dSRZsgNmc/hDDVTEA4jibRRUEvY8XHC0 2fvziP09X6KEC/Q13jucFiPyITsAv+rQzmATUZnReqaIOkJk5T8XSnK1+y20dLH508Cu zZuN2ebKoul6ACVhMntIvBDBHyh6Rnwsb4GvlVLG73+ssSOX2q9+4N4tVPTLaTDKbf+8 UXq5NqVLFStdYf6/JhW5L9m6taRpeoP+08A5TjwJ9tzSd2xcqDt4e0MBuhf2oxB/Ctq4 ASTebV6btbffKcZvfR1Nq/foMOYDz6byxOAts1W3qGeFVhQabeWFr9EqsKep0kHWi9ri yb1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736283713; x=1736888513; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+SWaTmlhYeSAs5P5s+z98MSEv+Fyexj7UN4r08PJXaQ=; b=F2RcgfMkROgnD37o41pFXmDdI9Jl8QFvtrSo8AXdhw9A3Fim+Yxf8eOCGbY62lAlqz OzGhs+RsAIg6syNDUQhRQ0bddRJiy90iIYUYY99VYarfj2CSqRUhQI3dRaTKkG7DzFF6 YQYeCy/xB+lfRXZzdL4pdBoeZN7TYRYs7UIjwJ/3SEl3LHJqKN4Ld8wd9vwpaoWVTH9t bDXao+Tq0zyAbo/5/d+MjQtB28wW4sIDOVMXfGW28W7Qe62ktcR0aj0Vsfi3hyjKt1uH lcTK5kfT6kxSaS24RdT+eCvlTYrEfk+Cp8uP+FSt2XZ+34PvqtdQHGXq8lQCmMDKTUZ7 +wRQ== X-Forwarded-Encrypted: i=1; AJvYcCVEqJwwFSAjAzSYxoE/qh8deszPmIZT3oS9Gp6ZLgJtYNrMO5dFbpUU3fRJbaqhfm2vi2uV@gnu.org, AJvYcCW0jE4JXxJ6y7txV/L1wHHSgtFaukOB3BBSxVSJVnppGLv8OWaW4m2J7uFx56JvS2M2HlFbmQzA/0QFTBg=@gnu.org X-Gm-Message-State: AOJu0YySqsef0Q5ZfpXN63SS4tb/JFdVGq7XBtFLJGApKxbbqVnp3eKz sm2ZWFEltsPsMA5a8QVBRGsw9uHcdGAxE8Sy8/rBmL1I9ki7JIHR3pFGK7cGdPiHP9Q5XGC118o k1nt7320FvKFXRrE/ykutaUdMVl3x2g== X-Gm-Gg: ASbGncsnrcjCm3vnSjy7Euntls79/yVZ87boGvlBLR9kmbdycot/xI3Idtgm8xBDYuL 2EOnTVeBsw55QZR9aXVfHMIdIx7jHw63CK/OlNio= X-Google-Smtp-Source: AGHT+IG2YGYnEnXweEKWByIXHMKDBkV4NhpZ8WlmqwBpjwsEmx7DzwFs9+NNf5yMtYolVqx1xH/2s7Txgt3GVJ7rhOI= X-Received: by 2002:a05:6402:1e90:b0:5d0:88da:c235 with SMTP id 4fb4d7f45d1cf-5d972e6e4d8mr188892a12.31.1736283712584; Tue, 07 Jan 2025 13:01:52 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 7 Jan 2025 21:01:52 +0000 In-Reply-To: X-Gm-Features: AbW1kvaVe3MA-hXKBOL5Haz8-EzH7aHzvTVTNgbpE907K4zUrDUE1Yqxb1utTKo Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327774 Archived-At: Sebasti=C3=A1n Mon=C3=ADa writes: > Stefan Kangas writes: >> Sebasti=C3=A1n Mon=C3=ADa writes: >> >>> lack of movement in this thread which is probably a >>> gauge for interest in the change. >> >> I wouldn't necessarily interpret a lack of replies or a long >> turnaround time as disinterest[...] keep in mind that all of us are >> volunteers, and do this in our free time too. > > Yes, this is why I said "probably". Heck, even when I made updates to the > patch, sometimes I took a long time to get to it :) > > But since Eli's latest ping and the subsequent conversation about > deprecating EWW's own bookmark mechanism, I am thinking that maybe this > isn't worth our collective time. Again, coming from a practical place! Is there any reason not to merge your latest patch while we wait for deprecating EWW's bookmarks to happen? Adam says that it's already an improvement, and I'd agree if it means replacing bespoke code with using vtable. From a cursory look, I don't see anything controversial in there. Adam also asked for people to speak up if they object to the patch over a week ago, and no one did.