unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: "Sebastián Monía" <sebastian@sebasmonia.com>
Cc: Adam Porter <adam@alphapapa.net>,
	Jim Porter <jporterbugs@gmail.com>,  Eli Zaretskii <eliz@gnu.org>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] Use vtable for eww-bookmarks
Date: Tue, 7 Jan 2025 21:01:52 +0000	[thread overview]
Message-ID: <CADwFkmn0QhF+GwY0QkQTzNvG==UXL4bMjQyGOjrELVtBre_1ow@mail.gmail.com> (raw)
In-Reply-To: <thqnldvmh0n1.fsf@sebasmonia.com>

Sebastián Monía <sebastian@sebasmonia.com> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>> Sebastián Monía <sebastian@sebasmonia.com> writes:
>>
>>> lack of movement in this thread which is probably a
>>> gauge for interest in the change.
>>
>> I wouldn't necessarily interpret a lack of replies or a long
>> turnaround time as disinterest[...] keep in mind that all of us are
>> volunteers, and do this in our free time too.
>
> Yes, this is why I said "probably". Heck, even when I made updates to the
> patch, sometimes I took a long time to get to it :)
>
> But since Eli's latest ping and the subsequent conversation about
> deprecating EWW's own bookmark mechanism, I am thinking that maybe this
> isn't worth our collective time. Again, coming from a practical place!

Is there any reason not to merge your latest patch while we wait for
deprecating EWW's bookmarks to happen?  Adam says that it's already an
improvement, and I'd agree if it means replacing bespoke code with using
vtable.  From a cursory look, I don't see anything controversial in
there.

Adam also asked for people to speak up if they object to the patch over
a week ago, and no one did.



  reply	other threads:[~2025-01-07 21:01 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05 22:53 [PATCH] Use vtable for eww-bookmarks Sebastián Monía
2024-11-06 12:21 ` Eli Zaretskii
2024-11-06 13:36   ` Sebastián Monía
2024-11-06 14:33     ` Eli Zaretskii
2024-11-06 14:43     ` Visuwesh
2024-11-06 16:52       ` Sebastián Monía
2024-11-06 20:49         ` Sebastián Monía
2024-11-07  2:00           ` Visuwesh
2024-11-07  2:00           ` Visuwesh
2024-11-20 19:27         ` Sebastián Monía
2024-11-11  7:38       ` Jim Porter
2024-11-23 19:12 ` Jim Porter
2024-11-27 20:02   ` Sebastián Monía
2024-11-28 19:49     ` Jim Porter
2024-12-01  5:33       ` Sebastián Monía
2024-12-01  6:39         ` Adam Porter
2024-12-01 16:17           ` Sebastián Monía
2024-12-01 19:31           ` Jim Porter
2024-12-01 22:12             ` Sebastián Monía
2024-12-09  4:52               ` Jim Porter
2024-12-10 19:16                 ` Sebastián Monía
2024-12-12  4:15                   ` Sebastián Monía
2024-12-12 15:25                     ` Sebastián Monía
2024-12-12 18:08                       ` Adam Porter
2024-12-12 19:37                         ` Sebastián Monía
2024-12-28 11:04                           ` Eli Zaretskii
2024-12-31  0:07                             ` Jim Porter
2024-12-31  5:43                               ` Sebastián Monía
2024-12-31 18:29                                 ` Adam Porter
2024-12-31 20:10                                   ` [External] : " Drew Adams
2025-01-02  4:25                                   ` Sebastián Monía
2025-01-07 12:23                                     ` Sebastián Monía
2025-01-07 12:59                                       ` Adam Porter
2025-01-07 18:55                                         ` Sebastián Monía
2025-01-07 19:27                                           ` Stefan Kangas
2025-01-07 19:41                                             ` Sebastián Monía
2025-01-07 21:01                                               ` Stefan Kangas [this message]
2025-01-07 22:47                                                 ` Jim Porter
2025-01-08  6:02                                                 ` Thierry Volpiatto
2025-01-08 15:52                                                   ` Adam Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmn0QhF+GwY0QkQTzNvG==UXL4bMjQyGOjrELVtBre_1ow@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=adam@alphapapa.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=sebastian@sebasmonia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).