From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] new package: clangd-inactive-regions Date: Sat, 2 Nov 2024 18:21:58 -0700 Message-ID: References: <87plnd2rin.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23654"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Filippo Argiolas , emacs-devel@gnu.org, Eli Zaretskii , =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Felician Nemeth Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 03 02:22:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7PKP-00064C-6V for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Nov 2024 02:22:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7PJd-0007Wd-5c; Sat, 02 Nov 2024 21:22:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7PJb-0007WO-NE for emacs-devel@gnu.org; Sat, 02 Nov 2024 21:22:03 -0400 Original-Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t7PJa-0006pt-1p; Sat, 02 Nov 2024 21:22:03 -0400 Original-Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a99fa009adcso204756966b.0; Sat, 02 Nov 2024 18:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730596920; x=1731201720; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=9h63rZrtpFiBvbnpXFvPVKKg3EYUdZ8ftYdrxdW14Kk=; b=HPjuEMCKQ+YaMSW8mfEeKZHIvxpIuidPGSA9otZBb2b2kOeHJuHLEo4ZAjNq1PMduN Enc6X1DiPTxIDph2eZ9qVjG4VjdMbOVHVAH4SU/FkuUpfmunKGG/YFSMymCZwdhx01Dv e+gnGGsIZZSgXKaNMGdRsh/2I2vwE6T6XIYm+wN5IpIoCajwSYp8NE/6trcQftjn2YOY Ew4s6ddg/thFMwgHoXG7Tndk0MlKiA2RKf6Y1S2oq//uclFKGyNRGCrXk4Vg+hhYuHln PuruzCknBpPGy9lb2kG4jG5yX2pSMrR/5K3bKsdZXsdEMq1myTag/HxCFolzAeT32niC kEOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730596920; x=1731201720; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9h63rZrtpFiBvbnpXFvPVKKg3EYUdZ8ftYdrxdW14Kk=; b=sJzJZsAoIk/460cN6OrQFkDyTVwNjmY5jNcC9xUrukXGlQ6AwF2WRYgu9VHlV0WzKL 2pDXV9n1TZLm/zadyvtTlTD9EmrPQkZfNfwjomh19/d2HZ7F2h6MKCOhPw50Op/lTRP/ GA8qFVF8dkrhw0kFEFwZCUWLuYZvKrdx2JE14BcAH/n4SD5jAgqm8Ra9LHpTAhlljcr2 5IuZyn14lj9Ritf4ms7ZRa7wRZVkA1Dib8dVtqL3yXCFYddp6GtWaZJYn7ik42RKKGwD cT31AGdZeZ1v8JRldnw+lHzF39a59TKqrQCg6akXXvSZgF1OfYrRI5EzaOZ72u0AxSi5 KrwQ== X-Forwarded-Encrypted: i=1; AJvYcCUI88v+xLqPxznfdfm59NSodPP1ZqriIjUvHM/l9Ny0lDVQkQFP4IcReLBlcn7QC0NDkMW7PnDDnEtZ20g=@gnu.org, AJvYcCXfuc/WTTxSo3khLOnUPL9RjV8gqGNoehYvvXXSchCKz/5ZB35kIR7P6uvfqanmUmMb6QCa@gnu.org X-Gm-Message-State: AOJu0Yx56UnxMQyE7RPzklud+8YzLiHdGMc0LomId66fuiRVNBlsZ/c4 uIBEe5gF5nwP/gbfWC/IJJbz/83eWIvS9UkqpCXr2x+NS2VJ1zGvL631wBlOi6M0rajzozN5xEL CcODyLNeKV+6VWdVZ5MbkvTNp4EfMeg== X-Google-Smtp-Source: AGHT+IFQeOQiSR24mSkSQzuEA+ft2UEZLd9Za4B9z1lILBKPBbtU4TT1ZRPsiByU/GZtPvITHHoBHcIpptjRv+y/qcI= X-Received: by 2002:a05:6402:2106:b0:5ce:b715:6529 with SMTP id 4fb4d7f45d1cf-5ceb923efadmr8011496a12.3.1730596919681; Sat, 02 Nov 2024 18:21:59 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 2 Nov 2024 18:21:58 -0700 In-Reply-To: <87plnd2rin.fsf@betli.tmit.bme.hu> Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=stefankangas@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325036 Archived-At: Felician Nemeth writes: > There is an open pull request by Slava Akhmechet in eglot-x that > implements a similar feature for clangd and ccls (which uses a differnet > LSP extension) [1]. There I wondered its compatibility with the > built-in hide-ifdef-mode. > > Slava originally sent the pull request to the Eglot's repository [2], > but Jo=C3=A3o said "Eglot is, by design, only for LSP nor for extensions = to > the protocol." I see the logic in Jo=C3=A3o's arguments for wanting to limit eglot.el to t= he LSP standard only. But then the natural question is: where does functionality covering LSP extensions belong? One option is to have separate packages for every LSP extension out there, or indeed a catch-all like eglot-x.el. Maybe this is okay. However, does Eglot's design goals really mean that we will _never_ want these features in Emacs core? I'm not so sure. This is why I'm proposing to submit the new clangd-inactive-regions package to GNU ELPA instead. That way we could more easily integrate this into Emacs later (i.e. without having to worry about copyright assignments). We would still need to figure some things out, of course, such as where this functionality goes: to some new `eglot-extras.el', to various major modes, or what. Regarding eglot-x.el, of which you Felician seems to be the only major contributor, I would actually say the exact same thing. Why isn't this package on GNU ELPA? I suggest that you to submit it. :-) I'm copying in Jo=C3=A3o, in case he has anything to add here.