From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot Date: Mon, 12 Dec 2022 13:52:06 -0800 Message-ID: References: <167080394233.4339.5863353994038854528@vcs2.savannah.gnu.org> <20221212001223.E9A9DC004BE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14287"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 12 22:53:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4qjN-0003bi-G1 for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Dec 2022 22:53:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4qiZ-00037H-MU; Mon, 12 Dec 2022 16:52:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4qiY-00036r-LM for emacs-devel@gnu.org; Mon, 12 Dec 2022 16:52:10 -0500 Original-Received: from mail-oa1-x34.google.com ([2001:4860:4864:20::34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4qiX-0002q7-36 for emacs-devel@gnu.org; Mon, 12 Dec 2022 16:52:10 -0500 Original-Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-12c8312131fso10188318fac.4 for ; Mon, 12 Dec 2022 13:52:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=heAmOky+r92sgW0HqF7g6+2V6sxOIONI4zcnJYP23EQ=; b=JsJ2ldOTjUZvWHkaYEqrZ9ll2XsAnIJoEWkgO/S5UrbMpPVDq3jSrBcbqLK6EzDUn7 yHjMJ+XcF+RcPbiK/PNgp59Cjz1GO3xreEACTx0M9thlFMFgLkFNcSynvhYQ/ItYiRrJ QbCF3J1SFVcfB9Z+eCQXK0V7YmhzXetTAbKP9M62VZxaDJgiaayVKcq3QIj69tPqWquB SdO3vx6x5aQzkVZ1vgRrKAlEfqo4GJT3+tfJmoCICTzDjiT+qXSHri/jxUn+zsBBuSxn IMF+Wfrt9W3qrzFnneLWToE6k/XqPRA/ODnMP5QXXIebE3QYL36be8IjCKCfuWpSD3mn PzjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=heAmOky+r92sgW0HqF7g6+2V6sxOIONI4zcnJYP23EQ=; b=eUhv5sQcBP+gumBPTTqikGBDnYjAUWnjI3OnsbJ2LqT0SF51Bo3+D0XT7+cpr4TTf+ dNb4WgPNHrwudgSYm52dHuyLgF6yV7zsGaHRp+nKkxLTFFxVk1q0JwBpDKkqLJZQsOFu 9CWrH+zgOUzUFzJgBrXDftOAmsf9rrOaFWnBnRo0qRR62Rx3hsgpJvLm9Iasr+XswcIL fKFSLj3xsTUq2CH2LpIr7ryUjyhqsmGMhhFLQo/raTjCx9ypf23ezQU4TFzipyDZvlYv 5mT2r7g3cF31Aap7WHAFQsTZCcfTyx+RzTrvuEKQ9xTMTWdP6rpbElAe+52cQ1ArJ7Fn Dk4Q== X-Gm-Message-State: ANoB5plBUBEWgb2cEEG7M+mRKqiuyxLWFR5Xzxqb/nQuXbXt2KLuiedp uDbSpdVURY8vhg/+W3R61uM+XYQgXb2L2p6+h/k= X-Google-Smtp-Source: AA0mqf6W1Gq6I7ne0pwfwLVCu76E9ZjN9m1EGZ9Q67paOtAtJTMAQj4wPWlEfFD2IGXGUZekr1pTDYZwlCQNOqqwQF0= X-Received: by 2002:a05:6871:4586:b0:148:28c1:3d46 with SMTP id nl6-20020a056871458600b0014828c13d46mr43082oab.199.1670881926983; Mon, 12 Dec 2022 13:52:06 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 12 Dec 2022 13:52:06 -0800 In-Reply-To: X-Hashcash: 1:20:221212:emacs-devel@gnu.org::4L4BOFNtBx0JFsXf:1to1 Received-SPF: pass client-ip=2001:4860:4864:20::34; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x34.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301283 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > I think the extra predicates you suggest are fine, > feel free to push the changes. Thanks, done. > Maybe also adjust the autopep8 test expectation > to match your result. Or maybe write the reformat > test using something stabler, like "clangd" if you have it. I changed it to accept both the new and the old output. > As for the :expensive, what do you think makes a test > expensive. The longest-running tests in my machine > take less than 3 seconds. But I'm not running the > jtdls one (and I seem to remember that takes a bit > more time). So here, too, fell free to add :expensive > tags to those tests. I'd basically consider any test over half a second or a second or so as a candidate for being marked as :expensive. But we should do it judiciously, of course. (And even better if we can find a way to make slow tests faster.) Below are the tests that take more than 1 second on my slow machine. Perhaps `javascript-basic' is both unimportant and slow enough to be worth changing to :expensive? Maybe some others too; I don't know. passed 1/50 auto-detect-running-server (2.753144 sec) passed 2/50 auto-reconnect (2.349814 sec) FAILED 4/50 basic-completions (10.155676 sec) at lisp/progmodes/eglot-tests.el:522 passed 6/50 basic-xref (4.709764 sec) passed 12/50 eglot--tramp-test (2.158451 sec) passed 17/50 eglot-eldoc-after-completions (5.457839 sec) passed 20/50 eglot-multiline-eldoc (2.512865 sec) passed 32/50 eglot-single-line-eldoc (5.273028 sec) -> passed 34/50 javascript-basic (5.474341 sec) passed 36/50 non-unique-completions (3.871629 sec) passed 38/50 project-wide-diagnostics-typescript (2.126554 sec) FAILED 39/50 python-autopep-formatting (1.370773 sec) at lisp/progmodes/eglot-tests.el:659 passed 45/50 slow-async-connection (2.220646 sec) passed 46/50 slow-sync-connection-intime (1.153952 sec) passed 47/50 slow-sync-connection-wait (1.158264 sec) passed 48/50 slow-sync-timeout (1.130622 sec)