From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation. Date: Mon, 3 May 2021 10:43:29 -0500 Message-ID: References: <87a6pcqy7s.fsf@red-bean.com> <83czu86o46.fsf@gnu.org> <835z006jpl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33396"; mail-complaints-to="usenet@ciao.gmane.io" Cc: kfogel@red-bean.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 03 17:44:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldajy-0008ZA-Ly for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 17:44:10 +0200 Original-Received: from localhost ([::1]:58892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldajx-0006kV-Q3 for ged-emacs-devel@m.gmane-mx.org; Mon, 03 May 2021 11:44:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldajO-0006Fu-77 for emacs-devel@gnu.org; Mon, 03 May 2021 11:43:34 -0400 Original-Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:37710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ldajM-00048u-5y; Mon, 03 May 2021 11:43:33 -0400 Original-Received: by mail-pg1-x535.google.com with SMTP id d29so3117814pgd.4; Mon, 03 May 2021 08:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=KjQIroAIgZTM8lAZ4/kAYGR2Y7ZM9aX+1yEk2xvCYxs=; b=ckJ6Nua+6pJfeu8MUEvsr0QnjR1lymcT1FPJBrw0Ao4gIHuoDqK3XPTSQNn4OfIFRJ ys2r93KKv26NudDr7978PtDOIjUTgdEdlL1Xnk7DL1AKY6sG1DjEb0UfgJ4hQoLLx98U oLifBKNyUnFzxSafJKnwKt8Lln2EbNWl8W3WiVXUUlOLvMhTQWEGEklHok6Tx/VG6eaH k9bBPQ/yU4b+nqh6IMIJsNRh4PjV0NF67V7xfjyYme/9Dr8dYoGDk8idwJkptnFrXVd2 a0J207RkJT3Y4NjFS3BiweWO3kcYxJng75iTHrNnC7HODiTrZBM3crTTNj5ZrVJM9jPV WAWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=KjQIroAIgZTM8lAZ4/kAYGR2Y7ZM9aX+1yEk2xvCYxs=; b=JKJoVmdRk+77TFgqneOEYfC30FoFQJieB4cdjrwgRg78WD/ZlaCiULNzEl0APAMCUR iCGW2FoMZco6vd7zgoYZZ6P+wtIrrznyloTiAXsGtI/nobsNuUpZUwSf1ALbPxCi01sG 0FVV5olf7wl8fVV5nZgHoGEikZb0G/RFQQ3Mp4m/aL+6br0JwNh+JoKhC5farApcfHVY qjlIbaz4Y18wNBFmAsmi4GGcNMGrcO5uIEvcwNRZpbZk/nODKnFDQ/jPGawNraYK6P9A lSgugm+epn2dTBBAxS2mRkpv2/+TzuC6GEWuaj7fjEPRl1S7OrZByoNpw7n98Og71pHP Q7eA== X-Gm-Message-State: AOAM532gFdvzhHLYIExSrmyoo0D3mMQf/T12StSHCP7bsgC8fxZbEnAu YVd4QOSgPrO4CM/7UF9cZjJwDL8AoxRg6KokyhNvq6WT X-Google-Smtp-Source: ABdhPJypJDuwliF7xua/ULuzKG3bvB2Y6avPRJ/1n200Oz5lXYxmIXfoRkAVH3ObV4Xi9r+tSh2FIhtNzLNYrY1VegU= X-Received: by 2002:a65:6386:: with SMTP id h6mr16968819pgv.67.1620056610121; Mon, 03 May 2021 08:43:30 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 May 2021 10:43:29 -0500 In-Reply-To: <835z006jpl.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=stefankangas@gmail.com; helo=mail-pg1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268820 Archived-At: Eli Zaretskii writes: >> I don't see how backwards-compatibility is relevant here, but perhaps >> you could provide more specifics. > > We are now asking for confirmation where previously no question was > asked, or am I missing something? My point is that backwards compatibility is not necessarily the most important consideration in this case, and that such a stance would at least need some elaborating. AFAICT, we routinely make "backward incompatible" changes where we see a need for it. (But of course we do them with care and consideration.) Luckily, you provided your reasoning below: > Questions that pop where previously Emacs did something silently can > be annoying, which is why I'd prefer to turn this off by default. If > someone wants the new behavior, they can enable it. That's fair enough. To me, the danger of accidentally deleting a bookmarks still seems more important. On the one hand, we have lived with that for a long time, OTOH that is no reason not to try to do better.