From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0e56883: Move undocumented time-stamp formats closer to format-time-string Date: Wed, 9 Oct 2019 14:51:12 +0200 Message-ID: References: <20191001032457.2675.32057@vcs0.savannah.gnu.org> <20191001032458.E3A4D207F5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="209191"; mail-complaints-to="usenet@blaine.gmane.org" To: Stephen Gildea , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 09 19:59:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIGFa-000sII-CS for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 19:59:50 +0200 Original-Received: from localhost ([::1]:53434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIGFY-0002W2-7p for ged-emacs-devel@m.gmane.org; Wed, 09 Oct 2019 13:59:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43077) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIBR8-00080N-JF for emacs-devel@gnu.org; Wed, 09 Oct 2019 08:51:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIBR7-0008P6-Hm for emacs-devel@gnu.org; Wed, 09 Oct 2019 08:51:26 -0400 Original-Received: from mail-pf1-f173.google.com ([209.85.210.173]:36335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIBR7-0008Oo-Cu for emacs-devel@gnu.org; Wed, 09 Oct 2019 08:51:25 -0400 Original-Received: by mail-pf1-f173.google.com with SMTP id y22so1585084pfr.3 for ; Wed, 09 Oct 2019 05:51:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Q3JYtvYpRxkwjljinUfXZGq/aheptDzKFrGhVOvcFzw=; b=H6h5Uffj2U0u+OSwkl+BV5VEejAT6KLl4Uq4ab24dyuItpPsgY765TuZ1hUsh7L6q7 e/4LH9DXp37i3G8wMDKPrUTlYtzEic6+6NgZy8041ivSC5WW4l++EoyzAFNMLpiUuadT nHigigYjzT5gHzyFweTSr97UO/FZxk71DKW3fNUeFb580hbx8dzzthRUuwTxjtQvP2et zfsv05CkHy8LJEgOV/HAIFvTrL1/tFoVVj8XBSj094U/RyitFPyUybPp/MQb6eGku0WG LWMQYnW6bIS4QGuOg82PGMD0GtQfKuhhXMNI7TFlFPI24lB6ZuNM/0APEEZS2r3BvWzs QG1Q== X-Gm-Message-State: APjAAAUeZzuUHG9gpY0zrIAd+Ts2D+PRKz3ZIF8E9C5xwWOZnjecYhCH aYek2vGi6hvsNn2VoR0+opAkNnGgqsrmfkQ9YbXX2Odm X-Google-Smtp-Source: APXvYqw8I1CboreXkDizjG7T+XSVU75wx/G+wComnlMpPyxgAK133nXRvNtIuKRvlwd/4SDmEPB/0+INcN+EOm1D0dE= X-Received: by 2002:a62:8305:: with SMTP id h5mr3527072pfe.190.1570625484163; Wed, 09 Oct 2019 05:51:24 -0700 (PDT) In-Reply-To: <20191001032458.E3A4D207F5@vcs0.savannah.gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.210.173 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240775 Archived-At: Stephen Gildea writes: > branch: master > commit 0e568838781a4a5f2970bff6245c4e41f31612cc > Author: Stephen Gildea > Commit: Stephen Gildea > > Move undocumented time-stamp formats closer to format-time-string > > * time-stamp.el (time-stamp-string-preprocess): Update some undocumented > formatting characters of time-stamp format for closer (still incomplete) > alignment with format-time-string. They have displayed a warning since > Emacs 20 (released in 1997), so it is unlikely anyone is using them. > > * time-stamp-tests.el: Update tests to match new expectations. This commit gives test failures on macOS: Test time-stamp-test-time-zone backtrace: signal(ert-test-failed (((should (equal (time-stamp-string "%z" ref- ert-fail(((should (equal (time-stamp-string "%z" ref-time) "gmt")) : #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name time-stamp-test-time-zone :documentat ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/time-stamp-tests" "- command-line() normal-top-level() Test time-stamp-test-time-zone condition: (ert-test-failed ((should (equal (time-stamp-string "%z" ref-time) "gmt")) :form (equal "utc" "gmt") :value nil :explanation (array-elt 0 (different-atoms (117 "#x75" "?u") (103 "#x67" "?g"))))) FAILED 19/20 time-stamp-test-time-zone (0.000110 sec) passed 20/20 time-stamp-test-year (0.000182 sec) Ran 20 tests, 19 results as expected, 1 unexpected (2019-10-09 14:35:26+0200, 0.145782 sec) 1 unexpected results: FAILED time-stamp-test-time-zone Best regards, Stefan Kangas