From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Consistent face for keys in *Help* and `substitute-command-keys' Date: Thu, 25 Feb 2021 13:47:07 -0600 Message-ID: References: <87h7m5iagw.fsf@gnus.org> <83blc9tnvz.fsf@gnu.org> <83y2fcrzkt.fsf@gnu.org> <831rd4romg.fsf@gnu.org> <83zgzsq7xn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16694"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 25 20:49:43 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFMdq-0004Fh-Gb for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Feb 2021 20:49:42 +0100 Original-Received: from localhost ([::1]:58774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFMdp-0007gU-Jy for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Feb 2021 14:49:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFMbP-0005zd-Qs for emacs-devel@gnu.org; Thu, 25 Feb 2021 14:47:14 -0500 Original-Received: from mail-pf1-f179.google.com ([209.85.210.179]:44134) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFMbO-00055O-4D; Thu, 25 Feb 2021 14:47:11 -0500 Original-Received: by mail-pf1-f179.google.com with SMTP id t29so4302132pfg.11; Thu, 25 Feb 2021 11:47:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=keWLKV/m45pv6IwV0igV6H3n0kdSNd62SnnBZfHZO8A=; b=SXePGkL4xzZAQONUkbQyJco5uxFLhRZ4OoHk9QXmTzEENoUQp2n4wruhr8Q6jS773D 7NzhlQZ8wuUolRT9QXJexWbpXSsk2ItJyOs1hW8p7llKeFCXRcDaE/7Lkmv8vVxATadX 73/jrtSKhqfG1m7mkb98MxOsAUXVExS8fLHWbuS6J9XoUF58fJYkqyZf1ZTWLQtYUJ/I pwUYokXgjyxF54Tgsw4diVZvZ/efRlrraTUZ/B+lgMfNQlPmQzqHw3CHxalZUF8zP/P8 m0HDBZsbXxoCBWIV7CYMWuMellByeq5pXQ1B3QidTfTdJ4MhUDHpufKw/t0pTlGXcWzH QSWw== X-Gm-Message-State: AOAM530v5hSHcI78B5EQb4OCyHLfSonCpa2AVQbXxBk0Ep+/bxAuqKQ2 48HolZuSFdbK0F/oG8fIdTfOtesWoY1VypChhDj7oYdh X-Google-Smtp-Source: ABdhPJxcKrLsmAoQElISebRMmR9XxtwExI0K/aebsuAZRLcjWZfVpAsuYklPXSLY536BK0OkLbo/ww7p1jjUaafLDrU= X-Received: by 2002:aa7:8384:0:b029:1ed:1317:fbe4 with SMTP id u4-20020aa783840000b02901ed1317fbe4mr4744310pfm.57.1614282427907; Thu, 25 Feb 2021 11:47:07 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 25 Feb 2021 13:47:07 -0600 In-Reply-To: <83zgzsq7xn.fsf@gnu.org> Received-SPF: pass client-ip=209.85.210.179; envelope-from=stefankangas@gmail.com; helo=mail-pf1-f179.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265648 Archived-At: Eli Zaretskii writes: > Ah, okay: you are putting the 'face' property, but so does > 'tooltip-show'. So yes, the latter one overrides the former one. > > So I guess we will need to change the design of this to avoid > overriding the whole face of a tooltip, or maybe add some special code > to help_echo_substitute_command_keys. Oh, okay. I actually thought your concern was the opposite case here. I think it is okay that tooltips do not use the `help-key-binding' face. That seems in line with what other software does for tooltips, I believe. But I could be wrong.