From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 2772ebe366: Do not prune native-compiled system directories (bug#59658) Date: Wed, 30 Nov 2022 09:34:58 -0800 Message-ID: References: <166965402487.18442.18379860639913355185@vcs2.savannah.gnu.org> <20221128164705.366A7C004B6@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35446"; mail-complaints-to="usenet@ciao.gmane.io" To: Juanma Barranquero , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 30 18:35:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0R01-0008y2-FD for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Nov 2022 18:35:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0QzK-0007QV-5H; Wed, 30 Nov 2022 12:35:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0QzI-0007QM-Mh for emacs-devel@gnu.org; Wed, 30 Nov 2022 12:35:12 -0500 Original-Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0QzG-0002Hh-3p for emacs-devel@gnu.org; Wed, 30 Nov 2022 12:35:12 -0500 Original-Received: by mail-ot1-x330.google.com with SMTP id w26-20020a056830061a00b0066c320f5b49so11674482oti.5 for ; Wed, 30 Nov 2022 09:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=n/UIH47qn3EywwkTbgkQ669w6V0py8D1e3igXkpBYeQ=; b=F5MIQez41HOUGihxwjzDIc8E+qB6iUIUqkK3TdQTOKCbazHItoE55OIWhbXBf31nM2 iM43/VGxqhxsYqXwI1pzCHa8S+96ZC2u/KGPk7+vfClrR8RUaN38CX+QgnFhQXjlcx2K 0uqLPDPItMqSu3cyDvzpxuPW1hX5YDct1txDpllBFuKcf2HtHAswOppUKm23rqHC/C8L Wup6AsNUcTycsi1fkvaxyX04Yhoe69A7SmW74HLG4KeoDHLN/IrDu3/nTjChC40tyaLj xYuBNEsUBW5bxjNE241vyJ3MnfwPci3eQRn9EKnoUX+Y9VxRt8V+IPMWy/fdIes11D3e ANyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=n/UIH47qn3EywwkTbgkQ669w6V0py8D1e3igXkpBYeQ=; b=MJe0UWqVZslMn5NOB5HNtXj+9MB0iYtGeSiVOKGeZxMgzEq1pktFA0Vhxe9YyIYDoV t8llgvaQGpauUQRVohig3M3Qw1ZBDsXPtIfRrc2dH2UnyJ+sOGDgt/eWUEmr03Gi+VEI eYChOSCZENiidCfFZBo72R+EI7h2Awj/ZytvxSGzvBzVy+6S00fz/juXQxTRpSAop9zs ufYueN6APbUKUgxAXtoqLL+hWmJK5JZKjVHXSCJVPa+iIQkYCTl2hAzo4UuIo/4h0HyW 6Di6k3Ay0ZuDYukFG9IDzlmLbjFtb7Bf55rvtomAzZbu+jZ70oSr6YztrFipvku4CeMI J6iA== X-Gm-Message-State: ANoB5pnOalkbbHvQ+86sKxme4+jE2pigWFtmUkp5O6vh3gjFarBkr1+C KCgSgoUJx5kTQjVtTC7zdjekFpgwIsZc4U73RJKy/nHP X-Google-Smtp-Source: AA0mqf4XO97hCyai49AIPVMz8raHX2SCZyUQbYLuvxT1CBukKRUOk2KOwss6Ja0zb2XULo618DzcWIR3SkG9RmvpGL8= X-Received: by 2002:a9d:5c81:0:b0:661:c48b:12db with SMTP id a1-20020a9d5c81000000b00661c48b12dbmr21874555oti.105.1669829699097; Wed, 30 Nov 2022 09:34:59 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 30 Nov 2022 09:34:58 -0800 In-Reply-To: <20221128164705.366A7C004B6@vcs2.savannah.gnu.org> X-Hashcash: 1:20:221130:emacs-devel@gnu.org::GhiSxm1k8xoNNnKB:2EYs Received-SPF: pass client-ip=2607:f8b0:4864:20::330; envelope-from=stefankangas@gmail.com; helo=mail-ot1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300777 Archived-At: Juanma Barranquero writes: > branch: master > commit 2772ebe3667f28cefd0d6134204ce6a3c7a8c323 > Author: Juanma Barranquero > Commit: Juanma Barranquero > > Do not prune native-compiled system directories (bug#59658) > > * lisp/emacs-lisp/comp.el (native-compile-prune-cache): > Skip last directory in `native-comp-eln-load-path'. It seems like this leads to a failing test: Running 3 tests (2022-11-30 18:26:07+0100, selector =E2=80=98(not (or (tag :expensive-test) (tag :unstable)))=E2=80=99) Cache cleared Test test-native-compile-prune-cache backtrace: signal(ert-test-failed (((should-not (file-directory-p c2)) :form (f ert-fail(((should-not (file-directory-p c2)) :form (file-directory-p #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name test-native-compile-prune-cache :docu ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/comp-test command-line() normal-top-level() Test test-native-compile-prune-cache condition: (ert-test-failed ((should-not (file-directory-p c2)) :form (file-directory-p "/tmp/emacs-test-MHYUZK-comp/eln-cache/29.0.50-old"= ) :value t)) FAILED 1/3 test-native-compile-prune-cache (0.003363 sec) at lisp/emacs-lisp/comp-tests.el:46 Cache cleared passed 2/3 test-native-compile-prune-cache/delete-only-eln (0.002607 s= ec) Cache cleared passed 3/3 test-native-compile-prune-cache/dont-delete-in-parent-of-cache (0.002566 sec) Ran 3 tests, 2 results as expected, 1 unexpected (2022-11-30 18:26:07+0100, 0.132447 sec) 1 unexpected results: FAILED test-native-compile-prune-cache make[3]: *** [Makefile:174: lisp/emacs-lisp/comp-tests.log] Error 1