From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Merging scratch/substitute-command-keys to master Date: Sun, 18 Oct 2020 09:11:41 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36260"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 18 18:19:27 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUBP5-0009MF-As for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Oct 2020 18:19:27 +0200 Original-Received: from localhost ([::1]:58104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUBP4-0000Rb-ED for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Oct 2020 12:19:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUBHd-0008Ku-Ol for emacs-devel@gnu.org; Sun, 18 Oct 2020 12:11:45 -0400 Original-Received: from mail-ed1-f54.google.com ([209.85.208.54]:39948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUBHb-0005wZ-Vl for emacs-devel@gnu.org; Sun, 18 Oct 2020 12:11:45 -0400 Original-Received: by mail-ed1-f54.google.com with SMTP id p13so7754847edi.7 for ; Sun, 18 Oct 2020 09:11:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=ES+6ji/mpFJGT8o3i4gQD8j24ETpjvhI8ai66sxtLyw=; b=sbIHauVDiKMGQwj4gK7uksQKUzN4f8aoWftfTEt4t0njs+a2PCLtbsAfAZC7tWFIJM QNPeipvcNxvtaoHQI5fD+EzVs1sGT6z3huS3YkBBqRj6ntgIptKdnNM4ptXzXtDm+Kzf ZI4TARR+vt5OuVH81pUOF8SggMyEhB8cv/Ye6DNmBVFrhjMEfocG5C/taTPCX+jHh6yh 25kvpybCLRtN8LTnggWG5FDdfGf3DpPdqDDPe7LUSgCKR9HSNFV+r6rzUoVZQOwghJGw InTdXCBmCwDhI8SV0525TVF7ZyDPhBuKg0+6TKiDUwfufsbxM+Wiq4wgZHlDSWccs58J 3fkg== X-Gm-Message-State: AOAM530WdWjHMBmVMQjygeblzXI+eGgo4t94666EWPFgPtb1OnhmLT5Z 8KnfoS/G9SmrAyOXKUnj5rJN2kGZXZFgk04xkoI= X-Google-Smtp-Source: ABdhPJwM0JCeTsR7i65bjv1xxTAxlqNg91Cyy84taSKo10kXUI1V3VQpTHKYYoZZIli82sDlZqMeGLf/vMOWSCl03Nc= X-Received: by 2002:aa7:c259:: with SMTP id y25mr13795325edo.249.1603037502443; Sun, 18 Oct 2020 09:11:42 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 18 Oct 2020 09:11:41 -0700 In-Reply-To: Received-SPF: pass client-ip=209.85.208.54; envelope-from=stefankangas@gmail.com; helo=mail-ed1-f54.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/18 12:11:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258044 Archived-At: Stefan Kangas writes: >> See comments below. Other than those details, LGTM, > > I've fixed all your comments unless indicated otherwise below. I'm > currently working on cleaning up the history of the branch and will push > a new version of the branch, that I then plan to merge to the master > branch. I've now pushed a (hopefully) final version of the branch to scratch/substitute-command-keys, fixing Stefan M's comments, rebased on top of current master and with the old C code finally removed.