From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Patch to vertically center line content when using line-spacing variable Date: Sun, 1 Sep 2019 00:36:13 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="66350"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Jesse Medeiros Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 01 00:37:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i4C08-000H93-GD for ged-emacs-devel@m.gmane.org; Sun, 01 Sep 2019 00:37:44 +0200 Original-Received: from localhost ([::1]:46592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4C06-0002eK-NL for ged-emacs-devel@m.gmane.org; Sat, 31 Aug 2019 18:37:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48740) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4Byu-0002eB-Ja for emacs-devel@gnu.org; Sat, 31 Aug 2019 18:36:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4Byt-0002zS-HH for emacs-devel@gnu.org; Sat, 31 Aug 2019 18:36:28 -0400 Original-Received: from mail-pf1-f178.google.com ([209.85.210.178]:37385) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i4Byt-0002uZ-9t for emacs-devel@gnu.org; Sat, 31 Aug 2019 18:36:27 -0400 Original-Received: by mail-pf1-f178.google.com with SMTP id y9so6761807pfl.4 for ; Sat, 31 Aug 2019 15:36:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ce0GaAILjkkSUYQ+RsSCuFn1nCDSaF0+zmwmt2cqVTg=; b=MNfWX54mNf1XP2ie+K3KFLgh1tkTQt9sixHcJE6cOrVVA+H6RHUSdL6ZLonndfRDxh cS1Dvi0USoZ5sAXOQSntUnC5pSoE24rR5K6NnaGgtDOKryouhYI9HNFHY81DTtjp5AoE idrbymmQBMRSKK73U4ZsHvcABUOj/RYPRvPPGfbWMV+Fxhk56hRKXGONtRUXllt744y8 ctGgBhoLEHE/q65fjrIZndpT15I1Ddvrx537NhrTKbtBKVy3y1kSaRzg6M6siUzSMBul mcsn1zDglTlbIhjW71eaXfcu12LNfBE0TCIUeTC8d8f0OAG2UHEAg1MrDY5Frk9eSF/k 55IA== X-Gm-Message-State: APjAAAVVombKnWfR3DM0/P4VbMIsSKVJ2oPBmW+teFX6zw1YHxe2zKGV 6Vja+Vhcio+FNn8hwWG1pIFtujbyyM3gmt0sDUs= X-Google-Smtp-Source: APXvYqzU+wqbjG7UcLyMO55hIkzHCDeE9Hw0abnrluw8Y64RywauMxGFlfa79HFrvvRagPVBPR9R/yxTuWsnJ5DwU3s= X-Received: by 2002:a17:90a:17ab:: with SMTP id q40mr5910340pja.106.1567290984807; Sat, 31 Aug 2019 15:36:24 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.210.178 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239736 Archived-At: Jesse Medeiros : > Here's the link for the patch: > > https://github.com/sollidsnake/emacs/commit/aff5c59d10001e1161884ef3d0725eda86fa3ea0 Hi Jesse, Thanks, and welcome to Emacs. The preferred format for patches is to have a commit message in the form of a ChangeLog entry, and to send it as an attached file produced with e.g. "git format-patch -1". If you could re-send your patch in that format, it would help others to review your changes. You can find the details in the CONTRIBUTE file in the source repository. One tip is also to have a look at the git log to see how others have formatted their commit messages. Best regards, Sefan Kangas