From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Proposal for an improved `help-for-help' Date: Sun, 2 May 2021 05:23:15 -0500 Message-ID: References: <838s7hxqkr.fsf@gnu.org> <1c2c69f9-f42e-45e2-ab0e-8506aa859f85@yandex.ru> <8335ven7tu.fsf@gnu.org> <6654ddbe-0f1b-f36e-26f2-f4ee178b12ac@yandex.ru> <83sg3elkdz.fsf@gnu.org> <283b4718-88eb-b63a-ce0b-316e4def4ff3@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3867"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Gutov , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 02 12:28:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ld9LC-0000uf-1B for ged-emacs-devel@m.gmane-mx.org; Sun, 02 May 2021 12:28:46 +0200 Original-Received: from localhost ([::1]:33212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ld9L7-0005EG-8x for ged-emacs-devel@m.gmane-mx.org; Sun, 02 May 2021 06:28:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ld9Fw-0001fe-J3 for emacs-devel@gnu.org; Sun, 02 May 2021 06:23:20 -0400 Original-Received: from mail-pf1-f171.google.com ([209.85.210.171]:44832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ld9Fu-0006to-MT; Sun, 02 May 2021 06:23:19 -0400 Original-Received: by mail-pf1-f171.google.com with SMTP id m11so2143014pfc.11; Sun, 02 May 2021 03:23:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=oX8GZCGbJXc9opcKiZ0mciKj/eSeUp+08F7ZYwDda4s=; b=tuc9bvCqb6SFzQAOj6z0K7P52pzI5muc7bady2mBlLtoUQl0w0EVRJ8S5piF5/c1sz vBuQ/bR8BkCCUnxFrOywpIX7vxyLf9emMmUc2NsT9n7FYtEQPu2XuxU3mzppPieIICUV d3MWD4B+4S4jjpVxZMZHFgo8iBanSyVxfIqYol1NT2Qvsih4tmw/l2XQep3emtGc4rfq Z98BvnE/8eYmSzr3t/VlEPSldssNRGdx1OKjJAwsf1tbNOeNY+IHJuE3bzRxEbvRkhpT 6QafOiygnpLrB8MDkWUYAXxRzE7RaIPdhuyorbHpnATqoQE1jS9OBBx3W81YaGDn1NNa RYYQ== X-Gm-Message-State: AOAM531oFyjt3yK4IIbFKYj84nxhImfEias2tWZEGzvmuvkDq25WZoTb uh5ZVEbh4sQ7sEOMaXn4AUfKoxYnlK+/CsI8xas= X-Google-Smtp-Source: ABdhPJxJAoN82Zh7jdLs/oAI/IveRRwnrmn/Mh76GGJ/rFbBd4ztwM0mv6WIOwaE5tT9kneTf5H/crcWeX1AFeJYcEY= X-Received: by 2002:a63:5b5c:: with SMTP id l28mr13076064pgm.363.1619950996375; Sun, 02 May 2021 03:23:16 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 2 May 2021 05:23:15 -0500 In-Reply-To: Received-SPF: pass client-ip=209.85.210.171; envelope-from=stefankangas@gmail.com; helo=mail-pf1-f171.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268764 Archived-At: Dmitry Gutov writes: > So I think you just need to define that binding in the local map. The > below works for me (only in graphical Emacs, though). Actually, based on yours and Stefan M's comments, an even simpler patch worked here. So I have now installed it on master (commit fb44f897d9). Please verify that it works for you. (As usual, "touch lisp/help.el" first to make sure the macro is re-expanded.) diff --git a/lisp/help-macro.el b/lisp/help-macro.el index 132530deb3..9461579a99 100644 --- a/lisp/help-macro.el +++ b/lisp/help-macro.el @@ -142,7 +142,7 @@ make-help-screen (setq new-minor-mode-map-alist minor-mode-map-alist)) (goto-char (point-min)) (while (or (memq char (append help-event-list - (cons help-char '( ?? ?\C-v ?\s ?\177 deletechar backspace vertical-scroll-bar ?\M-v + (cons help-char '( ?? ?\C-v ?\s ?\177 deletechar backspace vertical-scroll-bar ?\M-v ?\S-\s next prior up down)))) (eq (car-safe char) 'switch-frame) (equal key "\M-v")) @@ -152,7 +152,7 @@ make-help-screen (handle-switch-frame char)) ((memq char '(?\C-v ?\s next)) (scroll-up)) - ((or (memq char '(?\177 ?\M-v deletechar backspace prior)) + ((or (memq char '(?\177 ?\M-v deletechar backspace prior ?\S-\s)) (equal key "\M-v")) (scroll-down)) ((memq char '(down))