From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Deleting old `:version` from defcustoms (was: master b76cdd0: Delete libraries obsolete since 23.1 and 23.2) Date: Sat, 16 May 2020 20:18:54 -0700 Message-ID: References: <20200515175844.18941.61355@vcs0.savannah.gnu.org> <20200515175845.997EC20999@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="25656"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 17 05:19:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ja9qC-0006aK-Pv for ged-emacs-devel@m.gmane-mx.org; Sun, 17 May 2020 05:19:52 +0200 Original-Received: from localhost ([::1]:45666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ja9qB-0002Ro-Sj for ged-emacs-devel@m.gmane-mx.org; Sat, 16 May 2020 23:19:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ja9pI-0001Z7-VT for emacs-devel@gnu.org; Sat, 16 May 2020 23:18:57 -0400 Original-Received: from mail-yb1-xb29.google.com ([2607:f8b0:4864:20::b29]:47038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ja9pI-0000Tw-68 for emacs-devel@gnu.org; Sat, 16 May 2020 23:18:56 -0400 Original-Received: by mail-yb1-xb29.google.com with SMTP id s37so3353480ybe.13 for ; Sat, 16 May 2020 20:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=EGLl8bXrF+yown5TUza0FFDSKf+kGQTXCQ1X0WY4KEA=; b=tUjHoW85I5ZyiafzpDNWMNVj101+PUnADArSQGHaeWC+QUZjmPV9mjDlItlgl9wcaE xPku79TzLzjet2e1RtF0dq8pXWqSgkfR95zUiqhAtzWcXpM4sMCRs5gGcY/kE3HfnkWI qt0cxE9lKUlAJDsJPypqt8QIbjQ+IZkVSLgljFPIHCCNqA9lG5FnfXS3BA1NjzSgE3MZ jK/1djoEI7yboyfxJmCFQM28R8cJR/kGTOL4ioPbXuCcpUHkDpWH1WgqM17A7PAY4QSb 6EGMNBynEj0hZKOuSDqeb6W9ODEYrGg3hm/LPEqGcKiyY5UP2tTTaqj6SgkGoTEq2AWt uG4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=EGLl8bXrF+yown5TUza0FFDSKf+kGQTXCQ1X0WY4KEA=; b=ehGlnYeGpouo6aMXUIR9ItutsXlvw+jKJ9MxrkS5G90/gKsDq45Ga4zysI+AXohUTl jIFBS5Oh+SOctUiFADGna2riGE/RPeWq2uj/+qj6/sZY94Tm6gLnDW7Ni69IOc9TX061 InfjzuXowa00XggtcZRkCA+46BqBmwrq4xJlFUCve5gu1xnblbD1vv7vBrB/pQrEWr/Z u4QndZLunwgapx3+HeZDBThyMxNo8H8JPjE7MIyRLrg1Qv89B8yngdQpPrbOJEspp9a3 8lcouFGwwWKkCtTQWKNpeBp0lf6p6558SPTKEX1V8fCNJzvhwoLYqoK2MywWG8xQXtse myhQ== X-Gm-Message-State: AOAM531uNkYmMaGkRzoUXEzTumG7OebfKyY4qs8s6YajSzNkAnJ1EHeA Wgw6CEldwCCa0RiArHY7ndnf9Nmpye/cyCW9Kyw= X-Google-Smtp-Source: ABdhPJyOJluJ68u2v1P/FFcoQVt0TG19B941aiZt/2IREYaDpNBPwntWmPu1gWaCOknHHwnbvNE5bSjL7QLgaU2k9PU= X-Received: by 2002:a25:6883:: with SMTP id d125mr18206491ybc.43.1589685535230; Sat, 16 May 2020 20:18:55 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 16 May 2020 20:18:54 -0700 In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b29; envelope-from=stefankangas@gmail.com; helo=mail-yb1-xb29.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250561 Archived-At: Stefan Monnier writes: > I did a quick `grep` to see the functions/vars that were obsoleted in > the same time frame, and I saw instead a deluge of > > :version "23.1" > > If we consider those thingies old enough to remove their obsolete > functions, shouldn't we also remove the corresponding `:version` > thingies from `defcustom`s? > > I see: > - 1 defcustom with a :version of 19.29 > - >200 defcustoms with a :version of 20.x > - a bit less than 200 defcustoms with a :version of 21.x > - >400 defcustoms with a :version of 22.x > - >200 defcustoms with a :version of 23.x I realize I don't fully understand the purpose of the :version declarations. If it's mostly to let users know what changed, they can probably be removed for these very old versions. But are they also intended to provide a historical record? If so, maybe they should be kept indefinitely. Best regards, Stefan Kangas