Re: master e90a457c46: * src/xrdb.c (main) [TESTRM]: Replace gets with fgets.

Re: master e90a457c46: * src/xrdb.c (main) [TESTRM]: Replace gets with fgets.

[Robert Pluim]

>>>>> On Thu,  8 Sep 2022 06:49:01 -0400 (EDT), Stefan Kangas <stefankangas@gmail.com> said:

    Stefan> branch: master
    Stefan> commit e90a457c46ca9463bf77cab2d34513c45269c938
    Stefan> Author: Stefan Kangas <stefankangas@gmail.com>
    Stefan> Commit: Stefan Kangas <stefankangas@gmail.com>

    Stefan>     * src/xrdb.c (main) [TESTRM]: Replace gets with fgets.
    Stefan> ---
    Stefan>  src/xrdb.c | 4 ++--
    Stefan>  1 file changed, 2 insertions(+), 2 deletions(-)

To be 100% PSIRT compliant you should check the return value of fgets
as well 😺

Robert
-- 

Re: master e90a457c46: * src/xrdb.c (main) [TESTRM]: Replace gets with fgets.

[Po Lu]

Stefan Kangas <stefankangas@gmail.com> writes:

> branch: master
> commit e90a457c46ca9463bf77cab2d34513c45269c938
> Author: Stefan Kangas <stefankangas@gmail.com>
> Commit: Stefan Kangas <stefankangas@gmail.com>
>
>     * src/xrdb.c (main) [TESTRM]: Replace gets with fgets.
> ---
>  src/xrdb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/xrdb.c b/src/xrdb.c
> index faeea04a53..5ff25dde14 100644
> --- a/src/xrdb.c
> +++ b/src/xrdb.c
> @@ -589,14 +589,14 @@ main (int argc, char **argv)
>        char query_class[90];
>  
>        printf ("Name: ");
> -      gets (query_name);
> +      fgets (query_name, 90, stdin);
>  
>        if (strlen (query_name))
>  	{
>  	  char *value;
>  
>  	  printf ("Class: ");
> -	  gets (query_class);
> +	  fgets (query_class, 90, stdin);
>  
>  	  value = x_get_string_resource (&xdb, query_name, query_class);
>  

TESTRM has not worked for a long time and relies on XLIB_ILLEGAL_ACCESS,
which is not okay to use anymore.

I would rather it be removed.

Re: master e90a457c46: * src/xrdb.c (main) [TESTRM]: Replace gets with fgets.

[Stefan Kangas]

Po Lu <luangruo@yahoo.com> writes:

> TESTRM has not worked for a long time and relies on XLIB_ILLEGAL_ACCESS,
> which is not okay to use anymore.
>
> I would rather it be removed.

Makes sense to me.

Re: master e90a457c46: * src/xrdb.c (main) [TESTRM]: Replace gets with fgets.

[Stefan Kangas]

Robert Pluim <rpluim@gmail.com> writes:

> To be 100% PSIRT compliant you should check the return value of fgets
> as well 😺

;-)

(Also, "gets" has been removed in C11.)