From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Should `revert-buffer' preserve text-scaling by default? Date: Sun, 1 Dec 2019 10:47:28 +0100 Message-ID: References: <87fti6toq7.fsf@red-bean.com> <83pnhao1re.fsf@gnu.org> <8736e6tm51.fsf@red-bean.com> <83imn1omkf.fsf@gnu.org> <87d0d8xxzu.fsf@red-bean.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95289"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Eli Zaretskii , Stefan Monnier , Emacs developers To: Karl Fogel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 01 10:48:14 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ibLpt-000Ofw-Kq for ged-emacs-devel@m.gmane.org; Sun, 01 Dec 2019 10:48:13 +0100 Original-Received: from localhost ([::1]:42142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibLpr-0006vz-S2 for ged-emacs-devel@m.gmane.org; Sun, 01 Dec 2019 04:48:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55941) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibLpP-0006vr-SP for emacs-devel@gnu.org; Sun, 01 Dec 2019 04:47:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibLpO-0003fd-Sj for emacs-devel@gnu.org; Sun, 01 Dec 2019 04:47:43 -0500 Original-Received: from mail-pg1-f170.google.com ([209.85.215.170]:38813) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibLpN-0003eA-Iq; Sun, 01 Dec 2019 04:47:41 -0500 Original-Received: by mail-pg1-f170.google.com with SMTP id t3so16407081pgl.5; Sun, 01 Dec 2019 01:47:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Pq7/S3QSin6YU5gaRbz6XEoL6CNnXAS5M2O0gFXIQSQ=; b=tEP8InQ6Vvu9XBZBqyDIqobp05oTUadtDSNW0lMfx23Pxl+Rzkldqlao1GFz0jOzUS LGDH5M4vywknrKbWseee0d+fwUtbMowbgknQYgOI6E8g6Nwga04yc4yEccttXJBN9JO+ 9OKSE6GlC4Cn8N/NmkUFlrbmQ/+KmEYkwRcnZW0lBsgHs7XejM9FFJcbcqNtVC6eUpiS YY9s3ZkEJznrdR/OT/5H/94bXeZJuLSlTnEbdmPBAi2FNifbpt+w3iTkibJ5b2lTEOsV ik5zph9l9c/owKkJD0G3r1a4owOUG8cH3WgJy8DvCHaF0S8uHaoc/7EsnjyZpeNd676h 2JQw== X-Gm-Message-State: APjAAAWIZP3EMuNWqMRWn481IgMzzZSKcDLsS0ovOxirUasspNk9OMyR s286oV1JoSR7Q+bscRIaYhZ2vt8YGB6qkmIbMfY= X-Google-Smtp-Source: APXvYqyqyXOWYARg22NVHWFjXvmF2vlBj/oH71SbwTfbWVILBKNcMEpeEI8A5/3Vp1P018qNO3ujQFVWFzZ9TQpgMmM= X-Received: by 2002:aa7:9295:: with SMTP id j21mr65083875pfa.50.1575193659921; Sun, 01 Dec 2019 01:47:39 -0800 (PST) In-Reply-To: <87d0d8xxzu.fsf@red-bean.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.215.170 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242945 Archived-At: Karl Fogel writes: > So going back to the previous proposal seems like the best approach, beca= use it allows us to change just the buggy behavior(s) and nothing else. To= reiterate: that proposal is to have a new list variable `revert-buffer-pre= served-modes', whose default value includes these modes: > > `text-scale-mode' > `display-line-numbers-mode' > `display-fill-column-indicator-mode' > `hl-line-mode' (maybe?) > > Over time we could adjust the default contents of this list, of course. > > I would also like to hear what others here think, both about the overall = idea and about what modes should be in that list. Since you are asking for opinions: The bug you originally mentioned with text-scale-mode and revert-buffer is incredibly frustrating. I incorrectly assumed there was a good reason for the behaviour, and never bothered looked into it. So thank you for doing that. I agree that all four modes above should stay enabled on revert-buffer, including hl-line-mode. Best regards, Stefan Kangas