From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Remove obsolete fast-lock and lazy-lock libraries Date: Sun, 9 Aug 2020 22:32:44 +0200 Message-ID: References: <20200809164058.GC26635@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38203"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Jeff Norden , Emacs developers To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 09 22:33:45 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4s0n-0009qu-21 for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Aug 2020 22:33:45 +0200 Original-Received: from localhost ([::1]:59070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4s0m-0007Os-1G for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Aug 2020 16:33:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4s02-0006tE-8q for emacs-devel@gnu.org; Sun, 09 Aug 2020 16:32:58 -0400 Original-Received: from mail-yb1-xb43.google.com ([2607:f8b0:4864:20::b43]:42821) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4s00-00083d-Iq for emacs-devel@gnu.org; Sun, 09 Aug 2020 16:32:58 -0400 Original-Received: by mail-yb1-xb43.google.com with SMTP id a34so4079952ybj.9 for ; Sun, 09 Aug 2020 13:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EpuvK1r5PJLzb7yVHG3ssDVJxAt2PYhwLudpQs26tu0=; b=Q46hCg6zAxbrwovdnLVkxFEFsrUA/va4+uRJugCfxn9+QYjjG80gR3Npu27kfwmRt0 KGCHGemEO+o7lFudG18A7VF/TChQo0+cwjVdQbcxVKB1Pl1lWlD/m1la0sIx7KQcWLhj vZBjqZxW+GH3VANYkTln1zA3Q2wSSgTnjTFwx9No+ucLhszvKuGinfTbMiKmr6F+JKBC c/M46H6CsCVz/XxTKVpR/IQfFQVA6IemtppX6DUynSal1F7ZIWoM4QYCa9d/XXVLTwao UxGtyAi/QaA/ufMJNPt7qMKKKtV3UcVpg0rGhn3Tdm2Um25caetGSBDZE9HOIEfsZhMO K12Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EpuvK1r5PJLzb7yVHG3ssDVJxAt2PYhwLudpQs26tu0=; b=nnmxs6u6nHyuYOVeJq8ksLFMpOMOzFcY9uLaqEW4tUthb4iPMLzx3U9BQkNox6x8S6 ieODrLN3Pz0KfMmJ6hu6h6XMXgU4o3oyFj8J2dCTDnlOo1B7G6XFLQj005tu/bwtVA9T G+/rMwRTbyCejnJe0oA9+EjLXq6FSiQiiwnOS1SdljbHMFWFIGrTBEmcAejFxoTiBiM5 pw64XuKaSN9b6NbZCTsA0OGYk0PvpuV/97ljoV4QKhQxSnDJgHs7jV74UG5BLEUoEG3G xlIecyWoorcpYn2gEWTWrhGVhGiz9DA9z71lGupG3/apj2Q2nMlctMayfQ9rIeEV8oZp AhNQ== X-Gm-Message-State: AOAM531g7n7nKkskWmLqp6yahMOHzTAp7HvccB0ywTe2PQCFIsVqQspE ARpYtkdwpLv10cekSTNvqjggDn4L5EffHXJPpxg= X-Google-Smtp-Source: ABdhPJycKJRe09YlYb+0CKqU2pG4BAbRIG+3HIXAKTTDsg7QmplD7/uys5w1U5X7wo861wf8Bi4bhadGBjI/e4S5Y6Y= X-Received: by 2002:a5b:508:: with SMTP id o8mr10133763ybp.43.1597005175342; Sun, 09 Aug 2020 13:32:55 -0700 (PDT) In-Reply-To: <20200809164058.GC26635@ACM> Received-SPF: pass client-ip=2607:f8b0:4864:20::b43; envelope-from=stefankangas@gmail.com; helo=mail-yb1-xb43.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253562 Archived-At: Hi Alan, Alan Mackenzie writes: > > > If someone has an ancient .emacs that contains > > > (setq font-lock-support-mode 'fast-lock-mode) > > > would the best thing be to just use jit-lock-mode instead? If I'm reading > > > the patch correctly, it would make setting the support-mode to fast-lock > > > equivalent to setting it to nil. > > > Sure, that makes sense. I could change that before pushing. > > This doesn't make sense, I think. font-lock-support-mode is a function, > and if a user has this set to a non-existent function, the correct > response is surely to tell her with an error message, rather than > executing a different function. Okay, that's a fair point. But if the user has set it to lazy-lock or fast-lock wouldn't the reason most likely be that it's expected to be better for normal use? And, if that holds, shouldn't we be a bit forthcoming by just using the current best, which is jit-lock? OTOH, I guess that for any other value it is probably best to signal an error rather than silently defaulting to nil. Still, I don't have any strong feelings either way. If the consensus is to signal an error for any other value than jit-lock and nil, I'm perfectly fine with that too. Best regards, Stefan Kangas