From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Sat, 16 Oct 2021 16:33:47 +0200 Message-ID: References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <871r4qcs8s.fsf@gnus.org> <87o87ubcnl.fsf@gnus.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <834k9km5no.fsf@gnu.org> <83k0iflsze.fsf@gnu.org> <874k9jzu7a.fsf@gnus.org> <874k9juy0r.fsf@gnus.org> <87mtnbtimj.fsf@gnus.org> <87wnmd13ny.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11934"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 16 16:34:39 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbkli-0002rY-Ni for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Oct 2021 16:34:38 +0200 Original-Received: from localhost ([::1]:56308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbklh-0000LM-R1 for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Oct 2021 10:34:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbkl8-0007qa-Ac for emacs-devel@gnu.org; Sat, 16 Oct 2021 10:34:02 -0400 Original-Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:41773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbkl6-00052q-QN for emacs-devel@gnu.org; Sat, 16 Oct 2021 10:34:01 -0400 Original-Received: by mail-pf1-x42c.google.com with SMTP id y7so10925324pfg.8 for ; Sat, 16 Oct 2021 07:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VFSHMQ8ruRGrfNl1obRf6jJ2+CBybJoxZ+cDvQHY/DE=; b=epAd652S89p7LU0GGbe8eEw0+6xVZaUBfouD6voXJSvNvFUE4ilcZrK8nDCMTiBX4b Zio57P1/5o/V3JqLnDXOdRp9PpD+Ibrrqn2jN04Vg34NJ5LUYwE0PDHPrDm1hC7OytM5 wFfkqL5OcW5OYbWHm8XZFmQwNGMTEVDNWPvql36vy/wQSjfJqHFbY2tJyU810xiGxeWh TZvaxmHSolHoVis2nWf+yqouJvFPCTELuzFJw6jQociU2IwKWDC4FJFd4Jvv6uK50FCn /lK4O8u+7QRpjKnOmWlAy9C/FAEQi+eCaiyNJcRbt2AzHxGqnQPkq0+A7ltu8aTGRiM7 mGNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VFSHMQ8ruRGrfNl1obRf6jJ2+CBybJoxZ+cDvQHY/DE=; b=Lnr8kQ1/RZsf6Hv0vQ6KkbGJFKiRneKaATYnE4zacC8SAhMqk/ehhIhaTUBy91T85n 3IguIFWXv2gRF2Jp0aozfZ1+OLPuJRz6dzsuLoYkdkbHCiwnlZLtCJVzxU6mo8te7ATf CC1adCcw46r5rLd0vpmekWPR3LOYuSR66/1IccbIjGdiWW4YERmn5oYktcp6PqRprMI1 2Dngpb8uRY/ugDyiML06mH7QMPZgfbonp8oQtTfewk60RBrUFoUEzgNl+WVPT0bj9jzi F0ZE7ET1qLoDtmJ0bXfnxZhK6RWh1oUxYALflBt7cgTXMNYDhzshpbcFPrEak828C5qO WxCQ== X-Gm-Message-State: AOAM53095pTnA7jVWyMNtsAHei5Q1/KAQQvOabLd50wBdKWw7ie2NXPt bHlEleToF815cnaH9qzpss7kNqdvv8n0NSA9ViUnm41Ra4Q= X-Google-Smtp-Source: ABdhPJyJUcpYcRC+o1jICo8XRJxpl1Evn/GclZnrdBt7oaRjxMCNSE3m6+8ntw4rRwz0NU24QHzD0lc+/zRCzZqcYHs= X-Received: by 2002:aa7:978b:0:b0:44c:abf1:a8b8 with SMTP id o11-20020aa7978b000000b0044cabf1a8b8mr18149388pfp.35.1634394839174; Sat, 16 Oct 2021 07:33:59 -0700 (PDT) In-Reply-To: <87wnmd13ny.fsf@gnus.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=stefankangas@gmail.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277179 Archived-At: Lars Ingebrigtsen writes: > Stefan, can you push the patch that moves kbd to subr.el to > master? Certainly. Now done in commit e082a16284 and 8ee63604e3. > If there's any further issues with simplifying the function, we > can look into that after the change is in-tree. We might as well fix the (<= 0 ch 127) bit, as I didn't do that in my patch. (I know there are different styles, but I personally often think it's nice to put such cleanups in their own commits to facilitate later bisecting.)