unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Florian Rommel <mail@florommel.de>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: [ELPA] New package: bufferlo
Date: Sat, 28 Oct 2023 08:21:31 -0700	[thread overview]
Message-ID: <CADwFkmmWa7b9eKnA7Vy1xjGsoiyi31LtwOLAueGB2SN+RexnOg@mail.gmail.com> (raw)
In-Reply-To: <8c3006d57a5c18905267adccfb04caf5ee1721ab.camel@florommel.de>

Florian Rommel <mail@florommel.de> writes:

> I propose the following package for inclusion in ELPA:
> https://github.com/florommel/bufferlo
>
> It provides additional separate buffer lists per frame and (tab-bar)
> tab and functions to manage them.
>
> Different from similar buffer-isolation solutions it supports tabs.
> It also integrates well with all the standard frame and tab management
> facilities and has support for persisting sessions via desktop.el.
>
> Thanks for your feedback.

Thanks, do you mean to add it to GNU ELPA?  If so, I see no reason why
we can't add it.  Please find some comments on your code below.

1. Here are some warnings from `package-lint':

6 issues found:

146:22: error: You should depend on (emacs "28.1") if you need `clone-frame'.
147:22: error: You should depend on (emacs "29.1") if you need `undelete-frame'.
166:21: error: You should depend on (emacs "28.1") if you need `clone-frame'.
167:21: error: You should depend on (emacs "29.1") if you need `undelete-frame'.
517:1: warning: `with-eval-after-load' is for use in configurations,
and should rarely be used in packages.
523:1: warning: `with-eval-after-load' is for use in configurations,
and should rarely be used in packages.

2. Here are some byte-compiler warnings:

Compiling file /Users/skangas/wip/bufferlo/bufferlo.el at Sat Oct 28
17:12:56 2023
bufferlo.el:518:26: Warning: reference to free variable
    ‘ibuffer-filtering-alist’
bufferlo.el:517:24: Warning: assignment to free variable
    ‘ibuffer-filtering-alist’
bufferlo.el:526:17: Warning: reference to free variable ‘ibuffer--filter-map’

In end of data:
bufferlo.el:527:19: Warning: the function
    ‘ibuffer-filter-by-bufferlo-local-buffers’ is not known to be defined.
bufferlo.el: Warning: the function ‘ibuffer-pop-filter’ is not known to be
    defined.
bufferlo.el: Warning: the function ‘ibuffer-update’ is not known to be
    defined.
bufferlo.el: Warning: the function ‘ibuffer-push-filter’ is not known to be
    defined.

3. You might want to consider running `M-x checkdoc' as well.

4. See the below diff with some stylistic improvements that I found
   while skimming the code:

diff --git a/bufferlo.el b/bufferlo.el
index 3bc92b5..daecb85 100644
--- a/bufferlo.el
+++ b/bufferlo.el
@@ -1,4 +1,5 @@
 ;;; bufferlo.el --- Manage frame/tab-local buffer lists -*-
lexical-binding: t -*-
+
 ;; Copyright (C) 2021-2023 Free Software Foundation, Inc.

 ;; Author: Florian Rommel <mail@florommel.de>
@@ -6,7 +7,7 @@
 ;; Url: https://github.com/florommel/bufferlo
 ;; Created: 2021-09-15
 ;; Version: 0.2
-;; Package-Requires: ((emacs "27.1"))
+;; Package-Requires: ((emacs "29.1"))
 ;; Keywords: buffer frame tabs local

 ;; This program is free software: you can redistribute it and/or modify
@@ -69,41 +70,36 @@ This is also required to make `next-buffer' and
`previous-buffer'
 work as expected.
 Changes to this variable must be made before enabling
 `bufferlo-mode' in order to take effect."
-  :group 'bufferlo
   :type 'boolean)

 (defcustom bufferlo-include-buried-buffers t
   "Include buried buffers in the local list (`bufferlo-buffer-list').
 Use `bufferlo-bury' to remove and bury a buffer if this is set to t."
-  :group 'bufferlo
   :type 'boolean)

 (defcustom bufferlo-include-buffer-filters nil
   "Buffers that should always get included in a new tab or frame.
 This is a list of regular expressions that match buffer names.
 This overrides buffers excluded by `bufferlo-exclude-buffer-filters.'"
-  :group 'bufferlo
   :type '(repeat string))

 (defcustom bufferlo-exclude-buffer-filters '(".*")
   "Buffers that should always get excluded in a new tab or frame.
 This is a list of regular expressions that match buffer names.
 Buffers included by `bufferlo-include-buffer-filters' take precedence."
-  :group 'bufferlo
   :type '(repeat string))

 (defcustom bufferlo-hidden-buffers nil
-  "Buffers that should be hidden in the local buffer lists,
-even if they are displayed in the current frame or tab.
-This is a list of regular expressions that match buffer names."
-  :group 'bufferlo
+  "List of regexps matching names of buffers to hide in the local buffer lists.
+They are hidden even if they are displayed in the current frame
+or tab.  This is a list of regular expressions that match buffer
+names."
   :type '(repeat string))

 (defcustom bufferlo-kill-buffers-exclude-filters
   '("\\` " "\\`\\*Messages\\*\\'" "\\`\\*scratch\\*\\'")
   "Buffers that should not be killed by `bufferlo-kill-buffers'.
 This is a list of regular expressions that match buffer names."
-  :group 'bufferlo
   :type '(repeat string))

 (defcustom bufferlo-ibuffer-bind-local-buffer-filter t



  reply	other threads:[~2023-10-28 15:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-22 19:50 [ELPA] New package: bufferlo Florian Rommel
2023-10-28 15:21 ` Stefan Kangas [this message]
2023-11-04 22:13   ` Florian Rommel
2023-11-05 14:32     ` Stefan Kangas
2023-11-05 14:47       ` Florian Rommel
2023-11-05 15:00         ` Stefan Kangas
2023-11-05 15:02           ` Florian Rommel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmmWa7b9eKnA7Vy1xjGsoiyi31LtwOLAueGB2SN+RexnOg@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=mail@florommel.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).