unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: emacs-30 21be5cadaf1: ; * lisp/subr.el (sha1): Fix typo in docstring.
       [not found] ` <20240819135103.DB903C2BC70@vcs2.savannah.gnu.org>
@ 2024-08-19 14:04   ` Pip Cet
  2024-08-20  2:04     ` Stefan Kangas
  0 siblings, 1 reply; 2+ messages in thread
From: Pip Cet @ 2024-08-19 14:04 UTC (permalink / raw)
  To: emacs-devel; +Cc: Ulrich M%c3�ller

Ulrich Müller <ulm@gentoo.org> writes:

> branch: emacs-30
> commit 21be5cadaf1e43cf886f38cb14fa25b96d8b551d
> Author: Ulrich Müller <ulm@gentoo.org>
> Commit: Ulrich Müller <ulm@gentoo.org>
>
>     ; * lisp/subr.el (sha1): Fix typo in docstring.
> ---
>  lisp/subr.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/subr.el b/lisp/subr.el
> index 31c53a6455b..a8e3df14cd3 100644
> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -4482,7 +4482,7 @@ Otherwise, return nil."
>  OBJECT is either a string or a buffer.  Optional arguments START and
>  END are character positions specifying which portion of OBJECT for
>  computing the hash.  If BINARY is non-nil, return a 40-byte unibyte
> -string; otherwise returna 40-character string.
> +string; otherwise return a 40-character string.

In my case, if BINARY is non-nil, a 20-byte unibyte string is returned,
which matches the 160 bits SHA-1 actually produces. Okay to fix that on
emacs-30, too?

Pip




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: emacs-30 21be5cadaf1: ; * lisp/subr.el (sha1): Fix typo in docstring.
  2024-08-19 14:04   ` emacs-30 21be5cadaf1: ; * lisp/subr.el (sha1): Fix typo in docstring Pip Cet
@ 2024-08-20  2:04     ` Stefan Kangas
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Kangas @ 2024-08-20  2:04 UTC (permalink / raw)
  To: Pip Cet, emacs-devel; +Cc: ulm

Pip Cet <pipcet@protonmail.com> writes:

> In my case, if BINARY is non-nil, a 20-byte unibyte string is returned,
> which matches the 160 bits SHA-1 actually produces. Okay to fix that on
> emacs-30, too?

Doc fixes are okay on emacs-30, yes.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-20  2:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <172407546333.11407.16261556590423762467@vcs2.savannah.gnu.org>
     [not found] ` <20240819135103.DB903C2BC70@vcs2.savannah.gnu.org>
2024-08-19 14:04   ` emacs-30 21be5cadaf1: ; * lisp/subr.el (sha1): Fix typo in docstring Pip Cet
2024-08-20  2:04     ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).