From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: having emacs-matlab in ELPA, finally. FSF paper signed Date: Sat, 23 Nov 2024 14:13:51 -0500 Message-ID: References: <871q37um8q.fsf@mat.ucm.es> <87v80cp8nx.fsf@mat.ucm.es> <877ccmkmwy.fsf@posteo.net> <87bk1y0wcm.fsf@mat.ucm.es> <87o75xkjpj.fsf@posteo.net> <874j3z8cy5.fsf@mat.ucm.es> <87ldxansy5.fsf@posteo.net> <87y11a13vx.fsf@mat.ucm.es> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37567"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , Andrea Corallo , emacs-devel@gnu.org To: Uwe Brauer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 23 20:14:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEvaA-0009bh-VF for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Nov 2024 20:14:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEvZt-0002gN-J5; Sat, 23 Nov 2024 14:13:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEvZr-0002fk-TD for emacs-devel@gnu.org; Sat, 23 Nov 2024 14:13:55 -0500 Original-Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEvZq-0003wS-B8; Sat, 23 Nov 2024 14:13:55 -0500 Original-Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-aa539d2b4b2so68407366b.1; Sat, 23 Nov 2024 11:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732389232; x=1732994032; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=uP8sm0BmUSXB0VQTeHnz/shWkT9DxzZuKdqp+9Ia1zs=; b=PafkLzkCnciZ6F4WWopv/A1VxWVBcTrBQ7kV6yHJe8vAClnd0frlAO283YacQXid0m Hi4C7VEF2a+HSTPKbJwqrN3HP7djzn/NfQSNUAaqJNYypbeZuU/Kn5fAh6v1bRNo/tXE XfiLbH+vAaFGy1M5Qu3LGRIrOprq6dCGRK9mMa4+7ZAgOX4PzUqzt10saAHuiVtflo1w pG/0LuwF7ARlw/OtGBWc/o1bdUv10EmvQor/quUKKhXttv9ScSQ45RzNxSDrbGUxcdT7 sKFac4zJYOdWfFlsi0P3Nnfin+FdLCechQVG0Vh8tkB0P5zr1CzR0eVxLNO1gGdw10S3 QdkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732389232; x=1732994032; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uP8sm0BmUSXB0VQTeHnz/shWkT9DxzZuKdqp+9Ia1zs=; b=PM8QZSDJlBCfsviNqyDIbmTpwWajcimp+t6CYI7i1D/KmIuPB6W4xtfedOhwKIbaFc TREmQr01BsjeFt3yaONGgiGcbZPoMZZBRSmOrrDhQLkm/S8zdoFHKmcrXjci8d2ljkr/ +wcUcbXUN0hN8W/lUtmsYzrQnTmATrtfhFYejMRRRA32GJmRA5D6p+r+WcI92+A2KqPi 0H21TFuzNuTab1DZl8qfeullr9thRzetQ6DMHOu2blnvG0O5E4lnoHC6y5ZeMlGhw/Z/ gY3EmBYw0Pf9RYPWSVUflAGflQHnv5FllU6oDF9FENruHxZb7D4VGrjea+ueiKW5MW6b g/4A== X-Forwarded-Encrypted: i=1; AJvYcCVQB6A43GZv5BeqDbxvUeZrdx+E/WQKhNHpzBVdcM7oYEPBRgr4ej7KU3ETgG6h+ELwzgw765CxyQ==@gnu.org, AJvYcCXV9+UWFtFRDf3rXUthUJ5hi9MP6lASMG7tlqhESbRH8fYGennwfJ2VZV7SBUBLMw3G9bSyxfulFPUaYQ4=@gnu.org X-Gm-Message-State: AOJu0Yw3RX+6ArQ9wswatc4w9WV8z108WEaByFh+rQuCAh05KFuuKmGk phNc+lNy2egbXuRD5boscF9HpWvkHe2TiWWHk0m3L7q4q0cgxNsRp/uuJ0FHhjOkLiN90f5mq4l S4959rQHfngaOKqjyKZoBgEFDvP0= X-Gm-Gg: ASbGncvDFrmfHHryTpGCaC8kcdpC9F3/gE3i8C+yf1O0Js6gKQRlnaGnolGo/icjaGt B+gu7zzuSwWEMjdHlH6wDGf+YK1lVGv6YAQ== X-Google-Smtp-Source: AGHT+IH21sAkFf5odyHuO7+iDN+0uza04qt3tWp2OthSD+q5YlX65Y6AG7+UK1c65Tdx5r4g1kVy4TNewez6GOwvb6o= X-Received: by 2002:a17:907:3685:b0:a9a:6c41:50a8 with SMTP id a640c23a62f3a-aa4efb762ffmr1232072766b.17.1732389231918; Sat, 23 Nov 2024 11:13:51 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 23 Nov 2024 14:13:51 -0500 In-Reply-To: <87y11a13vx.fsf@mat.ucm.es> Received-SPF: pass client-ip=2a00:1450:4864:20::636; envelope-from=stefankangas@gmail.com; helo=mail-ej1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325633 Archived-At: Uwe Brauer writes: >>>> "SK" == Stefan Kangas writes: > >> Philip Kaludercic writes: >>> +(defconst matlab-mode-version (package-get-version) >>> + "Current version of MATLAB(R) mode.") > >> We have tried to discourage the addition of such variables and commands, >> given that one can always find that information by other means, >> e.g. interactively with `describe-package` or from Lisp: > >> (package-desc-version (cadr (assq 'foo package-alist))) > > So you want me use just that string > well (package-desc-version (cadr (assq 'matlab-mode package-alist))) > I presume > > in matlab.el (and matlab-mode.el)? That's what I would do, indeed. Well, I'd use this if you need the string form: (package-version-join (package-desc-version (cadr (assq 'matlab-mode package-alist)))) Yeah, it's a bit of a mouthful. Most packages don't bother, and just rely on `describe-package`, I think. That said, there's nothing wrong with keeping it around; it just seems redundant now that you have a "Version" header. I mostly mentioned it for the record, and in case you wanted to get rid of some possible redundancy. (Personally, I'm not sure if the `matlab-show-version` command is needed either given that we have `describe-package`. In emacs.git, we tend to make such `foo-package-version` commands obsolete.) > What's about our current setting > > (defconst matlab-mode-version "6.2" > "Current version of MATLAB(R) mode.") > > Which we need for MELPA? Hmm, are you sure that you need it for MELPA even with the addition of the "Version" header? In any case, this is an extremely minor nit either way.