unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Uwe Brauer <oub@mat.ucm.es>
Cc: Philip Kaludercic <philipk@posteo.net>,
	Andrea Corallo <acorallo@gnu.org>,
	emacs-devel@gnu.org
Subject: Re: having emacs-matlab in ELPA, finally. FSF paper signed
Date: Sat, 23 Nov 2024 14:13:51 -0500	[thread overview]
Message-ID: <CADwFkmmVNYrZGfMq95VS0M60E9u+_sdJjEPFpLpqKrsxrVGn=Q@mail.gmail.com> (raw)
In-Reply-To: <87y11a13vx.fsf@mat.ucm.es>

Uwe Brauer <oub@mat.ucm.es> writes:

>>>> "SK" == Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Philip Kaludercic <philipk@posteo.net> writes:
>>> +(defconst matlab-mode-version (package-get-version)
>>> +  "Current version of MATLAB(R) mode.")
>
>> We have tried to discourage the addition of such variables and commands,
>> given that one can always find that information by other means,
>> e.g. interactively with `describe-package` or from Lisp:
>
>>     (package-desc-version (cadr (assq 'foo package-alist)))
>
> So you want me use just that string
> well (package-desc-version (cadr (assq 'matlab-mode package-alist)))
> I presume
>
> in matlab.el (and matlab-mode.el)?

That's what I would do, indeed.  Well, I'd use this if you need the
string form:

    (package-version-join
     (package-desc-version (cadr (assq 'matlab-mode package-alist))))

Yeah, it's a bit of a mouthful.  Most packages don't bother, and just
rely on `describe-package`, I think.

That said, there's nothing wrong with keeping it around; it just seems
redundant now that you have a "Version" header.  I mostly mentioned it
for the record, and in case you wanted to get rid of some possible
redundancy.

(Personally, I'm not sure if the `matlab-show-version` command is needed
either given that we have `describe-package`.  In emacs.git, we tend to
make such `foo-package-version` commands obsolete.)

> What's about our current setting
>
> (defconst matlab-mode-version "6.2"
>   "Current version of MATLAB(R) mode.")
>
> Which we need for MELPA?

Hmm, are you sure that you need it for MELPA even with the addition of
the "Version" header?

In any case, this is an extremely minor nit either way.



  reply	other threads:[~2024-11-23 19:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 12:45 having emacs-matlab in ELPA, finally. FSF paper signed Uwe Brauer
2024-08-06 21:55 ` Andrea Corallo
2024-08-07 17:03   ` Uwe Brauer
2024-08-07 17:54     ` Andrea Corallo
2024-08-12 11:20     ` Philip Kaludercic
2024-08-12 11:33       ` Andreas Schwab
2024-08-12 11:38         ` Philip Kaludercic
2024-08-12 12:16       ` Uwe Brauer
2024-08-12 12:29         ` Philip Kaludercic
2024-08-12 14:58           ` Uwe Brauer
2024-08-12 15:06             ` Philip Kaludercic
2024-08-12 15:17               ` Uwe Brauer
2024-08-12 16:11                 ` Philip Kaludercic
2024-11-22 16:12           ` Uwe Brauer
2024-11-23 10:30             ` Philip Kaludercic
2024-11-23 12:07               ` Stefan Kangas
2024-11-23 13:22                 ` Uwe Brauer
2024-11-23 19:13                   ` Stefan Kangas [this message]
2024-11-23 13:19               ` Uwe Brauer via Matlab-emacs-discuss
2024-11-23 13:30               ` having emacs-matlab in ELPA, finally. FSF paper signed, " Uwe Brauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmmVNYrZGfMq95VS0M60E9u+_sdJjEPFpLpqKrsxrVGn=Q@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=acorallo@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=oub@mat.ucm.es \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).