From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Include which-key.el in the Emacs distribution Date: Tue, 8 Sep 2020 20:40:22 +0000 Message-ID: References: <83sgbskwq8.fsf@gnu.org> <87pn6wi2zs.fsf@gnu.org> <83mu20kusi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7009"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Alfred M. Szmidt" , Amin Bandali , emacs-devel To: Justin Burkett , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 08 22:41:15 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFkQV-0001hG-Lx for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Sep 2020 22:41:15 +0200 Original-Received: from localhost ([::1]:51490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFkQU-0006M5-Mq for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Sep 2020 16:41:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFkPj-0005Wb-PZ for emacs-devel@gnu.org; Tue, 08 Sep 2020 16:40:27 -0400 Original-Received: from mail-ej1-f48.google.com ([209.85.218.48]:44685) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFkPi-0000eU-3C; Tue, 08 Sep 2020 16:40:27 -0400 Original-Received: by mail-ej1-f48.google.com with SMTP id r7so274311ejs.11; Tue, 08 Sep 2020 13:40:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=/ZHBhD/ML9MVP3KUHr0qWihhiPKTmnqAkzyYcdIQUEA=; b=aiCgIidl9AklM/A7kHBM1IRHrgXhBnk2q9vRBajGIm/jQUjREE9+d6ytnPINQYGSvC WSldqdzagAYJxrla0CnIVI8Ty13MtkpQm1Pj9oZ/5sOBf7hvbZohBJ4q8CZy5wIsm2TL nwuv61fcFsYei4k1c0oeMU+NkW7ASvX3X0IlLdbKUetGN6WU1Q4eyhw4ns6TqvTEypqS O9HBrYMFeO+eNOCDW0bF4ukeGhDwy+94SeA+53ICFyfelraNjiuhtA/czNpX8pjAKZY4 A2D1SA91YcfsvYrv2WHicSQFKwJL+a8jmEhk428YJS8+dZLZCeypWKxOVtoYPVJ+uDez cBbQ== X-Gm-Message-State: AOAM532CCEqm5zWTNH+wuSZwGziEqhjZdXY4J2BKaZXlx1vw+gJ6+3pg gZjdGRwQ1X36xSfwlMiZ+uaQBH6Nue2XNsyO1qE= X-Google-Smtp-Source: ABdhPJwvVw1S+iWrxDRUuiH1R1swhUO8o/ppT10OZK55XSo9ZNBx880tZY2n0l2wkFeIFR0ZPGEnGNTs8qCqltYnlXk= X-Received: by 2002:a17:906:11d2:: with SMTP id o18mr267665eja.420.1599597623322; Tue, 08 Sep 2020 13:40:23 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 8 Sep 2020 20:40:22 +0000 In-Reply-To: Received-SPF: pass client-ip=209.85.218.48; envelope-from=stefankangas@gmail.com; helo=mail-ej1-f48.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/08 16:40:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254812 Archived-At: Justin Burkett writes: >> When I type "C-h" with which-key-mode on, I see a paging hint at the >> bottom line, and that hint simply doesn't work (and nothing else I >> tried does). > > Ah, if it's just about the hint, then yes, that should be hidden in that > case. Thanks, I see that you already did that: https://github.com/justbur/emacs-which-key/commit/a70fc16adcf604f2cb8061d77813354da018c541 > I wasn't advocating for it to be on by default, but yes, the UI could > probably be improved. It's a difficult problem (at least for me), because I > wanted which-key to be passive and not interfere with how emacs processes > key sequences. That's why I used the help-char escape mechanism to do the > paging. As far as the default keys, that's an easy change of course. Does it make sense to support all three of n/p, C-n/C-p and C-v/M-v? While updating the minibuffer help text to promote the more standard key bindings C-v/M-v?