Re: master bb666073d3: Allow interpolating scrolls via the Page Down and Page Up keys

unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed

* Re: master bb666073d3: Allow interpolating scrolls via the Page Down and Page Up keys
       [not found] ` <20211226023659.B0470C04DCC@vcs2.savannah.gnu.org>
@ 2021-12-26 16:53   ` Stefan Monnier
  2021-12-26 17:09     ` Stefan Kangas
  2021-12-27  0:52     ` Po Lu
  0 siblings, 2 replies; 5+ messages in thread
From: Stefan Monnier @ 2021-12-26 16:53 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

> -    (define-key map [wheel-down] #'pixel-scroll-precision)
> -    (define-key map [wheel-up] #'pixel-scroll-precision)
> -    (define-key map [touch-end] #'pixel-scroll-start-momentum)
> -    (define-key map [mode-line wheel-down] #'pixel-scroll-precision)
> -    (define-key map [mode-line wheel-up] #'pixel-scroll-precision)
> -    (define-key map [mode-line touch-end] #'pixel-scroll-start-momentum)
> -    (define-key map [header-line wheel-down] #'pixel-scroll-precision)
> -    (define-key map [header-line wheel-up] #'pixel-scroll-precision)
> -    (define-key map [header-line touch-end] #'pixel-scroll-start-momentum)
> -    (define-key map [vertical-scroll-bar wheel-down] #'pixel-scroll-precision)
> -    (define-key map [vertical-scroll-bar wheel-up] #'pixel-scroll-precision)
> -    (define-key map [vertical-scroll-bar touch-end] #'pixel-scroll-start-momentum)
> -    (define-key map [left-margin wheel-down] #'pixel-scroll-precision)
> -    (define-key map [left-margin wheel-up] #'pixel-scroll-precision)
> -    (define-key map [left-margin touch-end] #'pixel-scroll-start-momentum)
> -    (define-key map [right-margin wheel-down] #'pixel-scroll-precision)
> -    (define-key map [right-margin wheel-up] #'pixel-scroll-precision)
> -    (define-key map [right-margin touch-end] #'pixel-scroll-start-momentum)
> -    (define-key map [left-fringe wheel-down] #'pixel-scroll-precision)
> -    (define-key map [left-fringe wheel-up] #'pixel-scroll-precision)
> -    (define-key map [left-fringe touch-end] #'pixel-scroll-start-momentum)
> -    (define-key map [right-fringe wheel-down] #'pixel-scroll-precision)
> -    (define-key map [right-fringe wheel-up] #'pixel-scroll-precision)
> -    (define-key map [right-fringe touch-end] #'pixel-scroll-start-momentum)
> +    (define-key map [wheel-down] 'pixel-scroll-precision)
> +    (define-key map [wheel-up] 'pixel-scroll-precision)
> +    (define-key map [touch-end] 'pixel-scroll-start-momentum)
> +    (define-key map [mode-line wheel-down] 'pixel-scroll-precision)
> +    (define-key map [mode-line wheel-up] 'pixel-scroll-precision)
> +    (define-key map [mode-line touch-end] 'pixel-scroll-start-momentum)
> +    (define-key map [header-line wheel-down] 'pixel-scroll-precision)
> +    (define-key map [header-line wheel-up] 'pixel-scroll-precision)
> +    (define-key map [header-line touch-end] 'pixel-scroll-start-momentum)
> +    (define-key map [vertical-scroll-bar wheel-down] 'pixel-scroll-precision)
> +    (define-key map [vertical-scroll-bar wheel-up] 'pixel-scroll-precision)
> +    (define-key map [vertical-scroll-bar touch-end] 'pixel-scroll-start-momentum)
> +    (define-key map [left-margin wheel-down] 'pixel-scroll-precision)
> +    (define-key map [left-margin wheel-up] 'pixel-scroll-precision)
> +    (define-key map [left-margin touch-end] 'pixel-scroll-start-momentum)
> +    (define-key map [right-margin wheel-down] 'pixel-scroll-precision)
> +    (define-key map [right-margin wheel-up] 'pixel-scroll-precision)
> +    (define-key map [right-margin touch-end] 'pixel-scroll-start-momentum)
> +    (define-key map [left-fringe wheel-down] 'pixel-scroll-precision)
> +    (define-key map [left-fringe wheel-up] 'pixel-scroll-precision)
> +    (define-key map [left-fringe touch-end] 'pixel-scroll-start-momentum)
> +    (define-key map [right-fringe wheel-down] 'pixel-scroll-precision)
> +    (define-key map [right-fringe wheel-up] 'pixel-scroll-precision)
> +    (define-key map [right-fringe touch-end] 'pixel-scroll-start-momentum)
> +    (define-key map [next] 'pixel-scroll-interpolate-down)
> +    (define-key map [prior] 'pixel-scroll-interpolate-up)

Why remove the `#`?


        Stefan




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master bb666073d3: Allow interpolating scrolls via the Page Down and Page Up keys
  2021-12-26 16:53   ` master bb666073d3: Allow interpolating scrolls via the Page Down and Page Up keys Stefan Monnier
@ 2021-12-26 17:09     ` Stefan Kangas
  2021-12-27  0:53       ` Po Lu
  2021-12-27  0:52     ` Po Lu
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2021-12-26 17:09 UTC (permalink / raw)
  To: Stefan Monnier, Po Lu; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Why remove the `#`?

BTW, could we use `keymap-set' or in this case `defvar-keymap' in new
code that is only intended for use with the latest version of Emacs?

Thanks.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master bb666073d3: Allow interpolating scrolls via the Page Down and Page Up keys
  2021-12-26 17:09     ` Stefan Kangas
@ 2021-12-27  0:53       ` Po Lu
  0 siblings, 0 replies; 5+ messages in thread
From: Po Lu @ 2021-12-27  0:53 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Stefan Monnier, emacs-devel

Stefan Kangas <stefankangas@gmail.com> writes:

> BTW, could we use `keymap-set' or in this case `defvar-keymap' in new
> code that is only intended for use with the latest version of Emacs?

I'm more comfortable with traditional keymap definitions.

Also, before converting anything in pixel-scroll.el or xwidgets.el,
please let me know first.

Thanks.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master bb666073d3: Allow interpolating scrolls via the Page Down and Page Up keys
  2021-12-26 16:53   ` master bb666073d3: Allow interpolating scrolls via the Page Down and Page Up keys Stefan Monnier
  2021-12-26 17:09     ` Stefan Kangas
@ 2021-12-27  0:52     ` Po Lu
  2021-12-27  4:13       ` Stefan Monnier
  1 sibling, 1 reply; 5+ messages in thread
From: Po Lu @ 2021-12-27  0:52 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Why remove the `#`?

It was put there by mistake.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master bb666073d3: Allow interpolating scrolls via the Page Down and Page Up keys
  2021-12-27  0:52     ` Po Lu
@ 2021-12-27  4:13       ` Stefan Monnier
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2021-12-27  4:13 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

>> Why remove the `#`?
> It was put there by mistake.

The use #' is recommended because it lets the compiler warn you when you
make a typo.


        Stefan




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-12-27  4:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <164048621945.4206.11469219761834055110@vcs2.savannah.gnu.org>
     [not found] ` <20211226023659.B0470C04DCC@vcs2.savannah.gnu.org>
2021-12-26 16:53   ` master bb666073d3: Allow interpolating scrolls via the Page Down and Page Up keys Stefan Monnier
2021-12-26 17:09     ` Stefan Kangas
2021-12-27  0:53       ` Po Lu
2021-12-27  0:52     ` Po Lu
2021-12-27  4:13       ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).