From: Stefan Kangas <stefankangas@gmail.com>
To: Pip Cet <pipcet@protonmail.com>
Cc: "Andrea Corallo" <acorallo@gnu.org>,
"Eli Zaretskii" <eliz@gnu.org>,
"Mattias Engdegård" <mattiase@acm.org>,
"Paul Eggert" <eggert@cs.ucla.edu>,
emacs-devel@gnu.org, "João Távora" <joaotavora@gmail.com>
Subject: Re: New "make benchmark" target
Date: Sun, 15 Dec 2024 00:57:40 +0000 [thread overview]
Message-ID: <CADwFkmmRTp1+YEK2TUqc6WsTjk3jHr3NSjoxtbz2QF76v00tKw@mail.gmail.com> (raw)
In-Reply-To: <875xnmf2qp.fsf@protonmail.com>
Pip Cet <pipcet@protonmail.com> writes:
> Just to be clear, dropping the branch in GNU ELPA wouldn't mean that the
> package would no longer be available, just that it would build signed
> packages from the main Emacs repo?
Yes.
>> João has some scripts that he used for eglot, and I adapted them for
>> use-package. Note that he also had some copyright assignment issues to
>> take care of, so it could probably be simplified.
>>
>> Please take a look here:
>> https://gist.github.com/joaotavora/2ed97f2ec85958986983d5cb78202770
>
> Thanks for the pointer! I tried getting that to work, and finally
> succeeded in creating a (local) merged brach, but then I noticed that
> the commit messages will need editing to conform to the ChangeLog style.
I guess there's no clear drawback creating the ChangeLog entries for
each commit, but it's not required. Only the final merge commit needs a
ChangeLog entry.
I guess that entry will look something like this:
* lisp/emacs-lisp/elisp-benchmarks.el:
* lisp/emacs-lisp/benchmarks/bubble.el:
* lisp/emacs-lisp/benchmarks/pidigits.el: New files.
(Incidentally, this is the same ChangeLog entry we would use if we just
copied the files without preserving history.)
> We also need to decide on the directory structure; right now, I've
> created a lisp/emacs-lisp/benchmarks/ directory; I'd prefer
> lisp/benchmarks (which would make it easier to exclude the benchmark
> files from compilation), but I don't have a strong preference and others
> should make that decision. (I haven't included the
> lisp/emacs-lisp/subdirs.el file, but if we decide to keep the benchmarks
> in lisp/emacs-lisp/benchmarks/, we'll need to gitignore that, too).
I don't have a strong opinion here, but maybe this stuff belongs under
test/ even?
> I'm not sure how to proceed here. Since there aren't that many commits,
> I can offer to change the commit messages myself, but I fully understand
> if someone else (Andrea or another volunteer) wants to do it.
FWIW, I'd just go ahead without waiting for someone else.
next prev parent reply other threads:[~2024-12-15 0:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 22:37 Improving EQ Pip Cet via Emacs development discussions.
2024-12-12 6:36 ` Eli Zaretskii
2024-12-12 8:23 ` Andrea Corallo
2024-12-12 8:36 ` Pip Cet via Emacs development discussions.
2024-12-12 9:18 ` Eli Zaretskii
2024-12-12 9:35 ` Visuwesh
2024-12-12 10:40 ` Andrea Corallo
2024-12-12 17:46 ` Pip Cet via Emacs development discussions.
2024-12-12 19:09 ` Eli Zaretskii
2024-12-12 10:53 ` New "make benchmark" target Stefan Kangas
2024-12-12 10:59 ` Andrea Corallo
2024-12-12 16:53 ` Pip Cet via Emacs development discussions.
2024-12-13 0:49 ` Stefan Kangas
2024-12-13 7:37 ` Andrea Corallo
2024-12-14 12:00 ` Stefan Kangas
2024-12-14 14:06 ` Stefan Monnier
2024-12-14 11:34 ` Pip Cet via Emacs development discussions.
2024-12-14 11:58 ` Stefan Kangas
2024-12-14 20:07 ` Pip Cet via Emacs development discussions.
2024-12-14 20:20 ` João Távora
2024-12-15 0:57 ` Stefan Kangas [this message]
2024-12-15 0:58 ` Stefan Kangas
2024-12-12 10:42 ` Improving EQ Óscar Fuentes
2024-12-12 10:50 ` Andrea Corallo
2024-12-12 11:21 ` Óscar Fuentes
2024-12-13 12:24 ` Pip Cet via Emacs development discussions.
2024-12-12 17:05 ` Pip Cet via Emacs development discussions.
2024-12-12 18:10 ` John ff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmmRTp1+YEK2TUqc6WsTjk3jHr3NSjoxtbz2QF76v00tKw@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=acorallo@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
--cc=mattiase@acm.org \
--cc=pipcet@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).